Skip to content

Commit 2c642ab

Browse files
authored
Don't import functions from miniUI, profvis, urlchecker (#2526)
Closes #2524
1 parent 9568e51 commit 2c642ab

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

NAMESPACE

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,15 +85,13 @@ importFrom(cli,cat_rule)
8585
importFrom(ellipsis,check_dots_used)
8686
importFrom(lifecycle,deprecated)
8787
importFrom(memoise,memoise)
88-
importFrom(miniUI,miniPage)
8988
importFrom(pkgbuild,clean_dll)
9089
importFrom(pkgbuild,find_rtools)
9190
importFrom(pkgbuild,has_devel)
9291
importFrom(pkgbuild,with_debug)
9392
importFrom(pkgload,check_dep_version)
9493
importFrom(pkgload,parse_deps)
9594
importFrom(pkgload,unload)
96-
importFrom(profvis,profvis)
9795
importFrom(remotes,dev_package_deps)
9896
importFrom(remotes,github_pull)
9997
importFrom(remotes,github_release)
@@ -112,7 +110,6 @@ importFrom(remotes,update_packages)
112110
importFrom(sessioninfo,package_info)
113111
importFrom(sessioninfo,session_info)
114112
importFrom(stats,update)
115-
importFrom(urlchecker,url_check)
116113
importFrom(usethis,ui_code)
117114
importFrom(usethis,ui_done)
118115
importFrom(usethis,ui_field)

R/devtools-package.R

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,12 @@
1111

1212
## usethis namespace: start
1313
#' @importFrom lifecycle deprecated
14-
#' @importFrom miniUI miniPage
15-
#' @importFrom profvis profvis
16-
#' @importFrom urlchecker url_check
1714
## usethis namespace: end
1815
NULL
16+
17+
# https://r-pkgs.org/dependencies-in-practice.html#how-to-not-use-a-package-in-imports
18+
ignore_unused_imports <- function() {
19+
miniUI::miniPage
20+
profvis::profvis
21+
urlchecker::url_check
22+
}

0 commit comments

Comments
 (0)