We haven't connected dark mode to brand.logo.*.dark.
We also need to connect it to brand.dark.logo.*.dark.
Implementing dark mode should be much the same as renderings: [light, dark]: we insert both images and add .light-content, .dark-content to them.
Favicons are different. Worst case we add both and then disable one <link /> in JavaScript the way we do with stylesheets, but maybe there is a better way.
(It might make more sense to use the prefers-color-scheme media query for favicons because they’re outside the page and should follow system preferences.)
We haven't connected dark mode to
brand.logo.*.dark.We also need to connect it to
brand.dark.logo.*.dark.Implementing dark mode should be much the same as
renderings: [light, dark]: we insert both images and add.light-content,.dark-contentto them.Favicons are different. Worst case we add both and then disable one
<link />in JavaScript the way we do with stylesheets, but maybe there is a better way.(It might make more sense to use the
prefers-color-schememedia query for favicons because they’re outside the page and should follow system preferences.)