Add tests and fix issue in passing options

Author: cderv

src/project/types/website/website-search.ts

@@ -617,22 +617,28 @@ export async function websiteSearchIncludeInHeader(
     }
   });
 
-  const searchOptionsJson = JSON.stringify(options, null, 2);
-  const searchOptionsScript =
-    `<script id="quarto-search-options" type="application/json">${searchOptionsJson}</script>`;
-  const includes = [searchOptionsScript];
+  const includes: string[] = [];
 
+  // Process all Algolia configuration and scripts
   if (options[kAlgolia]) {
     includes.push(kAlogioSearchApiScript);
-    if (options[kAlgolia]?.[kAnalyticsEvents]) {
+    if (options[kAlgolia][kAnalyticsEvents]) {
       const cookieConsent = cookieConsentEnabled(project);
-      // Pass cookie consent status to JavaScript for Algolia Insights configuration
+      // Set cookie consent flag for JavaScript configuration
       options[kAlgolia][kCookieConsentEnabled] = cookieConsent;
+      // Add Algolia Insights scripts with proper consent handling
       includes.push(algoliaSearchInsightsScript(cookieConsent));
       includes.push(autocompleteInsightsPluginScript(cookieConsent));
     }
   }
 
+  // Serialize search options to JSON after all modifications
+  const searchOptionsJson = JSON.stringify(options, null, 2);
+  const searchOptionsScript =
+    `<script id="quarto-search-options" type="application/json">${searchOptionsJson}</script>`;
+  // Prepend search options script to beginning of includes
+  includes.unshift(searchOptionsScript);
+
   Deno.writeTextFileSync(websiteSearchScript, includes.join("\n"));
   return websiteSearchScript;
 }

tests/docs/smoke-all/search/algolia-no-consent/.gitignore

@@ -0,0 +1,2 @@
+/.quarto/
+**/*.quarto_ipynb

tests/docs/smoke-all/search/algolia-no-consent/_quarto.yml

@@ -0,0 +1,17 @@
+project:
+  type: website
+
+website:
+  title: "Algolia Without Cookie Consent Test"
+  search:
+    algolia:
+      application-id: "TEST_APP_ID"
+      search-only-api-key: "TEST_API_KEY"
+      index-name: "test-index"
+      analytics-events: true
+  # This is the default and should act as such
+  # cookie-consent: false
+
+format:
+  html:
+    theme: cosmo

tests/docs/smoke-all/search/algolia-no-consent/index.qmd

@@ -0,0 +1,25 @@
+---
+title: "Algolia Search Without Cookie Consent"
+_quarto:
+  tests:
+    html:
+      ensureHtmlElements:
+        # Ensure search options script exists
+        - ['script#quarto-search-options']
+      ensureFileRegexMatches:
+        - 
+          # Cookie consent should be false
+          - '"cookie-consent-enabled":\s*false'
+          # Scripts should load immediately with type="text/javascript"
+          - '<script[^>]*type="text/javascript">[\s\S]+search-insights'
+        - 
+          # Verify scripts do NOT have cookie-consent attribute
+          - '<script[^>]*cookie-consent[^>]+>[\s\S]*search-insights'
+---
+
+This test verifies that when `cookie-consent` is NOT configured in the website settings:
+
+1. The Algolia search options JSON contains `"cookie-consent-enabled": false` (or the key is absent)
+2. Algolia Insights scripts are loaded immediately with `type="text/javascript"`
+3. Scripts are not deferred behind cookie consent (no `cookie-consent="tracking"` attribute)
+

tests/docs/smoke-all/search/algolia-with-consent/.gitignore

@@ -0,0 +1,2 @@
+/.quarto/
+**/*.quarto_ipynb

tests/docs/smoke-all/search/algolia-with-consent/_quarto.yml

@@ -0,0 +1,16 @@
+project:
+  type: website
+
+website:
+  title: "Algolia With Cookie Consent Test"
+  search:
+    algolia:
+      application-id: "TEST_APP_ID"
+      search-only-api-key: "TEST_API_KEY"
+      index-name: "test-index"
+      analytics-events: true
+  cookie-consent: true
+
+format:
+  html:
+    theme: cosmo

tests/docs/smoke-all/search/algolia-with-consent/index.qmd

@@ -0,0 +1,25 @@
+---
+title: "Algolia Search With Cookie Consent"
+_quarto:
+  tests:
+    html:
+      ensureHtmlElements:
+        - 
+          # Ensure search options script exists
+          - 'script#quarto-search-options'
+          # Cookie consent element are loaded 
+          - script[src$='cookie-consent.js']
+      ensureFileRegexMatches:
+        - 
+          # Cookie consent should be enabled
+          - '"cookie-consent-enabled":\s*true'
+          # Scripts should be deferred with cookie-consent attribute
+          - 'type="text/plain"[^>]*cookie-consent="tracking"[^>]*>[\s\S]*search-insights'
+---
+
+This test verifies that when `cookie-consent` is configured in the website settings:
+
+1. The Algolia search options JSON contains `"cookie-consent-enabled": true`
+2. Algolia Insights scripts are deferred with `type="text/plain" cookie-consent="tracking"`
+3. Scripts only execute after user grants "tracking" consent
+4. Cookie consent UI elements are present on the page