Skip to content

Commit 85fec84

Browse files
committed
Use asArray utility to simplify OS filtering logic
Replaces separate string/array handling with asArray helper.
1 parent 2b9510c commit 85fec84

1 file changed

Lines changed: 3 additions & 12 deletions

File tree

tests/smoke/smoke-all.test.ts

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import {
1212
setInitializer,
1313
} from "../../src/core/lib/yaml-validation/state.ts";
1414
import { os } from "../../src/deno_ral/platform.ts";
15+
import { asArray } from "../../src/core/array.ts";
1516

1617
import { breakQuartoMd } from "../../src/core/lib/break-quarto-md.ts";
1718
import { parse } from "../../src/core/yaml.ts";
@@ -103,18 +104,8 @@ function skipTest(metadata: Record<string, any>): string | undefined {
103104

104105
// Skip on specific OS if skip-on-os is set
105106
const skipOnOs = quartoMeta?.["skip-on-os"];
106-
if (skipOnOs !== undefined) {
107-
// Handle array of OSes
108-
if (Array.isArray(skipOnOs)) {
109-
if (skipOnOs.includes(os)) {
110-
return `skip-on-os includes ${os}`;
111-
}
112-
}
113-
114-
// Handle single OS string
115-
if (typeof skipOnOs === "string" && skipOnOs === os) {
116-
return `skip-on-os is ${os}`;
117-
}
107+
if (skipOnOs !== undefined && asArray(skipOnOs).includes(os)) {
108+
return `skip-on-os includes ${os}`;
118109
}
119110

120111
return undefined;

0 commit comments

Comments
 (0)