From eb997d2c0de42827d2338f7caea8d7387cba6766 Mon Sep 17 00:00:00 2001 From: oliveman-au Date: Sat, 25 Apr 2026 20:58:50 +1000 Subject: [PATCH 1/3] Fix false error message when deleting reminders with duplicate IDs --- bot/exts/utils/reminders.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bot/exts/utils/reminders.py b/bot/exts/utils/reminders.py index 1b386ec000..e16aa51fe3 100644 --- a/bot/exts/utils/reminders.py +++ b/bot/exts/utils/reminders.py @@ -678,7 +678,7 @@ async def delete_reminder(self, ctx: Context, ids: Greedy[int]) -> None: title = random.choice(POSITIVE_REPLIES) deletion_message = f"Successfully deleted the following reminder(s): {', '.join(deleted_ids)}" - if len(deleted_ids) != len(ids): + if len(deleted_ids) != len(set(ids)): deletion_message += ( "\n\nThe other reminder(s) could not be deleted as they're either locked, " "belong to someone else, or don't exist." From 6392b8fd9ae004e72d69136666b0b8228e165ec1 Mon Sep 17 00:00:00 2001 From: oliveman-au Date: Sun, 26 Apr 2026 10:27:19 +1000 Subject: [PATCH 2/3] Fix silent placeholder when editing reminder content with empty reply --- bot/exts/utils/reminders.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/bot/exts/utils/reminders.py b/bot/exts/utils/reminders.py index e16aa51fe3..83b2f3e249 100644 --- a/bot/exts/utils/reminders.py +++ b/bot/exts/utils/reminders.py @@ -413,7 +413,8 @@ async def try_get_content_from_reply(ctx: Context) -> str: # If the replied message has no content, we couldn't get the content, or no content was provided # (e.g. only attachments/embeds) if content is None or content == "": - content = "*See referenced message.*" + await ctx.send("The referenced message has no content, please provide content directly.") + return None return content @@ -614,6 +615,8 @@ async def edit_reminder_content(self, ctx: Context, id_: int, *, content: str | """ if not content: content = await self.try_get_content_from_reply(ctx) + if content is None: + return await self.edit_reminder(ctx, id_, {"content": content}) From adab847743b90ce64a1fdf324d348db5c9ed0fe7 Mon Sep 17 00:00:00 2001 From: oliveman-au Date: Sun, 26 Apr 2026 10:36:55 +1000 Subject: [PATCH 3/3] Also fix silent placeholder in new_reminder when reply has no content --- bot/exts/utils/reminders.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bot/exts/utils/reminders.py b/bot/exts/utils/reminders.py index 83b2f3e249..3dd11c914c 100644 --- a/bot/exts/utils/reminders.py +++ b/bot/exts/utils/reminders.py @@ -493,6 +493,8 @@ async def new_reminder( # If `content` isn't provided then we try to get message content of a replied message if not content: content = await self.try_get_content_from_reply(ctx) + if content is None: + return # Now we can attempt to actually set the reminder. reminder = await self.bot.api_client.post(