Fix BaseChecker.add_message unnecessary overrides (#10899)

* Remove redundant `line` argument in `unnecessary-lambda` add_message call

Lambdas never have `.position` set, so `_add_one_message` already
extracts `node.fromlineno`, passing it explicitly was a no-op.

* Use `assigned` node directly for `invalid-all-format` instead of module node

Pass the `__all__` value node to `add_message` instead of the module node
with manual line/col overrides. This also provides end_lineno/end_col_offset
for a more precise diagnostic span.

Existing callers that combined both location and nodes have been fixed:
- Redundant overrides removed (consider-using-f-string, too-many-try-statements,
  consider-using-augmented-assign, consider-refactoring-into-while-condition) except useless-else-on-loop. 

Co-authored-by: Claude Opus 4.6 <[email protected]>

Author: Pierre-Sassoulas

pylint/checkers/base/basic_checker.py

@@ -574,7 +574,7 @@ def visit_lambda(self, node: nodes.Lambda) -> None:
             if name.lookup(name.name)[0] is node:
                 return
 
-        self.add_message("unnecessary-lambda", line=node.fromlineno, node=node)
+        self.add_message("unnecessary-lambda", node=node)
 
     @utils.only_required_for_messages("dangerous-default-value")
     def visit_functiondef(self, node: nodes.FunctionDef) -> None:

pylint/checkers/base/basic_error_checker.py

@@ -544,9 +544,9 @@ def _check_else_on_loop(self, node: nodes.For | nodes.While) -> None:
             self.add_message(
                 "useless-else-on-loop",
                 node=node,
-                # This is not optimal, but the line previous
-                # to the first statement in the else clause
-                # will usually be the one that contains the else:.
+                # The else keyword has no AST node; the line before
+                # the first statement in the else clause is the best
+                # approximation of its location.
                 line=node.orelse[0].lineno - 1,
             )
 

pylint/checkers/refactoring/recommendation_checker.py

@@ -415,12 +415,7 @@ def _detect_replacable_format_call(self, node: nodes.Const) -> None:
                         return
 
             # If all tests pass, then raise message
-            self.add_message(
-                "consider-using-f-string",
-                node=node,
-                line=node.lineno,
-                col_offset=node.col_offset,
-            )
+            self.add_message("consider-using-f-string", node=node)
 
         elif isinstance(node.parent, nodes.BinOp) and node.parent.op == "%":
             # Backslashes can't be in f-string expressions
@@ -444,9 +439,4 @@ def _detect_replacable_format_call(self, node: nodes.Const) -> None:
                     return
 
             # If all tests pass, then raise message
-            self.add_message(
-                "consider-using-f-string",
-                node=node,
-                line=node.lineno,
-                col_offset=node.col_offset,
-            )
+            self.add_message("consider-using-f-string", node=node)

pylint/checkers/variables.py

@@ -3223,8 +3223,7 @@ def _check_all(
         if isinstance(assigned, util.UninferableBase):
             return
         if assigned.pytype() not in {"builtins.list", "builtins.tuple"}:
-            line, col = assigned.tolineno, assigned.col_offset
-            self.add_message("invalid-all-format", line=line, col_offset=col, node=node)
+            self.add_message("invalid-all-format", node=assigned)
             return
         for elt in getattr(assigned, "elts", ()):
             try:

pylint/extensions/broad_try_clause.py

@@ -64,9 +64,7 @@ def visit_try(self, node: nodes.Try) -> None:
                 f"try clause contains {try_clause_statements} statements, expected at"
                 f" most {self.linter.config.max_try_statements}"
             )
-            self.add_message(
-                "too-many-try-statements", node.lineno, node=node, args=msg
-            )
+            self.add_message("too-many-try-statements", node=node, args=msg)
 
 
 def register(linter: PyLinter) -> None:

pylint/extensions/code_style.py

@@ -351,8 +351,6 @@ def visit_assign(self, node: nodes.Assign) -> None:
                 "consider-using-augmented-assign",
                 args=f"{op}=",
                 node=node,
-                line=node.lineno,
-                col_offset=node.col_offset,
                 confidence=INFERENCE,
             )
 

pylint/extensions/consider_refactoring_into_while_condition.py

@@ -83,7 +83,6 @@ def _check_breaking_after_while_true(self, node: nodes.While) -> None:
         self.add_message(
             "consider-refactoring-into-while-condition",
             node=node,
-            line=node.lineno,
             args=(msg, node.test.as_string()),
             confidence=HIGH,
         )

tests/functional/i/invalid/invalid_all/invalid_all_format.txt

@@ -1,2 +1,2 @@
-invalid-all-format:5:11:None:None::Invalid format for __all__, must be tuple or list:UNDEFINED
+invalid-all-format:5:11:5:18::Invalid format for __all__, must be tuple or list:UNDEFINED
 superfluous-parens:5:0:None:None::Unnecessary parens after '=' keyword:UNDEFINED