Skip to content

Commit 7f2b8cf

Browse files
smaller changelog message
1 parent 33e1fff commit 7f2b8cf

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
1-
Skip expensive isort-based import classification in ``leave_module``
2-
when no import-ordering message is enabled (``wrong-import-order``,
3-
``ungrouped-imports``, ``wrong-import-position``). Also cache the
4-
``isort.Config`` object so it is built once instead of once per import
5-
statement. Both changes save ~6 s on ansible (564 files), a 17%
6-
reduction whether only ``cyclic-import`` is enabled (isort skipped
7-
entirely) or import-ordering checks are active (cached config avoids
8-
rebuilding it per import).
1+
Skip isort classification in the import checker when no import-ordering message is enabled,
2+
and cache the isort configuration so it is built once instead of once per import statement.
3+
Skipping the isort processing become a negligible improvement once the caching is applied.
4+
pylint became ~17% faster on ansible (~=4500 imports) even with isort enabled.
95

106
Refs #10886, #2866, #10637

0 commit comments

Comments
 (0)