Merge pull request #129 from webknjaz/patch-1

Allow installing the plugin with pylint v4

See details in: #129, and in the commit series

Author: stdedos

.github/workflows/checks.yaml

@@ -42,7 +42,7 @@ jobs:
             hashFiles('pyproject.toml', 'requirements/**.txt') }}" >> $GITHUB_OUTPUT
       - name: Restore Python virtual environment
         id: cache-venv
-        uses: actions/cache@v4.0.2
+        uses: actions/cache@9255dc7a253b0ccc959486e2bca901246202afeb # v5.0.1
         with:
           path: .venv
           key: >-
@@ -55,7 +55,7 @@ jobs:
             hashFiles('.pre-commit-config.yaml') }}" >> $GITHUB_OUTPUT
       - name: Restore pre-commit environment
         id: cache-precommit
-        uses: actions/cache@v4.0.2
+        uses: actions/cache@9255dc7a253b0ccc959486e2bca901246202afeb # v5.0.1
         with:
           path: ${{ env.PRE_COMMIT_CACHE }}
           key: >-
@@ -80,14 +80,14 @@ jobs:
           check-latest: true
       - name: Restore Python virtual environment
         id: cache-venv
-        uses: actions/cache@v4.0.2
+        uses: actions/cache@9255dc7a253b0ccc959486e2bca901246202afeb # v5.0.1
         with:
           path: .venv
           fail-on-cache-miss: true
           key: ${{ runner.os }}-${{ steps.python.outputs.python-version }}-${{ needs.prepare-base.outputs.python-key }}
       - name: Restore pre-commit environment
         id: cache-precommit
-        uses: actions/cache@v4.0.2
+        uses: actions/cache@9255dc7a253b0ccc959486e2bca901246202afeb # v5.0.1
         with:
           path: ${{ env.PRE_COMMIT_CACHE }}
           fail-on-cache-miss: true

.github/workflows/tests.yaml

@@ -20,11 +20,11 @@ jobs:
           - windows-latest
           - macos-latest
         python-version:
-          - '3.8'
-          - '3.9'
           - '3.10'
           - '3.11'
           - '3.12'
+          - '3.13'
+          - '3.14'
 
     defaults:
       run:
@@ -62,11 +62,11 @@ jobs:
         run: tox --skip-missing-interpreters=true
 
       - name: Upload coverage reports to Codecov
-        uses: codecov/codecov-action@v3
+        uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
+        if: ${{ !cancelled() }}
         with:
-          token: ${{ secrets.CODECOV_TOKEN }}
           flags: ${{ matrix.os }},${{ matrix.python-version }}
-          fail_ci_if_error: ${{ github.repository_owner == 'pylint-dev' && 'true' || 'false' }}
+          fail_ci_if_error: true
           files: test_artifacts/cobertura.xml
 
       - name: Create artifacts

.pre-commit-config.yaml

@@ -4,7 +4,7 @@ ci:
 
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.6.0
+    rev: v6.0.0
     hooks:
       - id: end-of-file-fixer
         exclude: ^.idea/
@@ -34,23 +34,28 @@ repos:
           - '4'
           - --offset
           - '2'
+  - repo: https://github.com/asottile/pyupgrade
+    rev: v3.21.2
+    hooks:
+      - id: pyupgrade
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.6.8
+    rev: v0.14.10
     hooks:
-      - id: ruff
+      - id: ruff-format
+      - id: ruff-check
         args:
           - --fix
         exclude: tests/input/
   - repo: https://github.com/psf/black
-    rev: 24.8.0
+    rev: 25.12.0
     hooks:
       - id: black
   - repo: https://github.com/asottile/blacken-docs
-    rev: 1.18.0
+    rev: 1.20.0
     hooks:
       - id: blacken-docs
         additional_dependencies:
-          - black==24.8.0
+          - black==25.12.0
   - repo: https://github.com/pre-commit/pygrep-hooks
     rev: v1.10.0
     hooks:
@@ -74,7 +79,7 @@ repos:
         language: pygrep
         types: [python]
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.11.2
+    rev: v1.19.1
     hooks:
       - id: mypy
         exclude: tests/input/

CHANGELOG.md

@@ -2,6 +2,19 @@
 
 ## [Unreleased]
 
+## [2.0.0a1] - _tbd; started 2025-10-17_
+
+A small pylint update lead into a full-blown dependency updates.
+
+That, additionally, lead to deprecating Python 3.8 and 3.9 support.
+_Technically_, as of writing this, https://devguide.python.org/versions/ does NOT show 3.9 as deprecated.
+However, many dependencies have already dropped support for them - and, according to the page, 3.9's deprecation date 2025-10.
+
+### Development details / information
+
+The project will _soon_ ™️ migrate to `uv` for anything related to packaging, testing, and building:
+https://github.com/pylint-dev/pylint-pytest/issues/132
+
 ## [2.0.0a0] - 2024-02-02
 
 ### Added

README.md

@@ -28,15 +28,15 @@ Requirements:
 To install:
 
 ```bash
-$ pip install pylint-pytest
+pip install pylint-pytest
 ```
 
 ## Usage
 
 Enable via command line option `--load-plugins`
 
 ```bash
-$ pylint --load-plugins pylint_pytest <path_to_your_sources>
+pylint --load-plugins pylint_pytest <path_to_your_sources>
 ```
 
 Or in `.pylintrc`:
@@ -67,8 +67,7 @@ from fixture_collections import (
 )  # <- Unused imported_fixture imported from fixture_collections
 
 
-def test_something(imported_fixture):
-    ...
+def test_something(imported_fixture): ...
 ```
 
 ### `redefined-outer-name`
@@ -130,16 +129,14 @@ import pytest
 
 
 @pytest.fixture
-def awesome_fixture():
-    ...
+def awesome_fixture(): ...
 
 
 @pytest.fixture
 @pytest.mark.usefixtures(
     "awesome_fixture"
 )  # <- Using useless `@pytest.mark.*` decorator for fixtures
-def another_awesome_fixture():
-    ...
+def another_awesome_fixture(): ...
 ```
 
 ### W6403 `deprecated-positional-argument-for-pytest-fixture`
@@ -151,8 +148,7 @@ import pytest
 
 
 @pytest.fixture("module")  # <- Using a deprecated positional arguments for fixture
-def awesome_fixture():
-    ...
+def awesome_fixture(): ...
 ```
 
 ### F6401 `cannot-enumerate-pytest-fixtures`

pylint_pytest/checkers/class_attr_loader.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from astroid import Assign, Attribute, ClassDef, Name
+from astroid.nodes import Assign, Attribute, ClassDef, Name
 
 from ..utils import _can_use_fixture, _is_class_autouse_fixture
 from . import BasePytestChecker
@@ -33,7 +33,7 @@ def visit_assign(self, node: Assign):
             and node.value.expr.name == "request"
         ):
             # storing the aliases for cls from request.cls
-            self.request_cls = set(t.name for t in node.targets)
+            self.request_cls = {t.name for t in node.targets}
 
     def visit_assignattr(self, node):
         if (

pylint_pytest/checkers/fixture.py

@@ -130,7 +130,7 @@ def visit_module(self, node):
 
                 FixtureChecker._pytest_fixtures = fixture_collector.fixtures
 
-                legitimate_failure_paths = set(
+                legitimate_failure_paths = {
                     collection_report.nodeid
                     for collection_report in fixture_collector.errors
                     if any(
@@ -140,7 +140,7 @@ def visit_module(self, node):
                         )
                         for pattern in FILE_NAME_PATTERNS
                     )
-                )
+                }
                 if (ret != pytest.ExitCode.OK or legitimate_failure_paths) and is_test_module:
                     files_to_report = {
                         str(Path(x).absolute().relative_to(Path.cwd()))

pylint_pytest/checkers/types.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
-from typing import Any, Dict, List
+from typing import Any
 
 from _pytest.fixtures import FixtureDef
 
-FixtureDict = Dict[str, List[FixtureDef[Any]]]
+FixtureDict = dict[str, list[FixtureDef[Any]]]

pylint_pytest/checkers/variables.py

@@ -2,7 +2,7 @@
 
 from typing import Any
 
-from astroid import Arguments, Module, NodeNG
+from astroid.nodes import Arguments, Module, NodeNG
 from pylint.checkers.variables import VariablesChecker
 from pylint.interfaces import Confidence
 

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "pylint-pytest"
-version = "2.0.0a0"
+version = "2.0.0a1"
 license = {file = "LICENSE"}
 description = "A Pylint plugin to suppress pytest-related false positives."
 
@@ -24,11 +24,11 @@ classifiers = [
     "Topic :: Software Development :: Quality Assurance",
     "Programming Language :: Python",
     "Programming Language :: Python :: 3",
-    "Programming Language :: Python :: 3.8",
-    "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
     "Programming Language :: Python :: 3.12",
+    "Programming Language :: Python :: 3.13",
+    "Programming Language :: Python :: 3.14",
     "Programming Language :: Python :: Implementation :: CPython",
     "Operating System :: OS Independent",
     "License :: OSI Approved :: MIT License",
@@ -39,9 +39,9 @@ keywords = [
     "plugin",
 ]
 
-requires-python = ">=3.8"
+requires-python = ">= 3.10"
 dependencies = [
-    "pylint>=2,<4",
+    "pylint >=2, <5",
     "pytest>=4.6",
 ]
 
@@ -106,7 +106,7 @@ paths.source = [
 profile = "black"
 
 [tool.mypy]
-python_version = "3.8"
+python_version = "3.10"
 check_untyped_defs = true
 explicit_package_bases = true
 namespace_packages = true
@@ -148,8 +148,6 @@ fix = true
 # (for docstrings, strings and comments in particular).
 line-length = 100
 
-target-version = "py38"
-
 [tool.ruff.lint]
 select = [
     "E",  # pycodestyle