20 - Removing unsed code

Author: dineshtrivedi

README.md

@@ -18,9 +18,9 @@ source .pylint-plugin-utils/bin/activate
 pip install --upgrade pip setuptools
 ```
 
-We use [tox](https://tox.readthedocs.io/en/latest/) and [pytest-benchmark](https://pytest-benchmark.readthedocs.io/en/latest/index.html) for running the test suite. You should be able to install it with:
+We use [tox](https://tox.readthedocs.io/en/latest/) for running the test suite. You should be able to install it with:
 ```bash
-pip install tox pytest pytest-benchmark
+pip install tox pytest
 ```
 
 To run the test suite for a particular Python version, you can do:
@@ -30,7 +30,7 @@ tox -e py38
 
 To run individual tests with ``tox``, you can do::
 ```bash
-tox -e py38 -- -k name_of_the_test
+tox -e py38 -- -k test_linter_should_be_pickleable
 ```
 
 We use pytest_ for testing ``pylint``, which you can use without using ``tox`` for a faster development cycle.
@@ -43,8 +43,6 @@ python3 -m pytest tests/ --cov=pylint_plugin_utils
 coverage html
 ```
 
-
-
 # License
 
 `pylint-plugin-utils` is available under the GPLv2 License.

setup.py

@@ -29,7 +29,7 @@
     author_email="[email protected]",
     description=_short_description,
     version=_version,
-    install_requires=["pylint>=1.7", "pytest"],
+    install_requires=["pylint>=1.7"],
     packages=_packages,
     license="GPLv2",
     classifiers=_classifiers,

tests/conftest.py

@@ -1,15 +1,7 @@
-# pylint: disable=redefined-outer-name
-from pathlib import Path
-
 import pytest
 from pylint.lint import PyLinter
 
 
-@pytest.fixture()
-def tests_directory():
-    return Path(__file__).parent
-
-
 @pytest.fixture
 def linter():
     _linter = PyLinter()

tests/input/__init__.py

@@ -1,31 +1,10 @@
-import os
 import pickle
-from typing import List
 
-import pytest
 from pylint.checkers.typecheck import TypeChecker
-from pylint.lint import PyLinter
-from pylint.testutils import FunctionalTestFile
 
 from pylint_plugin_utils import augment_visit, suppress_message
 
 
-def get_tests(input_dir: str) -> List[FunctionalTestFile]:
-    cwd = os.path.dirname(os.path.abspath(__file__))
-    input_dir = os.path.join(cwd, input_dir)
-
-    suite = []
-    for file_name in os.listdir(input_dir):
-        if file_name != "__init__.py" and file_name.endswith(".py"):
-            suite.append(FunctionalTestFile(input_dir, file_name))
-
-    return suite
-
-
-TESTS = get_tests(input_dir="input")
-TESTS_NAMES = [t.base for t in TESTS]
-
-
 def fake_augmentation_func(*args, **kwargs):
     ...
 
@@ -34,17 +13,13 @@ def fake_suppress_func(*args, **kwargs):
     ...
 
 
-@pytest.mark.parametrize("test_file", TESTS, ids=TESTS_NAMES)
-def test_linter_pickleable_for_multithreading_as_default_for_py38_or_above(
-    test_file,
-):
+def test_linter_should_be_pickleable(linter):
     # Setup
-    pylinter = PyLinter()
-    pylinter.register_checker(TypeChecker())
-    augment_visit(pylinter, TypeChecker.visit_attribute, fake_augmentation_func)
+    linter.register_checker(TypeChecker())
+    augment_visit(linter, TypeChecker.visit_attribute, fake_augmentation_func)
     suppress_message(
-        pylinter, TypeChecker.visit_attribute, "no-member", fake_suppress_func
+        linter, TypeChecker.visit_attribute, "no-member", fake_suppress_func
     )
 
     # Act and Assert
-    pickle.dumps(pylinter)
+    pickle.dumps(linter)