small refactor to keep code smaller

Author: Janther

src/slang-nodes/MemberAccessExpression.ts

@@ -18,8 +18,8 @@ function isEndOfChain(
   node: ChainableExpression,
   path: AstPath<Expression['variant']>
 ): boolean {
-  for (let i = 1, current = node; ; i++) {
-    const parent = path.getNode(i)!;
+  for (let i = 1, current = node, parent; ; i++, current = parent) {
+    parent = path.getNode(i)!;
     if (!isChainableExpression(parent)) break;
 
     switch (parent.kind) {
@@ -40,7 +40,6 @@ function isEndOfChain(
         if (current !== parent.operand) return true;
         break;
     }
-    current = parent;
   }
   return true;
 }

src/slang-printers/print-binary-operation.ts

@@ -44,13 +44,12 @@ export const binaryIndentRulesBuilder =
   (shouldIndent: (node: BinaryOperation) => boolean) =>
   (node: BinaryOperation, path: AstPath<StrictAstNode>) =>
   (document: Doc): Doc => {
-    for (let i = 1, current = node; ; i++) {
-      const parent = path.getNode(i)!;
+    for (let i = 1, current = node, parent; ; i++, current = parent) {
+      parent = path.getNode(i)!;
       if (shouldNotIndent(parent, path, i)) break;
       if (!isBinaryOperation(parent)) return indent(document);
       if (shouldIndent(parent)) return indent(document);
       if (current === parent.rightOperand) break;
-      current = parent;
     }
     return document;
   };

src/slang-printers/print-logical-operation.ts

@@ -17,8 +17,8 @@ const logicalGroupRulesBuilder = binaryGroupRulesBuilder(() => false);
 const logicalIndentRulesBuilder =
   (node: BinaryOperation, path: AstPath<StrictAstNode>) =>
   (document: Doc): Doc => {
-    for (let i = 1, current = node; ; i++) {
-      const parent = path.getNode(i)!;
+    for (let i = 1, current = node, parent; ; i++, current = parent) {
+      parent = path.getNode(i)!;
       if (shouldNotIndent(parent, path, i)) break;
       if (
         parent.kind === NonterminalKind.ConditionalExpression &&
@@ -27,7 +27,6 @@ const logicalIndentRulesBuilder =
         break;
       if (!isBinaryOperation(parent)) return indent(document);
       if (current === parent.rightOperand) break;
-      current = parent;
     }
     return document;
   };