if updateMetadata modifies directly comments and loc, there's no need to destructure twice

Author: Janther

src/slang-nodes/AdditiveExpression.ts

@@ -39,13 +39,13 @@ export class AdditiveExpression implements SlangNode {
   rightOperand: Expression;
 
   constructor(ast: ast.AdditiveExpression, options: ParserOptions<AstNode>) {
-    const metadata = getNodeMetadata(ast);
+    [this.loc, this.comments] = getNodeMetadata(ast);
 
     this.leftOperand = new Expression(ast.leftOperand, options);
     this.operator = ast.operator.unparse();
     this.rightOperand = new Expression(ast.rightOperand, options);
 
-    [this.loc, this.comments] = updateMetadata(metadata, [
+    updateMetadata(this.loc, this.comments, [
       this.leftOperand,
       this.rightOperand
     ]);

src/slang-nodes/AndExpression.ts

@@ -22,13 +22,13 @@ export class AndExpression implements SlangNode {
   rightOperand: Expression;
 
   constructor(ast: ast.AndExpression, options: ParserOptions<AstNode>) {
-    const metadata = getNodeMetadata(ast);
+    [this.loc, this.comments] = getNodeMetadata(ast);
 
     this.leftOperand = new Expression(ast.leftOperand, options);
     this.operator = ast.operator.unparse();
     this.rightOperand = new Expression(ast.rightOperand, options);
 
-    [this.loc, this.comments] = updateMetadata(metadata, [
+    updateMetadata(this.loc, this.comments, [
       this.leftOperand,
       this.rightOperand
     ]);

src/slang-nodes/ArgumentsDeclaration.ts

@@ -18,7 +18,7 @@ export class ArgumentsDeclaration implements SlangNode {
   variant: PositionalArgumentsDeclaration | NamedArgumentsDeclaration;
 
   constructor(ast: ast.ArgumentsDeclaration, options: ParserOptions<AstNode>) {
-    const metadata = getNodeMetadata(ast);
+    [this.loc, this.comments] = getNodeMetadata(ast);
 
     switch (ast.variant.cst.kind) {
       case NonterminalKind.PositionalArgumentsDeclaration:
@@ -37,7 +37,7 @@ export class ArgumentsDeclaration implements SlangNode {
         throw new Error(`Unexpected variant: ${ast.variant.cst.kind}`);
     }
 
-    [this.loc, this.comments] = updateMetadata(metadata, [this.variant]);
+    updateMetadata(this.loc, this.comments, [this.variant]);
   }
 
   print(path: AstPath<ArgumentsDeclaration>, print: PrintFunction): Doc {

src/slang-nodes/ArrayExpression.ts

@@ -20,11 +20,11 @@ export class ArrayExpression implements SlangNode {
   items: ArrayValues;
 
   constructor(ast: ast.ArrayExpression, options: ParserOptions<AstNode>) {
-    const metadata = getNodeMetadata(ast);
+    [this.loc, this.comments] = getNodeMetadata(ast);
 
     this.items = new ArrayValues(ast.items, options);
 
-    [this.loc, this.comments] = updateMetadata(metadata, [this.items]);
+    updateMetadata(this.loc, this.comments, [this.items]);
   }
 
   print(path: AstPath<ArrayExpression>, print: PrintFunction): Doc {

src/slang-nodes/ArrayTypeName.ts

@@ -20,17 +20,14 @@ export class ArrayTypeName implements SlangNode {
   index?: Expression;
 
   constructor(ast: ast.ArrayTypeName, options: ParserOptions<AstNode>) {
-    const metadata = getNodeMetadata(ast);
+    [this.loc, this.comments] = getNodeMetadata(ast);
 
     this.operand = new TypeName(ast.operand, options);
     if (ast.index) {
       this.index = new Expression(ast.index, options);
     }
 
-    [this.loc, this.comments] = updateMetadata(metadata, [
-      this.operand,
-      this.index
-    ]);
+    updateMetadata(this.loc, this.comments, [this.operand, this.index]);
   }
 
   print(path: AstPath<ArrayTypeName>, print: PrintFunction): Doc {

src/slang-nodes/ArrayValues.ts

@@ -18,11 +18,11 @@ export class ArrayValues implements SlangNode {
   items: Expression[];
 
   constructor(ast: ast.ArrayValues, options: ParserOptions<AstNode>) {
-    const metadata = getNodeMetadata(ast, true);
+    [this.loc, this.comments] = getNodeMetadata(ast, true);
 
     this.items = ast.items.map((item) => new Expression(item, options));
 
-    [this.loc, this.comments] = updateMetadata(metadata, [this.items]);
+    updateMetadata(this.loc, this.comments, [this.items]);
   }
 
   print(path: AstPath<ArrayValues>, print: PrintFunction): Doc {

src/slang-nodes/AssemblyFlags.ts

@@ -18,11 +18,11 @@ export class AssemblyFlags implements SlangNode {
   items: StringLiteral[];
 
   constructor(ast: ast.AssemblyFlags, options: ParserOptions<AstNode>) {
-    const metadata = getNodeMetadata(ast, true);
+    [this.loc, this.comments] = getNodeMetadata(ast, true);
 
     this.items = ast.items.map((item) => new StringLiteral(item, options));
 
-    [this.loc, this.comments] = updateMetadata(metadata, [this.items]);
+    updateMetadata(this.loc, this.comments, [this.items]);
   }
 
   print(path: AstPath<AssemblyFlags>, print: PrintFunction): Doc {

src/slang-nodes/AssemblyFlagsDeclaration.ts

@@ -20,11 +20,11 @@ export class AssemblyFlagsDeclaration implements SlangNode {
     ast: ast.AssemblyFlagsDeclaration,
     options: ParserOptions<AstNode>
   ) {
-    const metadata = getNodeMetadata(ast);
+    [this.loc, this.comments] = getNodeMetadata(ast);
 
     this.flags = new AssemblyFlags(ast.flags, options);
 
-    [this.loc, this.comments] = updateMetadata(metadata, [this.flags]);
+    updateMetadata(this.loc, this.comments, [this.flags]);
   }
 
   print(path: AstPath<AssemblyFlagsDeclaration>, print: PrintFunction): Doc {

src/slang-nodes/AssemblyStatement.ts

@@ -24,7 +24,7 @@ export class AssemblyStatement implements SlangNode {
   body: YulBlock;
 
   constructor(ast: ast.AssemblyStatement, options: ParserOptions<AstNode>) {
-    const metadata = getNodeMetadata(ast);
+    [this.loc, this.comments] = getNodeMetadata(ast);
 
     if (ast.label) {
       this.label = new StringLiteral(ast.label, options);
@@ -34,7 +34,7 @@ export class AssemblyStatement implements SlangNode {
     }
     this.body = new YulBlock(ast.body, options);
 
-    [this.loc, this.comments] = updateMetadata(metadata, [
+    updateMetadata(this.loc, this.comments, [
       this.label,
       this.flags,
       this.body

src/slang-nodes/AssignmentExpression.ts

@@ -25,13 +25,13 @@ export class AssignmentExpression implements SlangNode {
   rightOperand: Expression;
 
   constructor(ast: ast.AssignmentExpression, options: ParserOptions<AstNode>) {
-    const metadata = getNodeMetadata(ast);
+    [this.loc, this.comments] = getNodeMetadata(ast);
 
     this.leftOperand = new Expression(ast.leftOperand, options);
     this.operator = ast.operator.unparse();
     this.rightOperand = new Expression(ast.rightOperand, options);
 
-    [this.loc, this.comments] = updateMetadata(metadata, [
+    updateMetadata(this.loc, this.comments, [
       this.leftOperand,
       this.rightOperand
     ]);