avoid using the temporary variable metadata since it can be destructured directly

Author: Janther

src/slang-nodes/AbicoderPragma.ts

@@ -16,11 +16,9 @@ export class AbicoderPragma implements SlangNode {
   version: Identifier;
 
   constructor(ast: ast.AbicoderPragma) {
-    const metadata = getNodeMetadata(ast);
+    [this.loc, this.comments] = getNodeMetadata(ast);
 
     this.version = new Identifier(ast.version);
-
-    [this.loc, this.comments] = metadata;
   }
 
   print(path: AstPath<AbicoderPragma>, print: PrintFunction): Doc {

src/slang-nodes/AdditiveExpression.ts

@@ -39,15 +39,16 @@ export class AdditiveExpression implements SlangNode {
   rightOperand: Expression;
 
   constructor(ast: ast.AdditiveExpression, options: ParserOptions<AstNode>) {
-    let metadata = getNodeMetadata(ast);
+    const metadata = getNodeMetadata(ast);
 
     this.leftOperand = new Expression(ast.leftOperand, options);
     this.operator = ast.operator.unparse();
     this.rightOperand = new Expression(ast.rightOperand, options);
 
-    metadata = updateMetadata(metadata, [this.leftOperand, this.rightOperand]);
-
-    [this.loc, this.comments] = metadata;
+    [this.loc, this.comments] = updateMetadata(metadata, [
+      this.leftOperand,
+      this.rightOperand
+    ]);
 
     this.leftOperand = tryToHug(this.leftOperand);
     this.rightOperand = tryToHug(this.rightOperand);

src/slang-nodes/AddressType.ts

@@ -16,11 +16,9 @@ export class AddressType implements SlangNode {
   payableKeyword?: string;
 
   constructor(ast: ast.AddressType) {
-    const metadata = getNodeMetadata(ast);
+    [this.loc, this.comments] = getNodeMetadata(ast);
 
     this.payableKeyword = ast.payableKeyword?.unparse();
-
-    [this.loc, this.comments] = metadata;
   }
 
   print(): Doc {

src/slang-nodes/AndExpression.ts

@@ -22,15 +22,16 @@ export class AndExpression implements SlangNode {
   rightOperand: Expression;
 
   constructor(ast: ast.AndExpression, options: ParserOptions<AstNode>) {
-    let metadata = getNodeMetadata(ast);
+    const metadata = getNodeMetadata(ast);
 
     this.leftOperand = new Expression(ast.leftOperand, options);
     this.operator = ast.operator.unparse();
     this.rightOperand = new Expression(ast.rightOperand, options);
 
-    metadata = updateMetadata(metadata, [this.leftOperand, this.rightOperand]);
-
-    [this.loc, this.comments] = metadata;
+    [this.loc, this.comments] = updateMetadata(metadata, [
+      this.leftOperand,
+      this.rightOperand
+    ]);
   }
 
   print(

src/slang-nodes/ArgumentsDeclaration.ts

@@ -18,7 +18,7 @@ export class ArgumentsDeclaration implements SlangNode {
   variant: PositionalArgumentsDeclaration | NamedArgumentsDeclaration;
 
   constructor(ast: ast.ArgumentsDeclaration, options: ParserOptions<AstNode>) {
-    let metadata = getNodeMetadata(ast);
+    const metadata = getNodeMetadata(ast);
 
     switch (ast.variant.cst.kind) {
       case NonterminalKind.PositionalArgumentsDeclaration:
@@ -37,9 +37,7 @@ export class ArgumentsDeclaration implements SlangNode {
         throw new Error(`Unexpected variant: ${ast.variant.cst.kind}`);
     }
 
-    metadata = updateMetadata(metadata, [this.variant]);
-
-    [this.loc, this.comments] = metadata;
+    [this.loc, this.comments] = updateMetadata(metadata, [this.variant]);
   }
 
   print(path: AstPath<ArgumentsDeclaration>, print: PrintFunction): Doc {

src/slang-nodes/ArrayExpression.ts

@@ -20,13 +20,11 @@ export class ArrayExpression implements SlangNode {
   items: ArrayValues;
 
   constructor(ast: ast.ArrayExpression, options: ParserOptions<AstNode>) {
-    let metadata = getNodeMetadata(ast);
+    const metadata = getNodeMetadata(ast);
 
     this.items = new ArrayValues(ast.items, options);
 
-    metadata = updateMetadata(metadata, [this.items]);
-
-    [this.loc, this.comments] = metadata;
+    [this.loc, this.comments] = updateMetadata(metadata, [this.items]);
   }
 
   print(path: AstPath<ArrayExpression>, print: PrintFunction): Doc {

src/slang-nodes/ArrayTypeName.ts

@@ -20,16 +20,17 @@ export class ArrayTypeName implements SlangNode {
   index?: Expression;
 
   constructor(ast: ast.ArrayTypeName, options: ParserOptions<AstNode>) {
-    let metadata = getNodeMetadata(ast);
+    const metadata = getNodeMetadata(ast);
 
     this.operand = new TypeName(ast.operand, options);
     if (ast.index) {
       this.index = new Expression(ast.index, options);
     }
 
-    metadata = updateMetadata(metadata, [this.operand, this.index]);
-
-    [this.loc, this.comments] = metadata;
+    [this.loc, this.comments] = updateMetadata(metadata, [
+      this.operand,
+      this.index
+    ]);
   }
 
   print(path: AstPath<ArrayTypeName>, print: PrintFunction): Doc {

src/slang-nodes/ArrayValues.ts

@@ -20,14 +20,12 @@ export class ArrayValues implements SlangNode {
   separators: string[];
 
   constructor(ast: ast.ArrayValues, options: ParserOptions<AstNode>) {
-    let metadata = getNodeMetadata(ast, true);
+    const metadata = getNodeMetadata(ast, true);
 
     this.items = ast.items.map((item) => new Expression(item, options));
     this.separators = ast.separators.map((separator) => separator.unparse());
 
-    metadata = updateMetadata(metadata, [this.items]);
-
-    [this.loc, this.comments] = metadata;
+    [this.loc, this.comments] = updateMetadata(metadata, [this.items]);
   }
 
   print(path: AstPath<ArrayValues>, print: PrintFunction): Doc {

src/slang-nodes/AssemblyFlags.ts

@@ -20,14 +20,12 @@ export class AssemblyFlags implements SlangNode {
   separators: string[];
 
   constructor(ast: ast.AssemblyFlags, options: ParserOptions<AstNode>) {
-    let metadata = getNodeMetadata(ast, true);
+    const metadata = getNodeMetadata(ast, true);
 
     this.items = ast.items.map((item) => new StringLiteral(item, options));
     this.separators = ast.separators.map((separator) => separator.unparse());
 
-    metadata = updateMetadata(metadata, [this.items]);
-
-    [this.loc, this.comments] = metadata;
+    [this.loc, this.comments] = updateMetadata(metadata, [this.items]);
   }
 
   print(path: AstPath<AssemblyFlags>, print: PrintFunction): Doc {

src/slang-nodes/AssemblyFlagsDeclaration.ts

@@ -20,13 +20,11 @@ export class AssemblyFlagsDeclaration implements SlangNode {
     ast: ast.AssemblyFlagsDeclaration,
     options: ParserOptions<AstNode>
   ) {
-    let metadata = getNodeMetadata(ast);
+    const metadata = getNodeMetadata(ast);
 
     this.flags = new AssemblyFlags(ast.flags, options);
 
-    metadata = updateMetadata(metadata, [this.flags]);
-
-    [this.loc, this.comments] = metadata;
+    [this.loc, this.comments] = updateMetadata(metadata, [this.flags]);
   }
 
   print(path: AstPath<AssemblyFlagsDeclaration>, print: PrintFunction): Doc {