Removing unneeded helper function isLineComment

Author: Janther

src/slang-nodes/IfStatement.ts

@@ -2,7 +2,7 @@ import { doc } from 'prettier';
 import { NonterminalKind } from '@nomicfoundation/slang/kinds/index.js';
 import { printSeparatedItem } from '../slang-printers/print-separated-item.js';
 import { getNodeMetadata, updateMetadata } from '../slang-utils/metadata.js';
-import { isLineComment } from '../slang-utils/is-comment.js';
+import { isBlockComment } from '../slang-utils/is-comment.js';
 import { Expression } from './Expression.js';
 import { Statement } from './Statement.js';
 import { ElseBranch } from './ElseBranch.js';
@@ -66,7 +66,7 @@ export class IfStatement implements SlangNode {
             this.body.variant.kind !== NonterminalKind.Block || // else on a new line if body is not a block
             this.body.variant.comments.some(
               (comment) =>
-                isLineComment(comment) || comment.placement === 'ownLine'
+                !isBlockComment(comment) || comment.placement === 'ownLine'
             ) // or if body has trailing single line comments or a block comment on a new line
               ? hardline
               : ' ',

src/slang-nodes/MemberAccessExpression.ts

@@ -21,16 +21,16 @@ const isChainableExpression = createKindCheckFunction([
 
 function isEndOfChain(
   node: MemberAccessExpression,
-  path: AstPath<AstNode>
+  path: AstPath<StrictAstNode>
 ): boolean {
   for (
     let i = 0,
-      currentNode: AstNode = node,
-      grandparentNode = path.getNode(i + 2) as StrictAstNode;
+      currentNode: StrictAstNode = node,
+      grandparentNode = path.getNode(i + 2)!;
     isChainableExpression(grandparentNode);
     i += 2,
       currentNode = grandparentNode,
-      grandparentNode = path.getNode(i + 2) as StrictAstNode
+      grandparentNode = path.getNode(i + 2)!
   ) {
     switch (grandparentNode.kind) {
       case NonterminalKind.MemberAccessExpression:

src/slang-printers/print-binary-operation.ts

@@ -4,7 +4,7 @@ import { createBinaryOperationPrinter } from './create-binary-operation-printer.
 import { createKindCheckFunction } from '../slang-utils/create-kind-check-function.js';
 
 import type { AstPath, Doc } from 'prettier';
-import type { AstNode, BinaryOperation, StrictAstNode } from '../slang-nodes';
+import type { BinaryOperation, StrictAstNode } from '../slang-nodes';
 import type { ComparisonExpression } from '../slang-nodes/ComparisonExpression';
 import type { EqualityExpression } from '../slang-nodes/EqualityExpression';
 
@@ -41,7 +41,7 @@ const binaryGroupRulesBuilder =
 const binaryIndentRulesBuilder =
   (path: AstPath<BinaryOperation>) =>
   (document: Doc): Doc => {
-    let node = path.getNode() as AstNode;
+    let node = path.getNode() as StrictAstNode;
     for (let i = 2; ; i += 2) {
       const grandparentNode = path.getNode(i) as StrictAstNode;
       if (grandparentNode.kind === NonterminalKind.ReturnStatement) break;

src/slang-printers/print-comments.ts

@@ -1,7 +1,7 @@
 import { doc } from 'prettier';
 import { printComment } from '../slang-comments/printer.js';
 import { isPrettier2 } from '../slang-utils/backward-compatibility.js';
-import { isLineComment } from '../slang-utils/is-comment.js';
+import { isBlockComment } from '../slang-utils/is-comment.js';
 import { joinExisting } from '../slang-utils/join-existing.js';
 
 import type { AstPath, Doc } from 'prettier';
@@ -20,7 +20,7 @@ export function printComments(path: AstPath<AstNode>): Doc[] {
       }
       comment.printed = true;
       const printed = printComment(commentPath);
-      return isLineComment(comment) ? [printed, breakParent] : printed;
+      return isBlockComment(comment) ? printed : [printed, breakParent];
     }, 'comments')
   );
 

src/slang-utils/is-comment.ts

@@ -2,23 +2,13 @@ import { TerminalKind } from '@nomicfoundation/slang/kinds/index.js';
 import { createKindCheckFunction } from './create-kind-check-function.js';
 
 import type { Node } from '@nomicfoundation/slang/cst';
-import type {
-  AstNode,
-  BlockComment,
-  Comment,
-  LineComment
-} from '../slang-nodes';
+import type { AstNode, BlockComment, Comment } from '../slang-nodes';
 
 export const isBlockComment = createKindCheckFunction([
   TerminalKind.MultiLineComment,
   TerminalKind.MultiLineNatSpecComment
 ]) as (node: AstNode) => node is BlockComment;
 
-export const isLineComment = createKindCheckFunction([
-  TerminalKind.SingleLineComment,
-  TerminalKind.SingleLineNatSpecComment
-]) as (node: AstNode) => node is LineComment;
-
 export const isComment = createKindCheckFunction([
   TerminalKind.MultiLineComment,
   TerminalKind.MultiLineNatSpecComment,