Skip to content

Commit e257a24

Browse files
authored
sort modifies the original array so there is no need to reassign it (#1263)
1 parent b9d9a04 commit e257a24

9 files changed

Lines changed: 9 additions & 9 deletions

src/slang-nodes/ConstructorAttributes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export class ConstructorAttributes extends SlangNode {
2323
(item) => new ConstructorAttribute(item, options)
2424
);
2525

26-
this.items = this.items.sort(sortFunctionAttributes);
26+
this.items.sort(sortFunctionAttributes);
2727
}
2828

2929
print(path: AstPath<ConstructorAttributes>, print: PrintFunction): Doc {

src/slang-nodes/ContractSpecifiers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export class ContractSpecifiers extends SlangNode {
2222

2323
this.items = ast.items.map((item) => new ContractSpecifier(item, options));
2424

25-
this.items = this.items.sort(sortContractSpecifiers);
25+
this.items.sort(sortContractSpecifiers);
2626
}
2727

2828
print(path: AstPath<ContractSpecifiers>, print: PrintFunction): Doc {

src/slang-nodes/FallbackFunctionAttributes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export class FallbackFunctionAttributes extends SlangNode {
2626
(item) => new FallbackFunctionAttribute(item, options)
2727
);
2828

29-
this.items = this.items.sort(sortFunctionAttributes);
29+
this.items.sort(sortFunctionAttributes);
3030
}
3131

3232
print(path: AstPath<FallbackFunctionAttributes>, print: PrintFunction): Doc {

src/slang-nodes/FunctionAttributes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export class FunctionAttributes extends SlangNode {
2121

2222
this.items = ast.items.map((item) => new FunctionAttribute(item, options));
2323

24-
this.items = this.items.sort(sortFunctionAttributes);
24+
this.items.sort(sortFunctionAttributes);
2525
}
2626

2727
print(path: AstPath<FunctionAttributes>, print: PrintFunction): Doc {

src/slang-nodes/FunctionTypeAttributes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export class FunctionTypeAttributes extends SlangNode {
2020

2121
this.items = ast.items.map((item) => new FunctionTypeAttribute(item));
2222

23-
this.items = this.items.sort(sortFunctionAttributes);
23+
this.items.sort(sortFunctionAttributes);
2424
}
2525

2626
print(path: AstPath<FunctionTypeAttributes>, print: PrintFunction): Doc {

src/slang-nodes/ModifierAttributes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export class ModifierAttributes extends SlangNode {
2020

2121
this.items = ast.items.map((item) => new ModifierAttribute(item));
2222

23-
this.items = this.items.sort(sortFunctionAttributes);
23+
this.items.sort(sortFunctionAttributes);
2424
}
2525

2626
print(path: AstPath<ModifierAttributes>, print: PrintFunction): Doc {

src/slang-nodes/ReceiveFunctionAttributes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export class ReceiveFunctionAttributes extends SlangNode {
2626
(item) => new ReceiveFunctionAttribute(item, options)
2727
);
2828

29-
this.items = this.items.sort(sortFunctionAttributes);
29+
this.items.sort(sortFunctionAttributes);
3030
}
3131

3232
print(path: AstPath<ReceiveFunctionAttributes>, print: PrintFunction): Doc {

src/slang-nodes/StateVariableAttributes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export class StateVariableAttributes extends SlangNode {
2020

2121
this.items = ast.items.map((item) => new StateVariableAttribute(item));
2222

23-
this.items = this.items.sort(sortFunctionAttributes);
23+
this.items.sort(sortFunctionAttributes);
2424
}
2525

2626
print(path: AstPath<StateVariableAttributes>, print: PrintFunction): Doc {

src/slang-nodes/UnnamedFunctionAttributes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export class UnnamedFunctionAttributes extends SlangNode {
2626
(item) => new UnnamedFunctionAttribute(item, options)
2727
);
2828

29-
this.items = this.items.sort(sortFunctionAttributes);
29+
this.items.sort(sortFunctionAttributes);
3030
}
3131

3232
print(path: AstPath<UnnamedFunctionAttributes>, print: PrintFunction): Doc {

0 commit comments

Comments
 (0)