a more specific type for nodes that will be used in printPreservingEmptyLines (#1205)

* a more specific type for nodes that will be used in printPreservingEmptyLines function

* only StrictAstNode, Identifier, or YulIdentifier can have comments attached

Author: Janther

src/slang-comments/handlers/add-collection-first-comment.ts

@@ -1,11 +1,11 @@
 import { util } from 'prettier';
 
-import type { Comment, Collection } from '../../slang-nodes/types.d.ts';
+import type { Comment, NodeCollection } from '../../slang-nodes/types.d.ts';
 
 const { addDanglingComment, addLeadingComment } = util;
 
 export default function addCollectionFirstComment(
-  node: Collection,
+  node: NodeCollection,
   comment: Comment
 ): void {
   if (node.items.length === 0) {

src/slang-comments/handlers/add-collection-last-comment.ts

@@ -1,11 +1,11 @@
 import { util } from 'prettier';
 
-import type { Comment, Collection } from '../../slang-nodes/types.d.ts';
+import type { Comment, NodeCollection } from '../../slang-nodes/types.d.ts';
 
 const { addDanglingComment, addTrailingComment } = util;
 
 export default function addCollectionLastComment(
-  node: Collection,
+  node: NodeCollection,
   comment: Comment
 ): void {
   if (node.items.length === 0) {

src/slang-nodes/MultiplicativeExpression.ts

@@ -14,7 +14,7 @@ const multiplicationTryToHug = createHugFunction(['/', '%']);
 const divisionTryToHug = createHugFunction(['*', '%']);
 const moduloTryToHug = createHugFunction(['*', '/', '%']);
 
-export const printMultiplicativeExpression = printBinaryOperation(
+const printMultiplicativeExpression = printBinaryOperation(
   createKindCheckFunction([
     NonterminalKind.AdditiveExpression,
     NonterminalKind.ShiftExpression,

src/slang-nodes/types.d.ts

@@ -460,14 +460,16 @@ export type StrictAstNode =
   | YulPaths
   | YulPath;
 
+export type Collection = Extract<StrictAstNode, { items: unknown[] }>;
+
 export type NodeCollection = Extract<
-  StrictAstNode,
+  Collection,
   { items: StrictAstNode[] | Identifier[] | YulIdentifier[] }
 >;
 
-export type Collection = Extract<
-  StrictAstNode,
-  { items: StrictAstNode[] | Identifier[] | YulIdentifier[] | string[] }
+export type LineCollection = Extract<
+  NodeCollection,
+  { items: Extract<StrictAstNode, { variant: StrictAstNode }>[] }
 >;
 
 export type BinaryOperation = Extract<

src/slang-printers/print-preserving-empty-lines.ts

@@ -3,13 +3,13 @@ import { doc, util } from 'prettier';
 import { locEnd } from '../slang-utils/loc.js';
 
 import type { AstPath, Doc, ParserOptions } from 'prettier';
-import type { AstNode, NodeCollection } from '../slang-nodes/types.d.ts';
+import type { AstNode, LineCollection } from '../slang-nodes/types.d.ts';
 import type { PrintFunction } from '../types.d.ts';
 
 const { hardline } = doc.builders;
 
 export function printPreservingEmptyLines(
-  path: AstPath<NodeCollection>,
+  path: AstPath<LineCollection>,
   print: PrintFunction,
   options: ParserOptions<AstNode>
 ): Doc {