computing lastPrintableIndex only once instead of checking in every loop

Author: Janther

src/slang-printers/print-comments.ts

@@ -22,20 +22,19 @@ export function printComments(
   options: ParserOptions<AstNode>
 ): Doc[] {
   if (node.comments === undefined) return [];
+  const lastPrintableIndex = node.comments.findLastIndex(isPrintable);
   return joinExisting(
     line,
-    path.map((commentPath, index, comments: Comment[]) => {
+    path.map((commentPath, index) => {
       const comment = commentPath.node;
       if (!isPrintable(comment)) {
         return '';
       }
       comment.printed = true;
-      const isLast =
-        index === comments.length - 1 ||
-        comments.slice(index + 1).findIndex(isPrintable) === -1;
       return [
         printComment(commentPath),
-        !isLast && util.isNextLineEmpty(options.originalText, locEnd(comment))
+        index !== lastPrintableIndex &&
+        util.isNextLineEmpty(options.originalText, locEnd(comment))
           ? hardline
           : ''
       ];

src/slangPrinter.ts

@@ -22,7 +22,7 @@ function hasNodeIgnoreComment({ comments }: StrictAstNode): boolean {
   );
 }
 
-function ignoreComments(path: AstPath<AstNode>): void {
+function ignoreComments(path: AstPath<StrictAstNode>): void {
   const node = path.node;
   // We ignore anything that is not an object
   if (node === null || typeof node !== 'object') return;
@@ -38,7 +38,9 @@ function ignoreComments(path: AstPath<AstNode>): void {
         break;
       // The key `comments` will contain every comment for this node.
       case 'comments':
-        path.each((commentPath) => (commentPath.node.printed = true), key);
+        if (node.comments !== undefined) {
+          path.each((commentPath) => (commentPath.node.printed = true), key);
+        }
         break;
       default:
         // If the value for that key is an Array or an Object we go deeper.

tsconfig.json

@@ -5,7 +5,7 @@
     "noImplicitAny": true,
     "strictPropertyInitialization": true,
     "sourceMap": true,
-    "target": "es6",
+    "target": "es2023",
     "module": "NodeNext",
     "moduleResolution": "NodeNext",
     "strict": true,