Singleton comments (#1230)

* storing comments in a singleton

* no need to initiate an empty `comments` array for every single node, prettier will create them if needed and only a few places need to check if it's defined

* `updateMetadata` now doesn't need to process collections

Author: Janther

src/slang-nodes/ArrayExpression.ts

@@ -16,8 +16,6 @@ export class ArrayExpression extends SlangNode {
     super(ast);
 
     this.items = new ArrayValues(ast.items, options);
-
-    this.updateMetadata(this.items);
   }
 
   print(path: AstPath<ArrayExpression>, print: PrintFunction): Doc {

src/slang-nodes/ArrayValues.ts

@@ -17,8 +17,6 @@ export class ArrayValues extends SlangNode {
     super(ast, true);
 
     this.items = ast.items.map((item) => new Expression(item, options));
-
-    this.updateMetadata(this.items);
   }
 
   print(path: AstPath<ArrayValues>, print: PrintFunction): Doc {

src/slang-nodes/AssemblyFlags.ts

@@ -17,8 +17,6 @@ export class AssemblyFlags extends SlangNode {
     super(ast, true);
 
     this.items = ast.items.map((item) => new StringLiteral(item, options));
-
-    this.updateMetadata(this.items);
   }
 
   print(path: AstPath<AssemblyFlags>, print: PrintFunction): Doc {

src/slang-nodes/CallOptions.ts

@@ -20,8 +20,6 @@ export class CallOptions extends SlangNode {
     super(ast, true);
 
     this.items = ast.items.map((item) => new NamedArgument(item, options));
-
-    this.updateMetadata(this.items);
   }
 
   print(

src/slang-nodes/CatchClauses.ts

@@ -19,8 +19,6 @@ export class CatchClauses extends SlangNode {
     super(ast, true);
 
     this.items = ast.items.map((item) => new CatchClause(item, options));
-
-    this.updateMetadata(this.items);
   }
 
   print(path: AstPath<CatchClauses>, print: PrintFunction): Doc {

src/slang-nodes/ConstructorAttributes.ts

@@ -23,8 +23,6 @@ export class ConstructorAttributes extends SlangNode {
       (item) => new ConstructorAttribute(item, options)
     );
 
-    this.updateMetadata(this.items);
-
     this.items = this.items.sort(sortFunctionAttributes);
   }
 

src/slang-nodes/ContractMembers.ts

@@ -21,16 +21,14 @@ export class ContractMembers extends SlangNode {
     super(ast, true);
 
     this.items = ast.items.map((item) => new ContractMember(item, options));
-
-    this.updateMetadata(this.items);
   }
 
   print(
     path: AstPath<ContractMembers>,
     print: PrintFunction,
     options: ParserOptions<AstNode>
   ): Doc {
-    return this.items.length > 0 || this.comments.length > 0
+    return this.items.length > 0 || (this.comments?.length || 0) > 0
       ? printSeparatedItem(printPreservingEmptyLines(path, print, options), {
           firstSeparator: hardline
         })

src/slang-nodes/ContractSpecifiers.ts

@@ -22,8 +22,6 @@ export class ContractSpecifiers extends SlangNode {
 
     this.items = ast.items.map((item) => new ContractSpecifier(item, options));
 
-    this.updateMetadata(this.items);
-
     this.items = this.items.sort(sortContractSpecifiers);
   }
 

src/slang-nodes/ErrorParameters.ts

@@ -17,8 +17,6 @@ export class ErrorParameters extends SlangNode {
     super(ast, true);
 
     this.items = ast.items.map((item) => new ErrorParameter(item, options));
-
-    this.updateMetadata(this.items);
   }
 
   print(path: AstPath<ErrorParameters>, print: PrintFunction): Doc {

src/slang-nodes/EventParameters.ts

@@ -17,8 +17,6 @@ export class EventParameters extends SlangNode {
     super(ast, true);
 
     this.items = ast.items.map((item) => new EventParameter(item, options));
-
-    this.updateMetadata(this.items);
   }
 
   print(path: AstPath<EventParameters>, print: PrintFunction): Doc {