Don't coerce marker.line.dash for some traces

Author: camdecoster

src/traces/scatter/marker_defaults.js

@@ -12,13 +12,11 @@ var subTypes = require('./subtypes');
  *   gradient: caller supports gradients
  *   noSelect: caller does not support selected/unselected attribute containers
  */
-module.exports = function markerDefaults(traceIn, traceOut, defaultColor, layout, coerce, opts) {
+module.exports = function markerDefaults(traceIn, traceOut, defaultColor, layout, coerce, opts = {}) {
     var isBubble = subTypes.isBubble(traceIn);
     var lineColor = (traceIn.line || {}).color;
     var defaultMLC;
 
-    opts = opts || {};
-
     // marker.color inherit from line.color (even if line.color is an array)
     if (lineColor) defaultColor = lineColor;
 
@@ -27,13 +25,8 @@ module.exports = function markerDefaults(traceIn, traceOut, defaultColor, layout
     coerce('marker.size');
     if (!opts.noAngle) {
         coerce('marker.angle');
-        if (!opts.noAngleRef) {
-            coerce('marker.angleref');
-        }
-
-        if (!opts.noStandOff) {
-            coerce('marker.standoff');
-        }
+        if (!opts.noAngleRef) coerce('marker.angleref');
+        if (!opts.noStandOff) coerce('marker.standoff');
     }
 
     coerce('marker.color', defaultColor);
@@ -55,16 +48,19 @@ module.exports = function markerDefaults(traceIn, traceOut, defaultColor, layout
         // mostly this is for transparent markers to behave nicely
         if (lineColor && !Array.isArray(lineColor) && traceOut.marker.color !== lineColor) {
             defaultMLC = lineColor;
-        } else if (isBubble) defaultMLC = Color.background;
-        else defaultMLC = Color.defaultLine;
+        } else if (isBubble) {
+            defaultMLC = Color.background;
+        } else {
+            defaultMLC = Color.defaultLine;
+        }
 
         coerce('marker.line.color', defaultMLC);
         if (hasColorscale(traceIn, 'marker.line')) {
             colorscaleDefaults(traceIn, traceOut, layout, coerce, { prefix: 'marker.line.', cLetter: 'c' });
         }
 
         coerce('marker.line.width', isBubble ? 1 : 0);
-        coerce('marker.line.dash');
+        if (!opts.noLineDash) coerce('marker.line.dash');
     }
 
     if (isBubble) {
@@ -75,8 +71,6 @@ module.exports = function markerDefaults(traceIn, traceOut, defaultColor, layout
 
     if (opts.gradient) {
         var gradientType = coerce('marker.gradient.type');
-        if (gradientType !== 'none') {
-            coerce('marker.gradient.color');
-        }
+        if (gradientType !== 'none') coerce('marker.gradient.color');
     }
 };

src/traces/scatter3d/defaults.js

@@ -32,7 +32,11 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     coerce('mode');
 
     if (subTypes.hasMarkers(traceOut)) {
-        handleMarkerDefaults(traceIn, traceOut, defaultColor, layout, coerce, { noSelect: true, noAngle: true });
+        handleMarkerDefaults(traceIn, traceOut, defaultColor, layout, coerce, {
+            noAngle: true,
+            noLineDash: true,
+            noSelect: true
+        });
     }
 
     if (subTypes.hasLines(traceOut)) {

src/traces/scattergl/defaults.js

@@ -41,7 +41,11 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     coerce('mode', defaultMode);
 
     if (subTypes.hasMarkers(traceOut)) {
-        handleMarkerDefaults(traceIn, traceOut, defaultColor, layout, coerce, { noAngleRef: true, noStandOff: true });
+        handleMarkerDefaults(traceIn, traceOut, defaultColor, layout, coerce, {
+            noAngleRef: true,
+            noLineDash: true,
+            noStandOff: true
+        });
         coerce('marker.line.width', isOpen || isBubble ? 1 : 0);
     }
 

src/traces/scatterpolargl/defaults.js

@@ -33,7 +33,11 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     }
 
     if (subTypes.hasMarkers(traceOut)) {
-        handleMarkerDefaults(traceIn, traceOut, defaultColor, layout, coerce, { noAngleRef: true, noStandOff: true });
+        handleMarkerDefaults(traceIn, traceOut, defaultColor, layout, coerce, {
+            noAngleRef: true,
+            noLineDash: true,
+            noStandOff: true
+        });
     }
 
     if (subTypes.hasLines(traceOut)) {

src/traces/splom/defaults.js

@@ -37,7 +37,11 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     coerce('xhoverformat');
     coerce('yhoverformat');
 
-    handleMarkerDefaults(traceIn, traceOut, defaultColor, layout, coerce, { noAngleRef: true, noStandOff: true });
+    handleMarkerDefaults(traceIn, traceOut, defaultColor, layout, coerce, {
+        noAngleRef: true,
+        noLineDash: true,
+        noStandOff: true
+    });
 
     var isOpen = isOpenSymbol(traceOut.marker.symbol);
     var isBubble = subTypes.isBubble(traceOut);