updated README.md, fix #48, fix #49

pichillilorenzo · pichillilorenzo · commit 6ce841196915 · 2018-02-11T20:29:22.000+01:00
diff --git a/Default (Windows).sublime-keymap b/Default (Windows).sublime-keymap
@@ -1,28 +1,28 @@
 [
   {
-    "keys": ["ctrl+super+c"],
+    "keys": ["super+alt+c"],
     "command": "find_description"
   },
   {
-    "keys": ["ctrl+super+s"],
+    "keys": ["super+alt+s"],
     "command": "evaluate_javascript",
     "args": {"eval_type": "eval"}
   },
   {
-    "keys": ["ctrl+super+z"],
+    "keys": ["super+alt+z"],
     "command": "evaluate_javascript",
     "args": {"is_line": "True", "eval_type": "eval"}
   },
   {
-    "keys": ["ctrl+super+h"],
+    "keys": ["super+alt+h"],
     "command": "hide_code_highlights_eval"
   },
   {
-    "keys": ["ctrl+super+j"],
+    "keys": ["super+alt+j"],
     "command": "show_code_highlights_eval"
   },
   {
-    "keys": ["ctrl+alt+w"],
+    "keys": ["super+alt+w"],
     "command": "can_i_use"
   }
 ]
diff --git a/README.md b/README.md
@@ -7,18 +7,20 @@ I developed a new plugin with new features thanks to <strong><a href="https://gi
 
 You can find it on: 👉👉 <a href="https://github.com/pichillilorenzo/JavaScriptEnhancements">https://github.com/pichillilorenzo/JavaScriptEnhancements</a> 👈👈
 
-This new plugin offers not only a <strong>better autocomplete</strong> but a lot of <strong>features</strong> about creating, 
-developing and managing <strong>javascript projects</strong>, such as:
+This new plugin offers not only a <strong>BETTER AUTOCOMPLETE</strong> but a lot of <strong>features</strong> about creating, 
+developing and managing <a href="https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Creating-a-JavaScript-Project"><strong>JavaScript projects</strong></a>, such as:
 
+- <a href="https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Errors-and-linting">JavaScript real-time errors</a>
+- <a href="https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Code-Refactoring">Code Refactoring</a>
+- <a href="https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Features#bookmarks-project">Local bookmarks project</a>
 - Cordova projects (run cordova emulate, build, compile, serve, etc. directly from Sublime Text!)
-- Ionic v1 and v2 projects (same as Cordova projects!)
-- Angular v1 and v2 projects
-- React projects
-- Express projects
+- Ionic v1 and v2 (it includes also v3) projects (same as Cordova projects!)
+- Angular v1 and v2 (it includes also v4 and v5) projects
+- React projects (only about the creation at this moment)
+- React Native projects (only about the creation at this moment. I will add also **NativeScript** support)
+- Express projects (only about the creation at this moment)
 - Yeoman generators
-- Local bookmarks project
-- JavaScript real-time errors
-- etc. (I will add also **React Native** and **NativeScript** support)
+- etc.
 
 You could use it also in <strong>existing projects</strong>!! (see the Wiki - https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki)
 
@@ -157,7 +159,7 @@ You can use this feature in HTML, CSS and JavaScript context!
 
 Just put the cursor on the word you want to check, "right-click" -> <code>"Can I use?"</code> and it will appear an input panel with all items that have a name matching with the word.
 
-You can use key-map: <code>ctrl+alt+w</code>. Key-Map list: Preferences -> Package Settings ->  JavaScript Completions -> Key Bindings - Default.
+You can use key-map: <code>ctrl+alt+w</code> (<code>super+alt+w</code> on Windows). Key-Map list: Preferences -> Package Settings ->  JavaScript Completions -> Key Bindings - Default.
 
 After selecting an item from the list, it will appear a popup with all information from the [http://caniuse.com](http://caniuse.com) support tables.
 
diff --git a/_generated_2018_02_11_at_20_21_24.py b/_generated_2018_02_11_at_20_21_24.py
@@ -208,6 +208,9 @@ def on_hover(self, view, point, hover_zone) :
   
       str_region = view.word(point)
       result = Util.get_current_region_scope(view, str_region)
+      if not result:
+        return
+        
       str_selected = result.get("region_string_stripped")
       completion_list = list()
       for API_Keyword in javascriptCompletions.api :
diff --git a/changelog/2.6.98.txt b/changelog/2.6.98.txt
@@ -0,0 +1,50 @@
+v2.6.98
+
+## Fixes
+
+- #48, keymap update on Windows, now bindings are like Super + Alt + <alphanum>
+- AttributeError: 'NoneType' object has no attribute 'get' #49
+
+🎉🎉 ANNOUNCEMENT - NEW PLUGIN "JavaScript Enhancements" RELEASED 🎉🎉
+=======================================================================
+
+I developed a new plugin with new features thanks to Flow (javascript static type checker from Facebook).
+
+So, I will NO LONGER SUPPORT "JavaScript Completions" plugin, except in particular cases. 
+I'm going to focus only on this new one!
+
+You can find it on: 👉👉 https://github.com/pichillilorenzo/JavaScriptEnhancements 👈👈
+
+This new plugin offers not only a BETTER AUTOCOMPLETE but a lot of FEATURES about creating, 
+developing and managing javascript projects, such as:
+
+- JavaScript real-time errors
+- Code Refactoring
+- Local bookmarks project
+- Cordova projects (run cordova emulate, build, compile, serve, etc. directly from Sublime Text!)
+- Ionic v1 and v2 (it includes also v3) projects (same as Cordova projects!)
+- Angular v1 and v2 (it includes also v4 and v5) projects
+- React projects (only about the creation at this moment)
+- React Native projects (only about the creation at this moment. I will add also **NativeScript** support)
+- Express projects (only about the creation at this moment)
+- Yeoman generators
+- etc.
+
+You could use it also in existing projects!! 
+
+SEE the Wiki - https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki
+to get the complete list of the features that it offers!
+
+It will turn Sublime Text into a JavaScript IDE like!
+=====================================================
+
+## OS SUPPORTED NOW by this new plugin:
+=======================================
+
+👉 Linux (64-bit)
+👉 Mac OS X 
+👉 Windows (64-bit): released without the use of TerminalView plugin. For each feature (like also creating a project) will be used the cmd.exe shell (so during the creation of a project don't close it until it finishes!). Unfortunately the TerminalView plugin supports only Linux-based OS 😞 . Has someone any advice or idea about that? Is there something similar to the TerminalView plugin for Windows?? Thanks!
+
+Email me for any questions or doubts about this new project on: pichillilorenzo@gmail.com
+
+Thanks for your support!!!
diff --git a/changelog/install.txt b/changelog/install.txt
@@ -1,7 +1,6 @@
 JavaScript Completions Package
 ===============================
 
-
 🎉🎉 ANNOUNCEMENT - NEW PLUGIN "JavaScript Enhancements" RELEASED 🎉🎉
 =======================================================================
 
@@ -12,22 +11,28 @@ I'm going to focus only on this new one!
 
 You can find it on: 👉👉 https://github.com/pichillilorenzo/JavaScriptEnhancements 👈👈
 
-This new plugin offers not only a better autocomplete but a lot of features about creating, 
+This new plugin offers not only a BETTER AUTOCOMPLETE but a lot of FEATURES about creating, 
 developing and managing javascript projects, such as:
 
+- JavaScript real-time errors
+- Code Refactoring
+- Local bookmarks project
 - Cordova projects (run cordova emulate, build, compile, serve, etc. directly from Sublime Text!)
-- Ionic v1 and v2 projects (same as Cordova projects!)
-- Angular v1 and v2 projects
-- React projects
-- Express projects
+- Ionic v1 and v2 (it includes also v3) projects (same as Cordova projects!)
+- Angular v1 and v2 (it includes also v4 and v5) projects
+- React projects (only about the creation at this moment)
+- React Native projects (only about the creation at this moment. I will add also **NativeScript** support)
+- Express projects (only about the creation at this moment)
 - Yeoman generators
-- Local bookmarks project
-- JavaScript real-time errors
-- etc. (I will add also React Native and NativeScript support)
+- etc.
+
+You could use it also in existing projects!! 
 
-You could use it also in existing projects!! (see the Wiki - https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki)
+SEE the Wiki - https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki
+to get the complete list of the features that it offers!
 
 It will turn Sublime Text into a JavaScript IDE like!
+=====================================================
 
 ## OS SUPPORTED NOW by this new plugin:
 =======================================
@@ -36,7 +41,6 @@ It will turn Sublime Text into a JavaScript IDE like!
 👉 Mac OS X 
 👉 Windows (64-bit): released without the use of TerminalView plugin. For each feature (like also creating a project) will be used the cmd.exe shell (so during the creation of a project don't close it until it finishes!). Unfortunately the TerminalView plugin supports only Linux-based OS 😞 . Has someone any advice or idea about that? Is there something similar to the TerminalView plugin for Windows?? Thanks!
 
-
 Email me for any questions or doubts about this new project on: pichillilorenzo@gmail.com
 
 Thanks for your support!!!
diff --git a/javascript_completions/on_hover_event_listener.py b/javascript_completions/on_hover_event_listener.py
@@ -17,6 +17,9 @@ def on_hover(self, view, point, hover_zone) :
 
     str_region = view.word(point)
     result = Util.get_current_region_scope(view, str_region)
+    if not result:
+      return
+      
     str_selected = result.get("region_string_stripped")
     completion_list = list()
     for API_Keyword in javascriptCompletions.api :

Original file line number	Diff line number	Diff line change
`@@ -1,28 +1,28 @@`
`1`	`1`	`[`
`2`	`2`	`{`
`3`		`- "keys": ["ctrl+super+c"],`
	`3`	`+ "keys": ["super+alt+c"],`
`4`	`4`	`"command": "find_description"`
`5`	`5`	`},`
`6`	`6`	`{`
`7`		`- "keys": ["ctrl+super+s"],`
	`7`	`+ "keys": ["super+alt+s"],`
`8`	`8`	`"command": "evaluate_javascript",`
`9`	`9`	`"args": {"eval_type": "eval"}`
`10`	`10`	`},`
`11`	`11`	`{`
`12`		`- "keys": ["ctrl+super+z"],`
	`12`	`+ "keys": ["super+alt+z"],`
`13`	`13`	`"command": "evaluate_javascript",`
`14`	`14`	`"args": {"is_line": "True", "eval_type": "eval"}`
`15`	`15`	`},`
`16`	`16`	`{`
`17`		`- "keys": ["ctrl+super+h"],`
	`17`	`+ "keys": ["super+alt+h"],`
`18`	`18`	`"command": "hide_code_highlights_eval"`
`19`	`19`	`},`
`20`	`20`	`{`
`21`		`- "keys": ["ctrl+super+j"],`
	`21`	`+ "keys": ["super+alt+j"],`
`22`	`22`	`"command": "show_code_highlights_eval"`
`23`	`23`	`},`
`24`	`24`	`{`
`25`		`- "keys": ["ctrl+alt+w"],`
	`25`	`+ "keys": ["super+alt+w"],`
`26`	`26`	`"command": "can_i_use"`
`27`	`27`	`}`
`28`	`28`	`]`