Skip to content

Commit e137dd0

Browse files
committed
Bind address to new element instead of raw HTML construction
Signed-off-by: DL6ER <[email protected]>
1 parent 6023387 commit e137dd0

1 file changed

Lines changed: 13 additions & 16 deletions

File tree

scripts/js/groups-lists.js

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -234,23 +234,20 @@ function initTable() {
234234
if (data.address.startsWith("file://")) {
235235
// Local files cannot be downloaded from a distant client so don't show
236236
// a link to such a list here
237-
$("td:eq(3)", row).html(
238-
'<code id="address_' +
239-
dataId +
240-
'" class="breakall">' +
241-
utils.escapeHtml(data.address) +
242-
"</code>"
243-
);
237+
const codeElem = document.createElement("code");
238+
codeElem.id = "address_" + dataId;
239+
codeElem.className = "breakall";
240+
codeElem.textContent = data.address;
241+
$("td:eq(3)", row).empty().append(codeElem);
244242
} else {
245-
$("td:eq(3)", row).html(
246-
'<a id="address_' +
247-
dataId +
248-
'" class="breakall" href="' +
249-
encodeURI(data.address) +
250-
'" target="_blank" rel="noopener noreferrer">' +
251-
utils.escapeHtml(data.address) +
252-
"</a>"
253-
);
243+
const aElem = document.createElement("a");
244+
aElem.id = "address_" + dataId;
245+
aElem.className = "breakall";
246+
aElem.href = data.address;
247+
aElem.target = "_blank";
248+
aElem.rel = "noopener noreferrer";
249+
aElem.textContent = data.address;
250+
$("td:eq(3)", row).empty().append(aElem);
254251
}
255252

256253
$("td:eq(4)", row).html(

0 commit comments

Comments
 (0)