Fix risky tests

MauricioFauth · MauricioFauth · commit 69ee1104925e · 2019-01-16T18:36:52.000-02:00
- Rename test providers
- Mark tests as incomplete

Signed-off-by: Maurício Meneghini Fauth &lt;mauriciofauth@gmail.com&gt;
diff --git a/tests/Components/Array2dTest.php b/tests/Components/Array2dTest.php
@@ -35,13 +35,20 @@ public function testParseErr1()
     {
         $parser = new Parser();
         Array2d::parse($parser, $this->getTokensList('(1, 2 +'));
-        // TODO: Assert errors.
+
+        $this->markTestIncomplete(
+            'This test has not been implemented yet.'
+        );
     }
 
     public function testParseErr2()
     {
         $parser = new Parser();
         Array2d::parse($parser, $this->getTokensList('(1, 2 TABLE'));
+
+        $this->markTestIncomplete(
+            'This test has not been implemented yet.'
+        );
     }
 
     public function testParseErr3()
diff --git a/tests/Components/ArrayObjTest.php b/tests/Components/ArrayObjTest.php
@@ -38,7 +38,7 @@ public function testParseType()
     }
 
     /**
-     * @dataProvider testParseProvider
+     * @dataProvider parseProvider
      *
      * @param mixed $test
      */
@@ -47,7 +47,7 @@ public function testParse($test)
         $this->runParserTest($test);
     }
 
-    public function testParseProvider()
+    public function parseProvider()
     {
         return [
             ['parser/parseArrayErr1'],
diff --git a/tests/Components/ExpressionTest.php b/tests/Components/ExpressionTest.php
@@ -22,7 +22,7 @@ public function testParse2()
     }
 
     /**
-     * @dataProvider testParseErrProvider
+     * @dataProvider parseErrProvider
      *
      * @param mixed $expr
      * @param mixed $error
@@ -35,7 +35,7 @@ public function testParseErr($expr, $error)
         $this->assertEquals($errors[0][0], $error);
     }
 
-    public function testParseErrProvider()
+    public function parseErrProvider()
     {
         return [
             /*
diff --git a/tests/Components/LimitTest.php b/tests/Components/LimitTest.php
@@ -21,7 +21,7 @@ public function testBuildWithOffset()
     }
 
     /**
-     * @dataProvider testParseProvider
+     * @dataProvider parseProvider
      *
      * @param mixed $test
      */
@@ -30,7 +30,7 @@ public function testParse($test)
         $this->runParserTest($test);
     }
 
-    public function testParseProvider()
+    public function parseProvider()
     {
         return [
             ['parser/parseLimitErr1'],
diff --git a/tests/Components/LockExpressionTest.php b/tests/Components/LockExpressionTest.php
@@ -27,7 +27,7 @@ public function testParse2()
     }
 
     /**
-     * @dataProvider testParseErrProvider
+     * @dataProvider parseErrProvider
      *
      * @param mixed $expr
      * @param mixed $error
@@ -40,7 +40,7 @@ public function testParseErr($expr, $error)
         $this->assertEquals($errors[0][0], $error);
     }
 
-    public function testParseErrProvider()
+    public function parseErrProvider()
     {
         return [
             [
diff --git a/tests/Lexer/LexerTest.php b/tests/Lexer/LexerTest.php
@@ -48,7 +48,7 @@ public function testErrorStrict()
     }
 
     /**
-     * @dataProvider testLexProvider
+     * @dataProvider lexProvider
      *
      * @param mixed $test
      */
@@ -57,7 +57,7 @@ public function testLex($test)
         $this->runParserTest($test);
     }
 
-    public function testLexProvider()
+    public function lexProvider()
     {
         return [
             ['lexer/lex'],
diff --git a/tests/Misc/BugsTest.php b/tests/Misc/BugsTest.php
@@ -8,7 +8,7 @@
 class BugsTest extends TestCase
 {
     /**
-     * @dataProvider testBugProvider
+     * @dataProvider bugProvider
      *
      * @param mixed $test
      */
@@ -17,7 +17,7 @@ public function testBug($test)
         $this->runParserTest($test);
     }
 
-    public function testBugProvider()
+    public function bugProvider()
     {
         return [
             ['bugs/gh9'],
diff --git a/tests/Misc/ParameterTest.php b/tests/Misc/ParameterTest.php
@@ -8,7 +8,7 @@
 class ParameterTest extends TestCase
 {
     /**
-     * @dataProvider testParameterProvider
+     * @dataProvider parameterProvider
      *
      * @param mixed $test
      */
@@ -17,7 +17,7 @@ public function testParameter($test)
         $this->runParserTest($test);
     }
 
-    public function testParameterProvider()
+    public function parameterProvider()
     {
         return [
             ['misc/parseParameter'],
diff --git a/tests/Parser/AlterStatementTest.php b/tests/Parser/AlterStatementTest.php
@@ -8,7 +8,7 @@
 class AlterStatementTest extends TestCase
 {
     /**
-     * @dataProvider testAlterProvider
+     * @dataProvider alterProvider
      *
      * @param mixed $test
      */
@@ -17,7 +17,7 @@ public function testAlter($test)
         $this->runParserTest($test);
     }
 
-    public function testAlterProvider()
+    public function alterProvider()
     {
         return [
             ['parser/parseAlter'],
diff --git a/tests/Parser/CallStatementTest.php b/tests/Parser/CallStatementTest.php
@@ -8,7 +8,7 @@
 class CallStatementTest extends TestCase
 {
     /**
-     * @dataProvider testCallProvider
+     * @dataProvider callProvider
      *
      * @param mixed $test
      */
@@ -17,7 +17,7 @@ public function testCall($test)
         $this->runParserTest($test);
     }
 
-    public function testCallProvider()
+    public function callProvider()
     {
         return [
             ['parser/parseCall'],
diff --git a/tests/Parser/CreateStatementTest.php b/tests/Parser/CreateStatementTest.php
@@ -8,7 +8,7 @@
 class CreateStatementTest extends TestCase
 {
     /**
-     * @dataProvider testCreateProvider
+     * @dataProvider createProvider
      *
      * @param mixed $test
      */
@@ -17,7 +17,7 @@ public function testCreate($test)
         $this->runParserTest($test);
     }
 
-    public function testCreateProvider()
+    public function createProvider()
     {
         return [
             ['parser/parseCreateFunction'],
diff --git a/tests/Parser/DeleteStatementTest.php b/tests/Parser/DeleteStatementTest.php
@@ -8,7 +8,7 @@
 class DeleteStatementTest extends TestCase
 {
     /**
-     * @dataProvider testDeleteProvider
+     * @dataProvider deleteProvider
      *
      * @param mixed $test
      */
@@ -17,7 +17,7 @@ public function testDelete($test)
         $this->runParserTest($test);
     }
 
-    public function testDeleteProvider()
+    public function deleteProvider()
     {
         return [
             ['parser/parseDelete'],
diff --git a/tests/Parser/ExplainStatement.php b/tests/Parser/ExplainStatement.php
@@ -8,7 +8,7 @@
 class ExplainStatementTest extends TestCase
 {
     /**
-     * @dataProvider testExplainProvider
+     * @dataProvider explainProvider
      *
      * @param mixed $test
      */
@@ -17,7 +17,7 @@ public function testExplain($test)
         $this->runParserTest($test);
     }
 
-    public function testExplainProvider()
+    public function explainProvider()
     {
         return [
             ['parser/parseExplain'],
diff --git a/tests/Parser/InsertStatementTest.php b/tests/Parser/InsertStatementTest.php
@@ -8,7 +8,7 @@
 class InsertStatementTest extends TestCase
 {
     /**
-     * @dataProvider testInsertProvider
+     * @dataProvider insertProvider
      *
      * @param mixed $test
      */
@@ -17,7 +17,7 @@ public function testInsert($test)
         $this->runParserTest($test);
     }
 
-    public function testInsertProvider()
+    public function insertProvider()
     {
         return [
             ['parser/parseInsert'],
diff --git a/tests/Parser/LoadStatementTest.php b/tests/Parser/LoadStatementTest.php
@@ -17,7 +17,7 @@ public function testLoadOptions()
     }
 
     /**
-     * @dataProvider testLoadProvider
+     * @dataProvider loadProvider
      *
      * @param mixed $test
      */
@@ -26,7 +26,7 @@ public function testLoad($test)
         $this->runParserTest($test);
     }
 
-    public function testLoadProvider()
+    public function loadProvider()
     {
         return [
             ['parser/parseLoad1'],
diff --git a/tests/Parser/LockStatementTest.php b/tests/Parser/LockStatementTest.php
@@ -8,7 +8,7 @@
 class LockStatementTest extends TestCase
 {
     /**
-     * @dataProvider testLockProvider
+     * @dataProvider lockProvider
      *
      * @param mixed $test
      */
@@ -17,7 +17,7 @@ public function testLock($test)
         $this->runParserTest($test);
     }
 
-    public function testLockProvider()
+    public function lockProvider()
     {
         return [
             ['parser/parseLock1'],
diff --git a/tests/Parser/ParserTest.php b/tests/Parser/ParserTest.php
@@ -12,7 +12,7 @@
 class ParserTest extends TestCase
 {
     /**
-     * @dataProvider testParseProvider
+     * @dataProvider parseProvider
      *
      * @param mixed $test
      */
@@ -21,7 +21,7 @@ public function testParse($test)
         $this->runParserTest($test);
     }
 
-    public function testParseProvider()
+    public function parseProvider()
     {
         return [
             ['parser/parse'],
diff --git a/tests/Parser/PurgeStatementTest.php b/tests/Parser/PurgeStatementTest.php
@@ -8,7 +8,7 @@
 class PurgeStatementTest extends TestCase
 {
     /**
-     * @dataProvider testPurgeProvider
+     * @dataProvider purgeProvider
      *
      * @param mixed $test
      */
@@ -17,7 +17,7 @@ public function testPurge($test)
         $this->runParserTest($test);
     }
 
-    public function testPurgeProvider()
+    public function purgeProvider()
     {
         return [
             ['parser/parsePurge'],
diff --git a/tests/Parser/RenameStatementTest.php b/tests/Parser/RenameStatementTest.php
@@ -8,7 +8,7 @@
 class RenameStatementTest extends TestCase
 {
     /**
-     * @dataProvider testRenameProvider
+     * @dataProvider renameProvider
      *
      * @param mixed $test
      */
@@ -17,7 +17,7 @@ public function testRename($test)
         $this->runParserTest($test);
     }
 
-    public function testRenameProvider()
+    public function renameProvider()
     {
         return [
             ['parser/parseRename'],
diff --git a/tests/Parser/ReplaceStatementTest.php b/tests/Parser/ReplaceStatementTest.php
@@ -8,7 +8,7 @@
 class ReplaceStatementTest extends TestCase
 {
     /**
-     * @dataProvider testReplaceProvider
+     * @dataProvider replaceProvider
      *
      * @param mixed $test
      */
@@ -17,7 +17,7 @@ public function testReplace($test)
         $this->runParserTest($test);
     }
 
-    public function testReplaceProvider()
+    public function replaceProvider()
     {
         return [
             ['parser/parseReplace'],
diff --git a/tests/Parser/RestoreStatementTest.php b/tests/Parser/RestoreStatementTest.php
@@ -8,7 +8,7 @@
 class RestoreStatementTest extends TestCase
 {
     /**
-     * @dataProvider testRestoreProvider
+     * @dataProvider restoreProvider
      *
      * @param mixed $test
      */
@@ -17,7 +17,7 @@ public function testRestore($test)
         $this->runParserTest($test);
     }
 
-    public function testRestoreProvider()
+    public function restoreProvider()
     {
         return [
             ['parser/parseRestore'],
diff --git a/tests/Parser/SelectStatementTest.php b/tests/Parser/SelectStatementTest.php
@@ -17,7 +17,7 @@ public function testSelectOptions()
     }
 
     /**
-     * @dataProvider testSelectProvider
+     * @dataProvider selectProvider
      *
      * @param mixed $test
      */
@@ -26,7 +26,7 @@ public function testSelect($test)
         $this->runParserTest($test);
     }
 
-    public function testSelectProvider()
+    public function selectProvider()
     {
         return [
             ['parser/parseSelect2'],
diff --git a/tests/Parser/SetStatementTest.php b/tests/Parser/SetStatementTest.php
diff --git a/tests/Parser/TransactionStatementTest.php b/tests/Parser/TransactionStatementTest.php
diff --git a/tests/Parser/UpdateStatementTest.php b/tests/Parser/UpdateStatementTest.php
diff --git a/tests/Utils/BufferedQueryTest.php b/tests/Utils/BufferedQueryTest.php
diff --git a/tests/Utils/QueryTest.php b/tests/Utils/QueryTest.php

Original file line number	Diff line number	Diff line change
`@@ -35,13 +35,20 @@ public function testParseErr1()`
`35`	`35`	`{`
`36`	`36`	`$parser = new Parser();`
`37`	`37`	`Array2d::parse($parser, $this->getTokensList('(1, 2 +'));`
`38`		`- // TODO: Assert errors.`
	`38`	`+`
	`39`	`+ $this->markTestIncomplete(`
	`40`	`+ 'This test has not been implemented yet.'`
	`41`	`+ );`
`39`	`42`	`}`
`40`	`43`
`41`	`44`	`public function testParseErr2()`
`42`	`45`	`{`
`43`	`46`	`$parser = new Parser();`
`44`	`47`	`Array2d::parse($parser, $this->getTokensList('(1, 2 TABLE'));`
	`48`	`+`
	`49`	`+ $this->markTestIncomplete(`
	`50`	`+ 'This test has not been implemented yet.'`
	`51`	`+ );`
`45`	`52`	`}`
`46`	`53`
`47`	`54`	`public function testParseErr3()`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public function testParseType()`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`/**`
`41`		`- * @dataProvider testParseProvider`
	`41`	`+ * @dataProvider parseProvider`
`42`	`42`	`*`
`43`	`43`	`* @param mixed $test`
`44`	`44`	`*/`
`@@ -47,7 +47,7 @@ public function testParse($test)`
`47`	`47`	`$this->runParserTest($test);`
`48`	`48`	`}`
`49`	`49`
`50`		`- public function testParseProvider()`
	`50`	`+ public function parseProvider()`
`51`	`51`	`{`
`52`	`52`	`return [`
`53`	`53`	`['parser/parseArrayErr1'],`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ public function testParse2()`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`/**`
`25`		`- * @dataProvider testParseErrProvider`
	`25`	`+ * @dataProvider parseErrProvider`
`26`	`26`	`*`
`27`	`27`	`* @param mixed $expr`
`28`	`28`	`* @param mixed $error`
`@@ -35,7 +35,7 @@ public function testParseErr($expr, $error)`
`35`	`35`	`$this->assertEquals($errors[0][0], $error);`
`36`	`36`	`}`
`37`	`37`
`38`		`- public function testParseErrProvider()`
	`38`	`+ public function parseErrProvider()`
`39`	`39`	`{`
`40`	`40`	`return [`
`41`	`41`	`/*`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ public function testBuildWithOffset()`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`/**`
`24`		`- * @dataProvider testParseProvider`
	`24`	`+ * @dataProvider parseProvider`
`25`	`25`	`*`
`26`	`26`	`* @param mixed $test`
`27`	`27`	`*/`
`@@ -30,7 +30,7 @@ public function testParse($test)`
`30`	`30`	`$this->runParserTest($test);`
`31`	`31`	`}`
`32`	`32`
`33`		`- public function testParseProvider()`
	`33`	`+ public function parseProvider()`
`34`	`34`	`{`
`35`	`35`	`return [`
`36`	`36`	`['parser/parseLimitErr1'],`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public function testParse2()`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`/**`
`30`		`- * @dataProvider testParseErrProvider`
	`30`	`+ * @dataProvider parseErrProvider`
`31`	`31`	`*`
`32`	`32`	`* @param mixed $expr`
`33`	`33`	`* @param mixed $error`
`@@ -40,7 +40,7 @@ public function testParseErr($expr, $error)`
`40`	`40`	`$this->assertEquals($errors[0][0], $error);`
`41`	`41`	`}`
`42`	`42`
`43`		`- public function testParseErrProvider()`
	`43`	`+ public function parseErrProvider()`
`44`	`44`	`{`
`45`	`45`	`return [`
`46`	`46`	`[`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public function testErrorStrict()`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`/**`
`51`		`- * @dataProvider testLexProvider`
	`51`	`+ * @dataProvider lexProvider`
`52`	`52`	`*`
`53`	`53`	`* @param mixed $test`
`54`	`54`	`*/`
`@@ -57,7 +57,7 @@ public function testLex($test)`
`57`	`57`	`$this->runParserTest($test);`
`58`	`58`	`}`
`59`	`59`
`60`		`- public function testLexProvider()`
	`60`	`+ public function lexProvider()`
`61`	`61`	`{`
`62`	`62`	`return [`
`63`	`63`	`['lexer/lex'],`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`class BugsTest extends TestCase`
`9`	`9`	`{`
`10`	`10`	`/**`
`11`		`- * @dataProvider testBugProvider`
	`11`	`+ * @dataProvider bugProvider`
`12`	`12`	`*`
`13`	`13`	`* @param mixed $test`
`14`	`14`	`*/`
`@@ -17,7 +17,7 @@ public function testBug($test)`
`17`	`17`	`$this->runParserTest($test);`
`18`	`18`	`}`
`19`	`19`
`20`		`- public function testBugProvider()`
	`20`	`+ public function bugProvider()`
`21`	`21`	`{`
`22`	`22`	`return [`
`23`	`23`	`['bugs/gh9'],`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`class ParameterTest extends TestCase`
`9`	`9`	`{`
`10`	`10`	`/**`
`11`		`- * @dataProvider testParameterProvider`
	`11`	`+ * @dataProvider parameterProvider`
`12`	`12`	`*`
`13`	`13`	`* @param mixed $test`
`14`	`14`	`*/`
`@@ -17,7 +17,7 @@ public function testParameter($test)`
`17`	`17`	`$this->runParserTest($test);`
`18`	`18`	`}`
`19`	`19`
`20`		`- public function testParameterProvider()`
	`20`	`+ public function parameterProvider()`
`21`	`21`	`{`
`22`	`22`	`return [`
`23`	`23`	`['misc/parseParameter'],`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`class AlterStatementTest extends TestCase`
`9`	`9`	`{`
`10`	`10`	`/**`
`11`		`- * @dataProvider testAlterProvider`
	`11`	`+ * @dataProvider alterProvider`
`12`	`12`	`*`
`13`	`13`	`* @param mixed $test`
`14`	`14`	`*/`
`@@ -17,7 +17,7 @@ public function testAlter($test)`
`17`	`17`	`$this->runParserTest($test);`
`18`	`18`	`}`
`19`	`19`
`20`		`- public function testAlterProvider()`
	`20`	`+ public function alterProvider()`
`21`	`21`	`{`
`22`	`22`	`return [`
`23`	`23`	`['parser/parseAlter'],`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`class CallStatementTest extends TestCase`
`9`	`9`	`{`
`10`	`10`	`/**`
`11`		`- * @dataProvider testCallProvider`
	`11`	`+ * @dataProvider callProvider`
`12`	`12`	`*`
`13`	`13`	`* @param mixed $test`
`14`	`14`	`*/`
`@@ -17,7 +17,7 @@ public function testCall($test)`
`17`	`17`	`$this->runParserTest($test);`
`18`	`18`	`}`
`19`	`19`
`20`		`- public function testCallProvider()`
	`20`	`+ public function callProvider()`
`21`	`21`	`{`
`22`	`22`	`return [`
`23`	`23`	`['parser/parseCall'],`