Adding more explain tests and improve comments

Signed-off-by: iifawzi <[email protected]>

Author: iifawzi

src/Statements/ExplainStatement.php

@@ -43,8 +43,8 @@ class ExplainStatement extends Statement
 
     /**
      * The statement alias, could be any of the following:
-     * - EXPLAIN/DESC/DESCRIBE
-     * - EXPLAIN/DESC/DESCRIBE ANALYZE
+     * - {EXPLAIN | DESCRIBE | DESC}
+     * - {EXPLAIN | DESCRIBE | DESC} ANALYZE
      * - ANALYZE
      *
      * @var string
@@ -89,8 +89,8 @@ public function parse(Parser $parser, TokensList $list)
         /**
          * To Differentiate between ANALYZE / EXPLAIN / EXPLAIN ANALYZE
          * 0 -> ANALYZE ( used by mariaDB https://mariadb.com/kb/en/analyze-statement)
-         * 1 -> EXPLAIN / DESC / DESCRIBE
-         * 2 -> EXPLAIN / DESC / DESCRIBE [ANALYZE]
+         * 1 -> {EXPLAIN | DESCRIBE | DESC}
+         * 2 -> {EXPLAIN | DESCRIBE | DESC} ANALYZE
          */
         $miniState = 0;
 
@@ -184,17 +184,20 @@ public function parse(Parser $parser, TokensList $list)
 
     public function build(): string
     {
-        $str = $this->statemenetAlias . ' ';
+        $str = $this->statemenetAlias;
 
-        $str .= OptionsArray::build($this->options);
+        if (count($this->options->options)) {
+            $str .= ' ';
+        }
+
+        $str .= OptionsArray::build($this->options) . ' ';
 
         if ($this->bodyParser) {
             foreach ($this->bodyParser->statements as $statement) {
                 $str .= $statement->build();
             }
         } elseif ($this->connectionId) {
-            $str .= 'FOR CONNECTION ';
-            $str .= $this->connectionId;
+            $str .= 'FOR CONNECTION ' . $this->connectionId;
         } elseif ($this->explainedTable) {
             $str .= $this->explainedTable;
         }

tests/Builder/ExplainStatementTest.php

@@ -64,5 +64,14 @@ public function testBuilder(): void
             'DESC FOR CONNECTION 458',
             $stmt->build()
         );
+
+        /* Assertion 6 */
+        $query = 'EXPLAIN FORMAT=TREE SELECT * FROM db;';
+        $parser = new Parser($query);
+        $stmt = $parser->statements[0];
+        $this->assertEquals(
+            'EXPLAIN FORMAT=TREE SELECT * FROM db',
+            $stmt->build()
+        );
     }
 }

tests/Parser/ExplainStatementTest.php

@@ -26,6 +26,7 @@ public function explainProvider(): array
             ['parser/parseExplain1'],
             ['parser/parseExplain2'],
             ['parser/parseExplain3'],
+            ['parser/parseExplain4'],
             ['parser/parseExplainErr'],
             ['parser/parseExplainErr1'],
             ['parser/parseExplainErr2'],

tests/data/parser/parseExplain4.in

@@ -0,0 +1 @@
+EXPLAIN FORMAT=TREE SELECT * FROM db