Code Modernization: Utilize spaceship operator <=> in sort comparison logic.

Some replaced instances also fix a bug where the comparison function should have returned `0` as opposed to `1` or `-1` as used in ternaries. This results in a performance improvement.

Developed in WordPress#10717

Props soean, mukesh27, westonruter.
Fixes #64497.


git-svn-id: https://develop.svn.wordpress.org/trunk@61474 602fd350-edb4-49c9-b593-d223f7449a82

Author: westonruter

src/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -302,15 +302,9 @@ public function _order_callback( $theme_a, $theme_b ) {
 		$a = $theme_a[ $orderby ];
 		$b = $theme_b[ $orderby ];
 
-		if ( $a === $b ) {
-			return 0;
-		}
-
-		if ( 'DESC' === $order ) {
-			return ( $a < $b ) ? 1 : -1;
-		} else {
-			return ( $a < $b ) ? -1 : 1;
-		}
+		return 'DESC' === $order ?
+			$b <=> $a :
+			$a <=> $b;
 	}
 
 	/**

src/wp-admin/includes/class-wp-plugin-install-list-table.php

@@ -458,15 +458,9 @@ private function order_callback( $plugin_a, $plugin_b ) {
 		$a = $plugin_a->$orderby;
 		$b = $plugin_b->$orderby;
 
-		if ( $a === $b ) {
-			return 0;
-		}
-
-		if ( 'DESC' === $this->order ) {
-			return ( $a < $b ) ? 1 : -1;
-		} else {
-			return ( $a < $b ) ? -1 : 1;
-		}
+		return 'DESC' === $this->order ?
+			$b <=> $a :
+			$a <=> $b;
 	}
 
 	/**

src/wp-admin/includes/menu.php

@@ -327,12 +327,9 @@ function sort_menu( $a, $b ) {
 		} elseif ( ! isset( $menu_order[ $a ] ) && isset( $menu_order[ $b ] ) ) {
 			return 1;
 		} elseif ( isset( $menu_order[ $a ] ) && isset( $menu_order[ $b ] ) ) {
-			if ( $menu_order[ $a ] === $menu_order[ $b ] ) {
-				return 0;
-			}
-			return ( $menu_order[ $a ] < $menu_order[ $b ] ) ? -1 : 1;
+			return $menu_order[ $a ] <=> $menu_order[ $b ];
 		} else {
-			return ( $default_menu_order[ $a ] <= $default_menu_order[ $b ] ) ? -1 : 1;
+			return $default_menu_order[ $a ] <=> $default_menu_order[ $b ];
 		}
 	}
 

src/wp-includes/interactivity-api/class-wp-interactivity-api.php

@@ -904,14 +904,11 @@ function ( $a, $b ) {
 				$a_suffix = $a['suffix'] ?? '';
 				$b_suffix = $b['suffix'] ?? '';
 				if ( $a_suffix !== $b_suffix ) {
-					return $a_suffix < $b_suffix ? -1 : 1;
+					return $a_suffix <=> $b_suffix;
 				}
 				$a_id = $a['unique_id'] ?? '';
 				$b_id = $b['unique_id'] ?? '';
-				if ( $a_id === $b_id ) {
-					return 0;
-				}
-				return $a_id > $b_id ? 1 : -1;
+				return $a_id <=> $b_id;
 			}
 		);
 		return $entries;

src/wp-includes/script-loader.php

@@ -2999,7 +2999,7 @@ function wp_maybe_inline_styles() {
 		usort(
 			$styles,
 			static function ( $a, $b ) {
-				return ( $a['size'] <= $b['size'] ) ? -1 : 1;
+				return $a['size'] <=> $b['size'];
 			}
 		);