Skip to content

Commit fa2279f

Browse files
decofeCentaur AIampcode-com
authored
chore: default to min-trace-logs (#23851)
Co-authored-by: Centaur AI <[email protected]> Co-authored-by: Amp <[email protected]>
1 parent 0eeb8c5 commit fa2279f

5 files changed

Lines changed: 11 additions & 6 deletions

File tree

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ maxperf: ## Builds `reth` with the most aggressive optimisations.
245245

246246
.PHONY: maxperf-no-asm
247247
maxperf-no-asm: ## Builds `reth` with the most aggressive optimisations, minus the "asm-keccak" feature.
248-
RUSTFLAGS="-C target-cpu=native" cargo build --profile maxperf --no-default-features --features jemalloc,min-debug-logs,otlp,otlp-logs,reth-revm/portable,js-tracer,keccak-cache-global,rocksdb
248+
RUSTFLAGS="-C target-cpu=native" cargo build --profile maxperf --no-default-features --features jemalloc,min-trace-logs,otlp,otlp-logs,reth-revm/portable,js-tracer,keccak-cache-global,rocksdb
249249

250250
fmt:
251251
cargo +nightly fmt

bin/reth-bb/Cargo.toml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ default = [
7070
"reth-cli-util/jemalloc",
7171
"asm-keccak",
7272
"keccak-cache-global",
73-
"min-debug-logs",
73+
"min-trace-logs",
7474
]
7575

7676
jemalloc = [
@@ -101,6 +101,11 @@ min-debug-logs = [
101101
"reth-ethereum-cli/min-debug-logs",
102102
"reth-node-core/min-debug-logs",
103103
]
104+
min-trace-logs = [
105+
"tracing/release_max_level_trace",
106+
"reth-ethereum-cli/min-trace-logs",
107+
"reth-node-core/min-trace-logs",
108+
]
104109

105110
[[bin]]
106111
name = "reth-bb"

bin/reth-bench/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ RUSTFLAGS="-C target-cpu=native" cargo build --profile profiling --features "jem
8686
Finally, if the purpose of the benchmark is to profile the node when `snmalloc` is configured as the default allocator, it would be built with the following
8787
command:
8888
```bash
89-
RUSTFLAGS="-C target-cpu=native" cargo build --profile profiling --no-default-features --features "snmalloc-native,asm-keccak,min-debug-logs"
89+
RUSTFLAGS="-C target-cpu=native" cargo build --profile profiling --no-default-features --features "snmalloc-native,asm-keccak,min-trace-logs"
9090
```
9191

9292
### Run the Benchmark:

bin/reth/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ default = [
8888
"js-tracer",
8989
"keccak-cache-global",
9090
"asm-keccak",
91-
"min-debug-logs",
91+
"min-trace-logs",
9292
]
9393

9494
otlp = [

docs/vocs/docs/pages/installation/source.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,11 +110,11 @@ RUSTFLAGS="-C target-cpu=native" cargo build --profile maxperf
110110

111111
**Features**
112112

113-
The following performance features are enabled by default: `jemalloc` (except on Windows), `asm-keccak`, and `min-debug-logs`.
113+
The following performance features are enabled by default: `jemalloc` (except on Windows), `asm-keccak`, and `min-trace-logs`.
114114

115115
Some additional optional features are available:
116116

117-
- `min-LEVEL-logs`, where `LEVEL` is one of `error`, `warn`, `info`, `debug`, `trace`: disables compilation of logs of lower level than the given one; `min-debug-logs` is enabled by default
117+
- `min-LEVEL-logs`, where `LEVEL` is one of `error`, `warn`, `info`, `debug`, `trace`: disables compilation of logs of lower level than the given one; `min-trace-logs` is enabled by default
118118

119119
You can build with maximum performance optimizations using:
120120

0 commit comments

Comments
 (0)