fix: redact pending primary email before retirement deletion

Author: ktyagiapphelix2u

common/djangoapps/student/models/user.py

@@ -923,10 +923,10 @@ def redact_pending_email_by_user_value(cls, value, field):
         Returns True if redacted, and False if no matching records found.
         """
         filter_kwargs = {field: value}
-        records_matching_user_value = cls.objects.filter(**filter_kwargs)
-        if not records_matching_user_value.exists():
+        records = list(cls.objects.filter(**filter_kwargs))
+        if not records:
             return False
-        for record in records_matching_user_value:
+        for record in records:
             record.new_email = get_retired_email_by_email(record.new_email)
             record.save(update_fields=['new_email'])
         return True