Skip to content

Commit d6dbc40

Browse files
fix: generate IDV URL only if ACCOUNT_MICROFRONTEND_URL is available (#36898)
The api/courseware/course fails for all the verified enrollments if you are not using Account MFE, which means that you probably won't set ACCOUNT_MICROFRONTEND_URL in your settings/configurations. So this PR adds a check safely try to do rstrip. Fixes a bug in #36870
1 parent 1551cc0 commit d6dbc40

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

lms/djangoapps/verify_student/management/commands/send_verification_expiry_email.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ def send_verification_expiry_email(self, batch_verifications, email_config):
188188
return True
189189

190190
site = Site.objects.get_current()
191-
account_base_url = settings.ACCOUNT_MICROFRONTEND_URL.rstrip('/')
191+
account_base_url = (settings.ACCOUNT_MICROFRONTEND_URL or "").rstrip('/')
192192
message_context = get_base_template_context(site)
193193
message_context.update({
194194
'platform_name': settings.PLATFORM_NAME,

lms/djangoapps/verify_student/services.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ def get_verify_location(cls, course_id=None):
251251
Returns a string:
252252
Returns URL for IDV on Account Microfrontend
253253
"""
254-
account_base_url = settings.ACCOUNT_MICROFRONTEND_URL.rstrip('/')
254+
account_base_url = (settings.ACCOUNT_MICROFRONTEND_URL or "").rstrip('/')
255255
location = f'{account_base_url}/id-verification'
256256
if course_id:
257257
location += f'?course_id={quote(str(course_id))}'

lms/djangoapps/verify_student/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1128,7 +1128,7 @@ def results_callback(request): # lint-amnesty, pylint: disable=too-many-stateme
11281128
log.info("[COSMO-184] Denied verification for receipt_id={receipt_id}.".format(receipt_id=receipt_id))
11291129

11301130
attempt.deny(json.dumps(reason), error_code=error_code)
1131-
account_base_url = settings.ACCOUNT_MICROFRONTEND_URL.rstrip('/')
1131+
account_base_url = (settings.ACCOUNT_MICROFRONTEND_URL or "").rstrip('/')
11321132
reverify_url = f'{account_base_url}/id-verification'
11331133
verification_status_email_vars['reasons'] = reason
11341134
verification_status_email_vars['reverify_url'] = reverify_url

openedx/core/djangoapps/notifications/email/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ def create_email_template_context(username):
9797
'channel': 'email',
9898
'value': False
9999
}
100-
account_base_url = settings.ACCOUNT_MICROFRONTEND_URL.rstrip('/')
100+
account_base_url = (settings.ACCOUNT_MICROFRONTEND_URL or "").rstrip('/')
101101
return {
102102
"platform_name": settings.PLATFORM_NAME,
103103
"mailing_address": settings.CONTACT_MAILING_ADDRESS,

0 commit comments

Comments
 (0)