Skip to content

Commit cd7f2ae

Browse files
feanilclaude
authored andcommitted
fix: use correct Django settings for each service in CI
The static-assets-check workflow was setting DJANGO_SETTINGS_MODULE=lms.envs.production globally, but then running both LMS and CMS collectstatic. Because manage.py doesn't override DJANGO_SETTINGS_MODULE when it's already set (and --settings isn't passed), CMS was running with LMS settings instead of CMS settings. This meant CMS-specific RequireJS builds (cms/static/cms/js/build.js) were never being tested, allowing issues like missing modules to slip through to sandbox deployments. Fix by setting DJANGO_SETTINGS_MODULE explicitly for each service. Co-Authored-By: Claude Opus 4.5 <[email protected]>
1 parent 7c9f468 commit cd7f2ae

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

.github/workflows/static-assets-check.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ jobs:
9898
env:
9999
LMS_CFG: lms/envs/minimal.yml
100100
CMS_CFG: lms/envs/minimal.yml
101-
DJANGO_SETTINGS_MODULE: lms.envs.production
102101
run: |
103-
./manage.py lms collectstatic --noinput
104-
./manage.py cms collectstatic --noinput
102+
DJANGO_SETTINGS_MODULE=lms.envs.production ./manage.py lms collectstatic --noinput
103+
DJANGO_SETTINGS_MODULE=cms.envs.production ./manage.py cms collectstatic --noinput

0 commit comments

Comments
 (0)