Skip to content

Commit 9ef60ae

Browse files
fix: fix toggles
1 parent 3380763 commit 9ef60ae

3 files changed

Lines changed: 2 additions & 28 deletions

File tree

cms/djangoapps/contentstore/rest_api/v1/serializers/course_waffle_flags.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,7 @@ def get_use_new_advanced_settings_page(self, obj):
7676
"""
7777
Method to get the use_new_advanced_settings_page switch
7878
"""
79-
course_key = self.get_course_key()
80-
return toggles.use_new_advanced_settings_page(course_key)
79+
return True
8180

8281
def get_use_new_grading_page(self, obj):
8382
"""

cms/djangoapps/contentstore/toggles.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -197,24 +197,6 @@ def use_new_schedule_details_page(course_key):
197197
return not LEGACY_STUDIO_SCHEDULE_DETAILS.is_enabled(course_key)
198198

199199

200-
# .. toggle_name: legacy_studio.advanced_settings
201-
# .. toggle_implementation: WaffleFlag
202-
# .. toggle_default: False
203-
# .. toggle_description: Temporarily fall back to the old Studio Advanced Settings page.
204-
# .. toggle_use_cases: temporary
205-
# .. toggle_creation_date: 2025-03-14
206-
# .. toggle_target_removal_date: 2025-09-14
207-
# .. toggle_tickets: https://github.com/openedx/edx-platform/issues/36275
208-
# .. toggle_warning: In Ulmo, this toggle will be removed. Only the new (React-based) experience will be available.
209-
LEGACY_STUDIO_ADVANCED_SETTINGS = CourseWaffleFlag('legacy_studio.advanced_settings', __name__)
210-
211-
212-
def use_new_advanced_settings_page(course_key):
213-
"""
214-
Returns a boolean if new studio advanced settings pafe mfe is enabled
215-
"""
216-
return not LEGACY_STUDIO_ADVANCED_SETTINGS.is_enabled(course_key)
217-
218200

219201
# .. toggle_name: legacy_studio.grading
220202
# .. toggle_implementation: WaffleFlag

cms/templates/widgets/header.html

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ <h1 class="branding">
3939
export_url = reverse('export_handler', kwargs={'course_key_string': str(course_key)})
4040
settings_url = reverse('settings_handler', kwargs={'course_key_string': str(course_key)})
4141
grading_url = reverse('grading_handler', kwargs={'course_key_string': str(course_key)})
42-
advanced_settings_url = reverse('advanced_settings_handler', kwargs={'course_key_string': str(course_key)})
4342
tabs_url = reverse('tabs_handler', kwargs={'course_key_string': str(course_key)})
4443
certificates_url = ''
4544
if settings.FEATURES.get("CERTIFICATES_HTML_VIEW") and context_course.cert_html_view_enabled:
@@ -49,7 +48,6 @@ <h1 class="branding">
4948
schedule_details_mfe_enabled = toggles.use_new_schedule_details_page(context_course.id)
5049
grading_mfe_enabled = toggles.use_new_grading_page(context_course.id)
5150
course_team_mfe_enabled = toggles.use_new_course_team_page(context_course.id)
52-
advanced_settings_mfe_enabled = toggles.use_new_advanced_settings_page(context_course.id)
5351
import_mfe_enabled = toggles.use_new_import_page(context_course.id)
5452
export_mfe_enabled = toggles.use_new_export_page(context_course.id)
5553
optimizer_enabled = toggles.enable_course_optimizer(context_course.id)
@@ -156,12 +154,7 @@ <h3 class="title"><span class="label"><span class="label-prefix sr">${_("Course"
156154
<a href="${mfe_proctored_exam_settings_url}">${_("Proctored Exam Settings")}</a>
157155
</li>
158156
% endif
159-
% if has_studio_advanced_settings_access(request.user) and not advanced_settings_mfe_enabled:
160-
<li class="nav-item nav-course-settings-advanced">
161-
<a href="${advanced_settings_url}">${_("Advanced Settings")}</a>
162-
</li>
163-
% endif
164-
% if has_studio_advanced_settings_access(request.user) and advanced_settings_mfe_enabled:
157+
% if has_studio_advanced_settings_access(request.user):
165158
<li class="nav-item nav-course-settings-advanced">
166159
<a href="${get_advanced_settings_url(course_key)}">${_("Advanced Settings")}</a>
167160
</li>

0 commit comments

Comments
 (0)