Skip to content

Commit 895609a

Browse files
fix: fix tests
1 parent ea827fa commit 895609a

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

cms/djangoapps/contentstore/tests/test_course_settings.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
from xblock.fields import Date
3131

3232
from cms.djangoapps.contentstore import toggles
33-
from cms.djangoapps.contentstore.utils import reverse_course_url, reverse_usage_url
33+
from cms.djangoapps.contentstore.utils import get_advanced_settings_url, reverse_course_url, reverse_usage_url
3434
from cms.djangoapps.models.settings.course_grading import (
3535
GRADING_POLICY_CHANGED_EVENT_TYPE,
3636
CourseGradingModel,
@@ -171,7 +171,9 @@ def test_disable_advanced_settings_feature(self, disable_advanced_settings):
171171
If this feature is enabled, only Django Staff/Superuser should be able to access the "Advanced Settings" page.
172172
For non-staff users the "Advanced Settings" tab link should not be visible.
173173
"""
174-
advanced_settings_link_html = f"<a href=\"{self.course_setting_url}\">Advanced Settings</a>".encode('utf-8') # noqa: UP012 # pylint: disable=line-too-long
174+
advanced_settings_link_html = (
175+
f'<a href="{get_advanced_settings_url(self.course.id)}">Advanced Settings</a>'
176+
).encode()
175177

176178
with override_settings(FEATURES={
177179
'DISABLE_ADVANCED_SETTINGS': disable_advanced_settings,

cms/djangoapps/contentstore/views/course.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1522,7 +1522,7 @@ def advanced_settings_handler(request, course_key_string):
15221522
return redirect(get_advanced_settings_url(course_key))
15231523
elif 'application/json' in request.META.get('HTTP_ACCEPT', ''):
15241524
if request.method == 'GET':
1525-
return JsonResponse(CourseMetadata.fetch(course_block))
1525+
return JsonResponse(advanced_dict)
15261526
else:
15271527
try:
15281528
return JsonResponse(

cms/djangoapps/contentstore/views/tests/test_exam_settings_view.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,4 +78,3 @@ def test_view_with_exam_settings_enabled(self, handler):
7878
resp = self.client.get(outline_url, HTTP_ACCEPT='text/html')
7979
self.assertEqual(resp.status_code, 200) # noqa: PT009
8080
self.assertContains(resp, 'Proctored Exam Settings')
81-

0 commit comments

Comments
 (0)