feat: prevent sending notification digest email to disabled users (#36498)

Author: muhammadadeeltajamul

openedx/core/djangoapps/notifications/email/tasks.py

@@ -80,6 +80,9 @@ def send_digest_email_to_user(user, cadence_type, start_date, end_date, course_l
     if cadence_type not in [EmailCadence.DAILY, EmailCadence.WEEKLY]:
         raise ValueError('Invalid cadence_type')
     logger.info(f'<Email Cadence> Sending email to user {user.username} ==Temp Log==')
+    if not user.has_usable_password():
+        logger.info(f'<Email Cadence> User is disabled {user.username} ==Temp Log==')
+        return
     if not is_email_notification_flag_enabled(user):
         logger.info(f'<Email Cadence> Flag disabled for {user.username} ==Temp Log==')
         return

openedx/core/djangoapps/notifications/email/tests/test_tasks.py

@@ -72,6 +72,23 @@ def test_notification_not_send_if_created_on_next_day(self, mock_func):
             send_digest_email_to_user(self.user, EmailCadence.DAILY, start_date, end_date)
         assert not mock_func.called
 
+    @ddt.data(True, False)
+    @patch('edx_ace.ace.send')
+    def test_email_not_send_to_disable_user(self, value, mock_func):
+        """
+        Tests email is not sent to disabled user
+        """
+        created_date = datetime.datetime.now() - datetime.timedelta(days=1)
+        create_notification(self.user, self.course.id, created=created_date)
+        start_date, end_date = get_start_end_date(EmailCadence.DAILY)
+        if value:
+            self.user.set_password("12345678")
+        else:
+            self.user.set_unusable_password()
+        with override_waffle_flag(ENABLE_EMAIL_NOTIFICATIONS, True):
+            send_digest_email_to_user(self.user, EmailCadence.DAILY, start_date, end_date)
+        assert mock_func.called is value
+
     @patch('edx_ace.ace.send')
     def test_notification_not_send_if_created_day_before_yesterday(self, mock_func):
         """