Skip to content

Commit 65ac714

Browse files
fix: fixed tests
1 parent 29e011b commit 65ac714

5 files changed

Lines changed: 12 additions & 40 deletions

File tree

cms/djangoapps/contentstore/tests/test_contentstore.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1487,10 +1487,6 @@ def test_get_json(handler):
14871487
self.assertContains(resp, 'Chapter 2')
14881488

14891489
# go to various pages
1490-
with override_waffle_flag(toggles.LEGACY_STUDIO_IMPORT, True):
1491-
test_get_html('import_handler')
1492-
with override_waffle_flag(toggles.LEGACY_STUDIO_EXPORT, True):
1493-
test_get_html('export_handler')
14941490
with override_waffle_flag(toggles.LEGACY_STUDIO_COURSE_TEAM, True):
14951491
test_get_html('course_team_handler')
14961492
with override_waffle_flag(toggles.LEGACY_STUDIO_SCHEDULE_DETAILS, True):

cms/djangoapps/contentstore/tests/test_course_settings.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,6 @@ def test_discussion_fields_available(self, is_pages_and_resources_enabled,
164164

165165
@ddt.data(False, True)
166166
@override_waffle_flag(toggles.LEGACY_STUDIO_ADVANCED_SETTINGS, True)
167-
@override_waffle_flag(toggles.LEGACY_STUDIO_IMPORT, True)
168-
@override_waffle_flag(toggles.LEGACY_STUDIO_EXPORT, True)
169167
@override_waffle_flag(toggles.LEGACY_STUDIO_COURSE_TEAM, True)
170168
@override_waffle_flag(toggles.LEGACY_STUDIO_SCHEDULE_DETAILS, True)
171169
@override_waffle_flag(toggles.LEGACY_STUDIO_GRADING, True)
@@ -180,8 +178,6 @@ def test_disable_advanced_settings_feature(self, disable_advanced_settings):
180178
'DISABLE_ADVANCED_SETTINGS': disable_advanced_settings,
181179
}):
182180
for handler in (
183-
'import_handler',
184-
'export_handler',
185181
'course_team_handler',
186182
'settings_handler',
187183
'grading_handler',

cms/djangoapps/contentstore/tests/tests.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -264,20 +264,19 @@ def setUp(self):
264264
super().setUp()
265265
self.course = CourseFactory.create(org='edX', number='test_course_key', display_name='Test Course')
266266

267-
@data(('edX/test_course_key/Test_Course', 200), ('garbage:edX+test_course_key+Test_Course', 404))
267+
@data(('edX/test_course_key/Test_Course', 302, 200), ('garbage:edX+test_course_key+Test_Course', 404, 404))
268268
@unpack
269-
@override_waffle_flag(toggles.LEGACY_STUDIO_IMPORT, True)
270-
def test_course_key_decorator(self, course_key, status_code):
269+
def test_course_key_decorator(self, course_key, import_status_code, import_status_handler_code):
271270
"""
272271
Tests for the ensure_valid_course_key decorator.
273272
"""
274273
url = f'/import/{course_key}'
275274
resp = self.client.get_html(url)
276-
self.assertEqual(resp.status_code, status_code) # noqa: PT009
275+
self.assertEqual(resp.status_code, import_status_code) # noqa: PT009
277276

278277
url = '/import_status/{course_key}/{filename}'.format(
279278
course_key=course_key,
280279
filename='xyz.tar.gz'
281280
)
282281
resp = self.client.get_html(url)
283-
self.assertEqual(resp.status_code, status_code) # noqa: PT009
282+
self.assertEqual(resp.status_code, import_status_handler_code) # noqa: PT009

cms/djangoapps/contentstore/utils.py

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,8 @@
4444
use_new_advanced_settings_page,
4545
use_new_certificates_page,
4646
use_new_course_team_page,
47-
use_new_export_page,
4847
use_new_grading_page,
4948
use_new_group_configurations_page,
50-
use_new_import_page,
5149
use_new_schedule_details_page,
5250
use_new_unit_page,
5351
)
@@ -368,26 +366,20 @@ def get_import_url(course_locator) -> str:
368366
"""
369367
Gets course authoring microfrontend URL for import page view.
370368
"""
371-
import_url = None
372-
if use_new_import_page(course_locator):
373-
mfe_base_url = get_course_authoring_url(course_locator)
374-
course_mfe_url = f'{mfe_base_url}/course/{course_locator}/import'
375-
if mfe_base_url:
376-
import_url = course_mfe_url
377-
return import_url
369+
mfe_base_url = get_course_authoring_url(course_locator)
370+
if mfe_base_url:
371+
return f'{mfe_base_url}/course/{course_locator}/import'
372+
return ''
378373

379374

380375
def get_export_url(course_locator) -> str:
381376
"""
382377
Gets course authoring microfrontend URL for export page view.
383378
"""
384-
export_url = None
385-
if use_new_export_page(course_locator):
386-
mfe_base_url = get_course_authoring_url(course_locator)
387-
course_mfe_url = f'{mfe_base_url}/course/{course_locator}/export'
388-
if mfe_base_url:
389-
export_url = course_mfe_url
390-
return export_url
379+
mfe_base_url = get_course_authoring_url(course_locator)
380+
if mfe_base_url:
381+
return f'{mfe_base_url}/course/{course_locator}/export'
382+
return ''
391383

392384

393385
def get_optimizer_url(course_locator) -> str:

cms/djangoapps/contentstore/views/tests/test_import_export.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
from django.core.exceptions import SuspiciousOperation
2424
from django.core.files.storage import FileSystemStorage
2525
from django.test.utils import override_settings
26-
from edx_toggles.toggles.testutils import override_waffle_flag
2726
from milestones.tests.utils import MilestonesTestCaseMixin
2827
from opaque_keys.edx.locator import LibraryLocator
2928
from openedx_authz.constants.roles import COURSE_DATA_RESEARCHER, COURSE_STAFF
@@ -34,7 +33,6 @@
3433
from user_tasks.models import UserTaskStatus
3534

3635
from cms.djangoapps.contentstore import errors as import_error
37-
from cms.djangoapps.contentstore import toggles
3836
from cms.djangoapps.contentstore.api.tests.base import BaseCourseViewTest
3937
from cms.djangoapps.contentstore.storage import course_import_export_storage
4038
from cms.djangoapps.contentstore.tests.test_libraries import LibraryTestCase
@@ -754,15 +752,6 @@ def setUp(self):
754752
self.url = reverse_course_url('export_handler', self.course.id)
755753
self.status_url = reverse_course_url('export_status_handler', self.course.id)
756754

757-
@override_waffle_flag(toggles.LEGACY_STUDIO_EXPORT, True)
758-
def test_export_html(self):
759-
"""
760-
Get the HTML for the page.
761-
"""
762-
resp = self.client.get_html(self.url)
763-
self.assertEqual(resp.status_code, 200) # noqa: PT009
764-
self.assertContains(resp, "Export My Course Content")
765-
766755
def test_export_json_unsupported(self):
767756
"""
768757
JSON is unsupported.

0 commit comments

Comments
 (0)