fix: Apply suggestions from code review

Don't add a new reference to the old FEATURES dictionary and drop an unncessary test.

Co-authored-by: Taylor Payne <[email protected]>
Co-authored-by: Feanil Patel <[email protected]>

Author: feanil

common/djangoapps/third_party_auth/tests/test_settings.py

@@ -68,37 +68,3 @@ def test_social_auth_clean_usernames_default(self):
         # Note: SOCIAL_AUTH_CLEAN_USERNAMES is a Derived setting, computed at settings load time.
         # This test verifies the default behavior (unicode usernames disabled).
         assert settings.SOCIAL_AUTH_CLEAN_USERNAMES is True
-
-    def test_social_auth_clean_usernames_computation(self):
-        """
-        Verify the SOCIAL_AUTH_CLEAN_USERNAMES computation logic.
-
-        SOCIAL_AUTH_CLEAN_USERNAMES is a Derived setting that is computed at settings load time,
-        so we can't use @override_settings to test both cases. Instead, we test the computation
-        logic directly to ensure it correctly inverts the ENABLE_UNICODE_USERNAME feature flag.
-        """
-        # The logic in lms/envs/common.py is:
-        # SOCIAL_AUTH_CLEAN_USERNAMES = Derived(
-        #     lambda settings: not settings.FEATURES.get('ENABLE_UNICODE_USERNAME', False)
-        # )
-        # We replicate and test that logic here.
-
-        class FakeSettings:
-            """Fake settings object for testing the Derived computation."""
-            def __init__(self, features):
-                self.FEATURES = features
-
-        # When ENABLE_UNICODE_USERNAME is False (default), SOCIAL_AUTH_CLEAN_USERNAMES should be True
-        fake_settings = FakeSettings({'ENABLE_UNICODE_USERNAME': False})
-        result = not fake_settings.FEATURES.get('ENABLE_UNICODE_USERNAME', False)
-        assert result is True
-
-        # When ENABLE_UNICODE_USERNAME is True, SOCIAL_AUTH_CLEAN_USERNAMES should be False
-        fake_settings = FakeSettings({'ENABLE_UNICODE_USERNAME': True})
-        result = not fake_settings.FEATURES.get('ENABLE_UNICODE_USERNAME', False)
-        assert result is False
-
-        # When ENABLE_UNICODE_USERNAME is not set, should default to False, so result is True
-        fake_settings = FakeSettings({})
-        result = not fake_settings.FEATURES.get('ENABLE_UNICODE_USERNAME', False)
-        assert result is True

lms/envs/common.py

@@ -332,7 +332,7 @@
 
 # Computed setting: disable clean usernames check when unicode usernames are enabled
 SOCIAL_AUTH_CLEAN_USERNAMES = Derived(
-    lambda settings: not settings.FEATURES.get('ENABLE_UNICODE_USERNAME', False)
+    lambda settings: not settings.ENABLE_UNICODE_USERNAME
 )
 
 # Social auth pipeline for third-party authentication.