Skip to content

Commit 5119b1d

Browse files
fix: fixed toggles
1 parent 006bc30 commit 5119b1d

3 files changed

Lines changed: 8 additions & 29 deletions

File tree

cms/djangoapps/contentstore/rest_api/v1/serializers/course_waffle_flags.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,15 @@ def get_use_new_custom_pages(self, obj):
6767

6868
def get_use_new_schedule_details_page(self, obj):
6969
"""
70-
Method to get the use_new_schedule_details_page switch
70+
Method to indicate whether we should use the new schedule details page.
71+
72+
This used to be based on a waffle flag but the flag is being removed so we
73+
default it to true for now until we can remove the need for it from the consumers
74+
of this serializer and the related APIs.
75+
76+
See https://github.com/openedx/edx-platform/issues/36275
7177
"""
72-
course_key = self.get_course_key()
73-
return toggles.use_new_schedule_details_page(course_key)
78+
return True
7479

7580
def get_use_new_advanced_settings_page(self, obj):
7681
"""

cms/djangoapps/contentstore/toggles.py

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -180,23 +180,6 @@ def use_react_markdown_editor(course_key):
180180

181181
# .. toggle_name: legacy_studio.schedule_details
182182
# .. toggle_implementation: WaffleFlag
183-
# .. toggle_default: False
184-
# .. toggle_description: Temporarily fall back to the old Studio Schedule & Details page.
185-
# .. toggle_use_cases: temporary
186-
# .. toggle_creation_date: 2025-03-14
187-
# .. toggle_target_removal_date: 2025-09-14
188-
# .. toggle_tickets: https://github.com/openedx/edx-platform/issues/36275
189-
# .. toggle_warning: In Ulmo, this toggle will be removed. Only the new (React-based) experience will be available.
190-
LEGACY_STUDIO_SCHEDULE_DETAILS = CourseWaffleFlag('legacy_studio.schedule_details', __name__)
191-
192-
193-
def use_new_schedule_details_page(course_key):
194-
"""
195-
Returns a boolean if new studio schedule and details mfe is enabled
196-
"""
197-
return not LEGACY_STUDIO_SCHEDULE_DETAILS.is_enabled(course_key)
198-
199-
200183
# .. toggle_name: legacy_studio.advanced_settings
201184
# .. toggle_implementation: WaffleFlag
202185
# .. toggle_default: False

cms/templates/widgets/header.html

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ <h1 class="branding">
3737
import_url = reverse('import_handler', kwargs={'course_key_string': str(course_key)})
3838
course_info_url = reverse('course_info_handler', kwargs={'course_key_string': str(course_key)})
3939
export_url = reverse('export_handler', kwargs={'course_key_string': str(course_key)})
40-
settings_url = reverse('settings_handler', kwargs={'course_key_string': str(course_key)})
4140
grading_url = reverse('grading_handler', kwargs={'course_key_string': str(course_key)})
4241
advanced_settings_url = reverse('advanced_settings_handler', kwargs={'course_key_string': str(course_key)})
4342
tabs_url = reverse('tabs_handler', kwargs={'course_key_string': str(course_key)})
@@ -46,7 +45,6 @@ <h1 class="branding">
4645
certificates_url = reverse('certificates_list_handler', kwargs={'course_key_string': str(course_key)})
4746
checklists_url = reverse('checklists_handler', kwargs={'course_key_string': str(course_key)})
4847
pages_and_resources_mfe_enabled = ENABLE_PAGES_AND_RESOURCES_MICROFRONTEND.is_enabled(context_course.id)
49-
schedule_details_mfe_enabled = toggles.use_new_schedule_details_page(context_course.id)
5048
grading_mfe_enabled = toggles.use_new_grading_page(context_course.id)
5149
course_team_mfe_enabled = toggles.use_new_course_team_page(context_course.id)
5250
advanced_settings_mfe_enabled = toggles.use_new_advanced_settings_page(context_course.id)
@@ -118,16 +116,9 @@ <h3 class="title"><span class="label"><span class="label-prefix sr">${_("Course"
118116
<div class="wrapper wrapper-nav-sub">
119117
<div class="nav-sub">
120118
<ul>
121-
% if not schedule_details_mfe_enabled:
122-
<li class="nav-item nav-course-settings-schedule">
123-
<a href="${settings_url}">${_("Schedule & Details")}</a>
124-
</li>
125-
% endif
126-
% if schedule_details_mfe_enabled:
127119
<li class="nav-item nav-course-settings-schedule">
128120
<a href="${get_schedule_details_url(course_key)}">${_("Schedule & Details")}</a>
129121
</li>
130-
% endif
131122
% if not grading_mfe_enabled:
132123
<li class="nav-item nav-course-settings-grading">
133124
<a href="${grading_url}">${_("Grading")}</a>

0 commit comments

Comments
 (0)