feat!: remove last calls to cs_comments_service (#37376)

This removes the last remaining code that called out to the
cs_comments_service. All forums backend logic now uses the v2 API from
the forum repo (https://github.com/openedx/forum). This does NOT remove
MongoDB support.

This also implements the endpoint to retrieve all comments for a user
using the new forum backend. This is not actually called from any known
frontend code, but it has not been formally deprecated as an endpoint,
and therefore needs to be supported.

As part of the cleanup, the ENABLE_FORUM_V2 course waffle flag has also
been removed, along with all remaining switching logic that used to
route between the Python API in the forum repo and service calls to the
cs_comments_service Ruby service.

Other endpoints affected (switching logic removed):

* get course commentable counts
* get/update course user stats
* update comment/thread/user
* delete thread (implementation moved to forum repo)
* follow
* retire user

This is part of the following overall DEPR ticket:
  https://github.com/openedx/cs_comments_service/issues/437

Author: taimoor-ahmed-1

lms/djangoapps/discussion/django_comment_client/base/tests.py

@@ -60,38 +60,36 @@ class CohortedTopicGroupIdTestMixin(GroupIdAssertionMixin):
     Provides test cases to verify that views pass the correct `group_id` to
     the comments service when requesting content in cohorted discussions.
     """
-    def call_view(self, mock_is_forum_v2_enabled, mock_request, commentable_id, user, group_id, pass_group_id=True):
+    def call_view(self, mock_request, commentable_id, user, group_id, pass_group_id=True):
         """
         Call the view for the implementing test class, constructing a request
         from the parameters.
         """
         pass  # lint-amnesty, pylint: disable=unnecessary-pass
 
-    def test_cohorted_topic_student_without_group_id(self, mock_is_forum_v2_enabled, mock_request):
-        self.call_view(mock_is_forum_v2_enabled, mock_request, "cohorted_topic", self.student, '', pass_group_id=False)
+    def test_cohorted_topic_student_without_group_id(self, mock_request):
+        self.call_view(mock_request, "cohorted_topic", self.student, '', pass_group_id=False)
         self._assert_comments_service_called_with_group_id(mock_request, self.student_cohort.id)
 
-    def test_cohorted_topic_student_none_group_id(self, mock_is_forum_v2_enabled, mock_request):
-        self.call_view(mock_is_forum_v2_enabled, mock_request, "cohorted_topic", self.student, "")
+    def test_cohorted_topic_student_none_group_id(self, mock_request):
+        self.call_view(mock_request, "cohorted_topic", self.student, "")
         self._assert_comments_service_called_with_group_id(mock_request, self.student_cohort.id)
 
-    def test_cohorted_topic_student_with_own_group_id(self, mock_is_forum_v2_enabled, mock_request):
-        self.call_view(mock_is_forum_v2_enabled, mock_request, "cohorted_topic", self.student, self.student_cohort.id)
+    def test_cohorted_topic_student_with_own_group_id(self, mock_request):
+        self.call_view(mock_request, "cohorted_topic", self.student, self.student_cohort.id)
         self._assert_comments_service_called_with_group_id(mock_request, self.student_cohort.id)
 
-    def test_cohorted_topic_student_with_other_group_id(self, mock_is_forum_v2_enabled, mock_request):
+    def test_cohorted_topic_student_with_other_group_id(self, mock_request):
         self.call_view(
-            mock_is_forum_v2_enabled,
             mock_request,
             "cohorted_topic",
             self.student,
             self.moderator_cohort.id
         )
         self._assert_comments_service_called_with_group_id(mock_request, self.student_cohort.id)
 
-    def test_cohorted_topic_moderator_without_group_id(self, mock_is_forum_v2_enabled, mock_request):
+    def test_cohorted_topic_moderator_without_group_id(self, mock_request):
         self.call_view(
-            mock_is_forum_v2_enabled,
             mock_request,
             "cohorted_topic",
             self.moderator,
@@ -100,36 +98,34 @@ def test_cohorted_topic_moderator_without_group_id(self, mock_is_forum_v2_enable
         )
         self._assert_comments_service_called_without_group_id(mock_request)
 
-    def test_cohorted_topic_moderator_none_group_id(self, mock_is_forum_v2_enabled, mock_request):
-        self.call_view(mock_is_forum_v2_enabled, mock_request, "cohorted_topic", self.moderator, "")
+    def test_cohorted_topic_moderator_none_group_id(self, mock_request):
+        self.call_view(mock_request, "cohorted_topic", self.moderator, "")
         self._assert_comments_service_called_without_group_id(mock_request)
 
-    def test_cohorted_topic_moderator_with_own_group_id(self, mock_is_forum_v2_enabled, mock_request):
+    def test_cohorted_topic_moderator_with_own_group_id(self, mock_request):
         self.call_view(
-            mock_is_forum_v2_enabled,
             mock_request,
             "cohorted_topic",
             self.moderator,
             self.moderator_cohort.id
         )
         self._assert_comments_service_called_with_group_id(mock_request, self.moderator_cohort.id)
 
-    def test_cohorted_topic_moderator_with_other_group_id(self, mock_is_forum_v2_enabled, mock_request):
+    def test_cohorted_topic_moderator_with_other_group_id(self, mock_request):
         self.call_view(
-            mock_is_forum_v2_enabled,
             mock_request,
             "cohorted_topic",
             self.moderator,
             self.student_cohort.id
         )
         self._assert_comments_service_called_with_group_id(mock_request, self.student_cohort.id)
 
-    def test_cohorted_topic_moderator_with_invalid_group_id(self, mock_is_forum_v2_enabled, mock_request):
+    def test_cohorted_topic_moderator_with_invalid_group_id(self, mock_request):
         invalid_id = self.student_cohort.id + self.moderator_cohort.id
-        response = self.call_view(mock_is_forum_v2_enabled, mock_request, "cohorted_topic", self.moderator, invalid_id)  # lint-amnesty, pylint: disable=assignment-from-no-return
+        response = self.call_view(mock_request, "cohorted_topic", self.moderator, invalid_id)  # lint-amnesty, pylint: disable=assignment-from-no-return
         assert response.status_code == 500
 
-    def test_cohorted_topic_enrollment_track_invalid_group_id(self, mock_is_forum_v2_enabled, mock_request):
+    def test_cohorted_topic_enrollment_track_invalid_group_id(self, mock_request):
         CourseModeFactory.create(course_id=self.course.id, mode_slug=CourseMode.AUDIT)
         CourseModeFactory.create(course_id=self.course.id, mode_slug=CourseMode.VERIFIED)
         discussion_settings = CourseDiscussionSettings.get(self.course.id)
@@ -140,7 +136,7 @@ def test_cohorted_topic_enrollment_track_invalid_group_id(self, mock_is_forum_v2
         })
 
         invalid_id = -1000
-        response = self.call_view(mock_is_forum_v2_enabled, mock_request, "cohorted_topic", self.moderator, invalid_id)  # lint-amnesty, pylint: disable=assignment-from-no-return
+        response = self.call_view(mock_request, "cohorted_topic", self.moderator, invalid_id)  # lint-amnesty, pylint: disable=assignment-from-no-return
         assert response.status_code == 500
 
 
@@ -149,16 +145,15 @@ class NonCohortedTopicGroupIdTestMixin(GroupIdAssertionMixin):
     Provides test cases to verify that views pass the correct `group_id` to
     the comments service when requesting content in non-cohorted discussions.
     """
-    def call_view(self, mock_is_forum_v2_enabled, mock_request, commentable_id, user, group_id, pass_group_id=True):
+    def call_view(self, mock_request, commentable_id, user, group_id, pass_group_id=True):
         """
         Call the view for the implementing test class, constructing a request
         from the parameters.
         """
         pass  # lint-amnesty, pylint: disable=unnecessary-pass
 
-    def test_non_cohorted_topic_student_without_group_id(self, mock_is_forum_v2_enabled, mock_request):
+    def test_non_cohorted_topic_student_without_group_id(self, mock_request):
         self.call_view(
-            mock_is_forum_v2_enabled,
             mock_request,
             "non_cohorted_topic",
             self.student,
@@ -167,33 +162,30 @@ def test_non_cohorted_topic_student_without_group_id(self, mock_is_forum_v2_enab
         )
         self._assert_comments_service_called_without_group_id(mock_request)
 
-    def test_non_cohorted_topic_student_none_group_id(self, mock_is_forum_v2_enabled, mock_request):
-        self.call_view(mock_is_forum_v2_enabled, mock_request, "non_cohorted_topic", self.student, '')
+    def test_non_cohorted_topic_student_none_group_id(self, mock_request):
+        self.call_view(mock_request, "non_cohorted_topic", self.student, '')
         self._assert_comments_service_called_without_group_id(mock_request)
 
-    def test_non_cohorted_topic_student_with_own_group_id(self, mock_is_forum_v2_enabled, mock_request):
+    def test_non_cohorted_topic_student_with_own_group_id(self, mock_request):
         self.call_view(
-            mock_is_forum_v2_enabled,
             mock_request,
             "non_cohorted_topic",
             self.student,
             self.student_cohort.id
         )
         self._assert_comments_service_called_without_group_id(mock_request)
 
-    def test_non_cohorted_topic_student_with_other_group_id(self, mock_is_forum_v2_enabled, mock_request):
+    def test_non_cohorted_topic_student_with_other_group_id(self, mock_request):
         self.call_view(
-            mock_is_forum_v2_enabled,
             mock_request,
             "non_cohorted_topic",
             self.student,
             self.moderator_cohort.id
         )
         self._assert_comments_service_called_without_group_id(mock_request)
 
-    def test_non_cohorted_topic_moderator_without_group_id(self, mock_is_forum_v2_enabled, mock_request):
+    def test_non_cohorted_topic_moderator_without_group_id(self, mock_request):
         self.call_view(
-            mock_is_forum_v2_enabled,
             mock_request,
             "non_cohorted_topic",
             self.moderator,
@@ -202,43 +194,41 @@ def test_non_cohorted_topic_moderator_without_group_id(self, mock_is_forum_v2_en
         )
         self._assert_comments_service_called_without_group_id(mock_request)
 
-    def test_non_cohorted_topic_moderator_none_group_id(self, mock_is_forum_v2_enabled, mock_request):
-        self.call_view(mock_is_forum_v2_enabled, mock_request, "non_cohorted_topic", self.moderator, '')
+    def test_non_cohorted_topic_moderator_none_group_id(self, mock_request):
+        self.call_view(mock_request, "non_cohorted_topic", self.moderator, '')
         self._assert_comments_service_called_without_group_id(mock_request)
 
-    def test_non_cohorted_topic_moderator_with_own_group_id(self, mock_is_forum_v2_enabled, mock_request):
+    def test_non_cohorted_topic_moderator_with_own_group_id(self, mock_request):
         self.call_view(
-            mock_is_forum_v2_enabled,
             mock_request,
             "non_cohorted_topic",
             self.moderator,
             self.moderator_cohort.id,
         )
         self._assert_comments_service_called_without_group_id(mock_request)
 
-    def test_non_cohorted_topic_moderator_with_other_group_id(self, mock_is_forum_v2_enabled, mock_request):
+    def test_non_cohorted_topic_moderator_with_other_group_id(self, mock_request):
         self.call_view(
-            mock_is_forum_v2_enabled,
             mock_request,
             "non_cohorted_topic",
             self.moderator,
             self.student_cohort.id,
         )
         self._assert_comments_service_called_without_group_id(mock_request)
 
-    def test_non_cohorted_topic_moderator_with_invalid_group_id(self, mock_is_forum_v2_enabled, mock_request):
+    def test_non_cohorted_topic_moderator_with_invalid_group_id(self, mock_request):
         invalid_id = self.student_cohort.id + self.moderator_cohort.id
-        self.call_view(mock_is_forum_v2_enabled, mock_request, "non_cohorted_topic", self.moderator, invalid_id)
+        self.call_view(mock_request, "non_cohorted_topic", self.moderator, invalid_id)
         self._assert_comments_service_called_without_group_id(mock_request)
 
-    def test_team_discussion_id_not_cohorted(self, mock_is_forum_v2_enabled, mock_request):
+    def test_team_discussion_id_not_cohorted(self, mock_request):
         team = CourseTeamFactory(
             course_id=self.course.id,
             topic_id='topic-id'
         )
 
         team.add_user(self.student)
-        self.call_view(mock_is_forum_v2_enabled, mock_request, team.discussion_topic_id, self.student, '')
+        self.call_view(mock_request, team.discussion_topic_id, self.student, '')
 
         self._assert_comments_service_called_without_group_id(mock_request)
 

lms/djangoapps/discussion/django_comment_client/base/tests_v2.py

@@ -17,13 +17,6 @@ def setUpClassAndForumMock(cls):
         """
         cls.mock_forum_api = mock.Mock()
 
-        # TODO: Remove this after moving all APIs
-        cls.flag_v2_patcher = mock.patch(
-            "openedx.core.djangoapps.discussions.config.waffle.ENABLE_FORUM_V2.is_enabled"
-        )
-        cls.mock_enable_forum_v2 = cls.flag_v2_patcher.start()
-        cls.mock_enable_forum_v2.return_value = True
-
         patch_targets = [
             "openedx.core.djangoapps.django_comment_common.comment_client.thread.forum_api",
             "openedx.core.djangoapps.django_comment_common.comment_client.comment.forum_api",
@@ -41,8 +34,6 @@ def setUpClassAndForumMock(cls):
     @classmethod
     def disposeForumMocks(cls):
         """Stop patches after tests complete."""
-        cls.flag_v2_patcher.stop()
-
         for patcher in cls.forum_api_patchers:
             patcher.stop()