Skip to content

Commit 2ba9b79

Browse files
authored
fix: Issues with get container children [FC-0083] (#36686)
* Fix published param to support strings * Add published_display_name to children response
1 parent 32e0082 commit 2ba9b79

6 files changed

Lines changed: 6 additions & 2 deletions

File tree

openedx/core/djangoapps/content_libraries/api/block_metadata.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ def from_component(cls, library_key, component, associated_collections=None):
5757
modified=draft.created,
5858
draft_version_num=draft.version_num,
5959
published_version_num=published.version_num if published else None,
60+
published_display_name=published.title if published else None,
6061
last_published=None if last_publish_log is None else last_publish_log.published_at,
6162
published_by=published_by,
6263
last_draft_created=last_draft_created,

openedx/core/djangoapps/content_libraries/api/containers.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ class ContainerMetadata(PublishableItem):
110110
container_key: LibraryContainerLocator
111111
container_type: ContainerType
112112
container_pk: int
113-
published_display_name: str | None
114113

115114
@classmethod
116115
def from_container(cls, library_key, container: Container, associated_collections=None):

openedx/core/djangoapps/content_libraries/api/libraries.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,7 @@ class PublishableItem(LibraryItem):
191191
"""
192192
draft_version_num: int
193193
published_version_num: int | None = None
194+
published_display_name: str | None
194195
last_published: datetime | None = None
195196
# The username of the user who last published this.
196197
published_by: str = ""

openedx/core/djangoapps/content_libraries/rest_api/containers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ def get(self, request, container_key: LibraryContainerLocator):
178178
}
179179
]
180180
"""
181-
published = request.GET.get('published', False)
181+
published = request.GET.get('published', 'false').lower() == 'true'
182182
api.require_permission_for_library_key(
183183
container_key.lib_key,
184184
request.user,

openedx/core/djangoapps/content_libraries/rest_api/serializers.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ class PublishableItemSerializer(serializers.Serializer):
138138
"""
139139
id = serializers.SerializerMethodField()
140140
display_name = serializers.CharField()
141+
published_display_name = serializers.CharField(required=False)
141142
tags_count = serializers.IntegerField(read_only=True)
142143
last_published = serializers.DateTimeField(format=DATETIME_FORMAT, read_only=True)
143144
published_by = serializers.CharField(read_only=True)

openedx/core/djangoapps/content_libraries/tests/test_content_libraries.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,7 @@ def test_library_blocks(self): # pylint: disable=too-many-statements
327327
block_data["has_unpublished_changes"] = False
328328
block_data["last_published"] = publish_date.isoformat().replace('+00:00', 'Z')
329329
block_data["published_by"] = "Bob"
330+
block_data["published_display_name"] = "Blank Problem"
330331
self.assertDictContainsEntries(self._get_library_block(block_id), block_data)
331332
assert self._get_library_blocks(lib_id)['results'] == [block_data]
332333

@@ -440,6 +441,7 @@ def test_library_blocks_studio_view(self):
440441
block_data["has_unpublished_changes"] = False
441442
block_data["last_published"] = publish_date.isoformat().replace('+00:00', 'Z')
442443
block_data["published_by"] = "Bob"
444+
block_data["published_display_name"] = "Text"
443445
self.assertDictContainsEntries(self._get_library_block(block_id), block_data)
444446
assert self._get_library_blocks(lib_id)['results'] == [block_data]
445447

0 commit comments

Comments
 (0)