fixup! fix: refactor assets, settings/main, pages/index specs to not call AjaxHelpers inside it()

Author: feanil

cms/static/js/spec/views/assets_spec.js

@@ -11,11 +11,6 @@ function($, sinon, AjaxHelpers, URI, AssetsView, AssetCollection, ViewHelpers) {
         uploadModalTpl = readFixtures('asset-upload-modal.underscore');
 
         beforeEach(function() {
-            xhrFactory = sinon.useFakeXMLHttpRequest();
-            requests = [];
-            requests.currentIndex = 0;
-            requests.restore = function() { xhrFactory.restore(); };
-            xhrFactory.onCreate = function(req) { requests.push(req); };
             setFixtures($('<script>', {id: 'asset-library-tpl', type: 'text/template'}).text(assetLibraryTpl));
             appendSetFixtures($('<script>', {id: 'asset-tpl', type: 'text/template'}).text(assetTpl));
             appendSetFixtures(uploadModalTpl);
@@ -36,7 +31,14 @@ function($, sinon, AjaxHelpers, URI, AssetsView, AssetCollection, ViewHelpers) {
                 el: $('#asset_table_body')
             });
 
-            assetsView.render();
+            // Install fake XHR after creating assetsView so that the initial setPage(1)
+            // fired by createPagingView() during initialize() is not captured. Tests that
+            // need a specific page state drive it themselves via setPage() + respond.
+            xhrFactory = sinon.useFakeXMLHttpRequest();
+            requests = [];
+            requests.currentIndex = 0;
+            requests.restore = function() { xhrFactory.restore(); };
+            xhrFactory.onCreate = function(req) { requests.push(req); };
         });
 
         afterEach(function() {