Skip to content

Commit 0b14be6

Browse files
dwong2708feanil
authored andcommitted
fix: set correct final grade value for ORA summary endpoint
1 parent 4a3e78e commit 0b14be6

3 files changed

Lines changed: 29 additions & 3 deletions

File tree

lms/djangoapps/instructor/ora.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
'self': 0,
1313
'waiting': 0,
1414
'staff': 0,
15-
'final_grade_received': 0,
15+
'done': 0,
1616
}
1717

1818

@@ -93,5 +93,5 @@ def get_ora_summary(course):
9393
summary['self'] += item['self']
9494
summary['waiting'] += item['waiting']
9595
summary['staff'] += item['staff']
96-
summary['final_grade_received'] += item['final_grade_received']
96+
summary['final_grade_received'] += item['done']
9797
return summary

lms/djangoapps/instructor/tests/test_api_v2.py

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1055,6 +1055,32 @@ def _get_url(self, course_id=None):
10551055
course_id = str(self.course_key)
10561056
return reverse(self.view_name, kwargs={'course_id': course_id})
10571057

1058+
@patch('openassessment.data.OraAggregateData.collect_ora2_responses')
1059+
def test_get_ora_summary_with_final_grades(self, mock_get_responses):
1060+
"""Test retrieving the ORA summary with final grades."""
1061+
1062+
mock_get_responses.return_value = {
1063+
self.ora_usage_key: {
1064+
"done": 3,
1065+
"total": 2,
1066+
"total_responses": 0,
1067+
"training": 0,
1068+
"peer": 0,
1069+
"self": 0,
1070+
"waiting": 0,
1071+
"staff": 0,
1072+
}
1073+
}
1074+
1075+
response = self.client.get(
1076+
self._get_url()
1077+
)
1078+
1079+
assert response.status_code == 200
1080+
data = response.data
1081+
1082+
assert data['final_grade_received'] == 3
1083+
10581084
def test_get_ora_summary(self):
10591085
"""Test retrieving the ORA summary."""
10601086

lms/djangoapps/instructor/views/serializers_v2.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,7 @@ class ORASerializer(serializers.Serializer):
432432
self = serializers.IntegerField()
433433
waiting = serializers.IntegerField()
434434
staff = serializers.IntegerField()
435-
final_grade_received = serializers.IntegerField()
435+
final_grade_received = serializers.IntegerField(source="done")
436436

437437

438438
class ORASummarySerializer(serializers.Serializer):

0 commit comments

Comments
 (0)