Skip to content

Commit 053abe3

Browse files
authored
fix: django52 tightened consistency around delete ordering and signal/delete() method invocation. (#37250)
1 parent 109f5e0 commit 053abe3

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

lms/djangoapps/teams/models.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,8 +293,10 @@ def save(self, *args, **kwargs): # lint-amnesty, pylint: disable=arguments-diff
293293

294294
def delete(self, *args, **kwargs): # lint-amnesty, pylint: disable=arguments-differ, signature-differs
295295
"""Recompute the related team's team_size after deleting a membership"""
296+
team = self.team # store reference before deleting
296297
super().delete(*args, **kwargs)
297-
self.team.reset_team_size()
298+
if team and team.pk: # only reset size if team still exists
299+
team.reset_team_size()
298300

299301
@classmethod
300302
def get_memberships(cls, username=None, course_ids=None, team_ids=None):

0 commit comments

Comments
 (0)