Skip to content

[FC-0099] refactor: use content library toggle only when in CMS#129

Merged
mariajgrimaldi merged 2 commits intomainfrom
MJG/use-toggle-only-in-cms
Oct 30, 2025
Merged

[FC-0099] refactor: use content library toggle only when in CMS#129
mariajgrimaldi merged 2 commits intomainfrom
MJG/use-toggle-only-in-cms

Conversation

@mariajgrimaldi
Copy link
Copy Markdown
Member

@mariajgrimaldi mariajgrimaldi commented Oct 30, 2025

Description

A breaking error was found while building the master branch with the latest version of the library so this needs fixed ASAP.

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 30, 2025
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @mariajgrimaldi!

This repository is currently maintained by @openedx/committers-openedx-authz.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Oct 30, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Oct 30, 2025
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/use-toggle-only-in-cms branch from fd41363 to 3c1e6fd Compare October 30, 2025 11:24
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/use-toggle-only-in-cms branch from 3c1e6fd to 0977bdb Compare October 30, 2025 11:26
@mariajgrimaldi mariajgrimaldi added the release blocker Blocks the upcoming release (fix needed) label Oct 30, 2025
@mariajgrimaldi mariajgrimaldi moved this to Ready for review in RBAC AuthZ Board Oct 30, 2025
@mariajgrimaldi
Copy link
Copy Markdown
Member Author

I'm currently testing a brand new build to ensure this is working.

@mariajgrimaldi mariajgrimaldi merged commit fea481a into main Oct 30, 2025
13 of 14 checks passed
@mariajgrimaldi mariajgrimaldi deleted the MJG/use-toggle-only-in-cms branch October 30, 2025 13:02
@github-project-automation github-project-automation Bot moved this from Ready for review to Done in RBAC AuthZ Board Oct 30, 2025
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U release blocker Blocks the upcoming release (fix needed)

Projects

Archived in project
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants