[FC-0099] feat: use synced enforcer#103
Conversation
|
Thanks for the pull request, @BryanttV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
I also evaluated adding a cache to the
My main concern with caching is how long we consider it acceptable to store the data. I initially set a default of |
bmtcril
left a comment
There was a problem hiding this comment.
Overall looks good, can you add a test that confirms the policy changes show up without a reload? Something that sets the reload time to like 1 second, and makes a change, then confirms the change appears?
ee1d150 to
6a73b4d
Compare
bmtcril
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
…BaseRolesTestCase
…w and RoleListView
6a73b4d to
83a5c30
Compare
6c6e0e3 to
467f8e3
Compare
6913a7b to
73f7d51
Compare
…to-load policy thread
Description
This PR replaces the use of
FastEnforcerwithSyncEnforcer. TheSyncedEnforceris based on theEnforcerand provides synchronized access. It is thread-safe. With this new enforcer, the entire policy is automatically loaded every X amount of time, configurable using theCASBIN_AUTO_LOAD_POLICY_INTERVALsetting.Supporting Information
Testing Instructions
Using Tutor:
tutor dev exec lms python manage.py lms migratetutor dev exec lms python manage.py lms load_policies{lms-domain}/api-docs/#/authzMerge Checklist
Check off if complete or not applicable: