squash!: Cleanup

Author: rodmgwgu

openedx_authz/api/roles.py

@@ -218,7 +218,7 @@ def assign_role_to_subject_in_scope(subject: SubjectData, role: RoleData, scope:
         )
         if not extended_rule:
             raise Exception("Failed to create ExtendedCasbinRule for the assignment")
-        
+
     # Invalidate policy cache to ensure changes are picked up
     AuthzEnforcer.invalidate_policy_cache()
     return True
@@ -247,7 +247,9 @@ def unassign_role_from_subject_in_scope(subject: SubjectData, role: RoleData, sc
         bool: True if the role was unassigned successfully, False otherwise.
     """
     enforcer = AuthzEnforcer.get_enforcer()
-    success = enforcer.delete_roles_for_user_in_domain(subject.namespaced_key, role.namespaced_key, scope.namespaced_key)
+    success = enforcer.delete_roles_for_user_in_domain(
+        subject.namespaced_key, role.namespaced_key, scope.namespaced_key
+    )
     # Invalidate policy cache to ensure changes are picked up
     AuthzEnforcer.invalidate_policy_cache()
     return success

openedx_authz/rest_api/v1/permissions.py

@@ -5,7 +5,6 @@
 from rest_framework.permissions import BasePermission
 
 from openedx_authz import api
-from openedx_authz.engine.enforcer import AuthzEnforcer
 
 
 class PermissionMeta(type(BasePermission)):
@@ -183,7 +182,6 @@ def has_permission(self, request, view) -> bool:
         """
         if request.user.is_superuser or request.user.is_staff:
             return True
-        # AuthzEnforcer.get_enforcer().load_policy()
         return self._get_permission_instance(request).has_permission(request, view)
 
     def has_object_permission(self, request, view, obj) -> bool:
@@ -200,7 +198,6 @@ def has_object_permission(self, request, view, obj) -> bool:
         """
         if request.user.is_superuser or request.user.is_staff:
             return True
-        # AuthzEnforcer.get_enforcer().load_policy()
         return self._get_permission_instance(request).has_object_permission(request, view, obj)
 
 

openedx_authz/rest_api/v1/views.py

@@ -16,7 +16,6 @@
 
 from openedx_authz import api
 from openedx_authz.constants import permissions
-from openedx_authz.engine.enforcer import AuthzEnforcer
 from openedx_authz.rest_api.data import RoleOperationError, RoleOperationStatus
 from openedx_authz.rest_api.decorators import authz_permissions, view_auth_classes
 from openedx_authz.rest_api.utils import (
@@ -103,7 +102,6 @@ class PermissionValidationMeView(APIView):
     )
     def post(self, request: HttpRequest) -> Response:
         """Validate one or more permissions for the authenticated user."""
-        # AuthzEnforcer.get_enforcer().load_policy()
 
         serializer = PermissionValidationSerializer(data=request.data, many=True)
         serializer.is_valid(raise_exception=True)