squash!: Apply suggestions

Author: rodmgwgu

openedx_authz/rest_api/utils.py

@@ -2,7 +2,6 @@
 
 from openedx_authz.api.data import (
     GLOBAL_SCOPE_WILDCARD,
-    RoleAssignmentData,
     ScopeData,
 )
 from openedx_authz.rest_api.data import AssignmentSortField, SearchField, SortField, SortOrder
@@ -97,15 +96,15 @@ def filter_users(users: list[dict], search: str | None, roles: list[str] | None)
 
 
 def sort_assignments(
-    assignments: list[RoleAssignmentData],
+    assignments: list[dict],
     sort_by: AssignmentSortField = AssignmentSortField.ROLE,
     order: SortOrder = SortOrder.ASC,
-) -> list[RoleAssignmentData]:
+) -> list[dict]:
     """
     Sort role assignments by a given field and order.
 
     Args:
-        assignments (list[RoleAssignmentData]): The assignments to sort.
+        assignments (list[dict]): The assignments to sort.
         sort_by (SortField, optional): The field to sort by. Defaults to AssignmentSortField.ROLE.
         order (SortOrder, optional): The order to sort by. Defaults to SortOrder.ASC.
 
@@ -114,7 +113,7 @@ def sort_assignments(
         ValueError: If the sort order is invalid.
 
     Returns:
-        list[RoleAssignmentData]: The sorted assignments.
+        list[dict]: The sorted assignments.
     """
     if sort_by not in AssignmentSortField.values():
         raise ValueError(f"Invalid field: '{sort_by}'. Must be one of {AssignmentSortField.values()}")

openedx_authz/tests/rest_api/test_views.py

@@ -1318,20 +1318,23 @@ class TestTeamMemberAssignmentsAPIView(ViewTestMixin):
         lib:Org3:LIB3 → admin_3 (library_admin), regular_5 (library_admin), regular_6 (library_author),
                         regular_7 (library_contributor), regular_8 (library_user)
 
-    URL: /authz/v1/users/<username>/assignments
+    URL: /api/authz/v1/users/<username>/assignments/
     Response fields per item: is_superadmin, role, org, scope, permission_count
 
     Superadmin entry:
-        admin_1..3 are staff/superusers. Querying any of them adds one entry
+        admin_1..3 are staff/superusers. Querying any of them always adds one
         SuperAdminAssignmentData entry: role="django.superuser" (or "django.staff"),
         org="*", scope="*", permission_count=None, is_superadmin=True.
         This entry is always included regardless of org/role filters, since those
         filters are applied only to the role assignments, not to the superadmin entry.
 
     Visibility via filter_allowed_assignments:
-        - Staff/superuser: sees all assignments for any user
-        - regular_1 (library_user in Org1:LIB1): sees only Org1:LIB1 assignments
-        - regular_9 (no assignments): sees nothing for any user
+        - Staff/superuser: sees all role assignments for any user, plus the superadmin
+          entry when the target is a superadmin.
+        - regular_1 (library_user in Org1:LIB1): sees only Org1:LIB1 role assignments,
+          plus the superadmin entry when the target is a superadmin.
+        - regular_9 (no assignments): sees no role assignments for any user, but still
+          sees the superadmin entry when the target is a superadmin.
     """
 
     def setUp(self):