refactor: address PR reviews

mariajgrimaldi · BryanttV · commit d43100b4bc19 · 2026-04-09T18:05:35.000-05:00
diff --git a/openedx_authz/engine/utils.py b/openedx_authz/engine/utils.py
@@ -339,8 +339,7 @@ def migrate_authz_to_legacy_course_roles(
         role_assignments = [
             role_assignment
             for role_assignment in role_assignments
-            if isinstance(role_assignment.scope, CourseOverviewData)
-            and role_assignment.scope.external_key in course_id_list
+            if role_assignment.scope.course_id in course_id_list
         ]
 
     roles_with_errors = []

Original file line number	Diff line number	Diff line change
`@@ -339,8 +339,7 @@ def migrate_authz_to_legacy_course_roles(`
`339`	`339`	`role_assignments = [`
`340`	`340`	`role_assignment`
`341`	`341`	`for role_assignment in role_assignments`
`342`		`- if isinstance(role_assignment.scope, CourseOverviewData)`
`343`		`- and role_assignment.scope.external_key in course_id_list`
	`342`	`+ if role_assignment.scope.course_id in course_id_list`
`344`	`343`	`]`
`345`	`344`
`346`	`345`	`roles_with_errors = []`