refactor: drop black changes for not modified files

Author: mariajgrimaldi

openedx_authz/tests/test_commands.py

@@ -12,11 +12,7 @@
 from django.core.management.base import CommandError
 
 from openedx_authz.management.commands.enforcement import Command as EnforcementCommand
-from openedx_authz.tests.test_utils import (
-    make_action_key,
-    make_scope_key,
-    make_user_key,
-)
+from openedx_authz.tests.test_utils import make_action_key, make_scope_key, make_user_key
 
 
 # pylint: disable=protected-access
@@ -46,10 +42,7 @@ def test_requires_policy_file_argument(self):
         with self.assertRaises(CommandError) as ctx:
             call_command("enforcement")
 
-        self.assertEqual(
-            "Error: the following arguments are required: --policy-file-path",
-            str(ctx.exception),
-        )
+        self.assertEqual("Error: the following arguments are required: --policy-file-path", str(ctx.exception))
 
     def test_policy_file_not_found_raises(self):
         """Test that command errors when the provided policy file does not exist."""
@@ -60,18 +53,13 @@ def test_policy_file_not_found_raises(self):
 
         self.assertEqual(f"Policy file not found: {non_existent}", str(ctx.exception))
 
-    @patch.object(
-        EnforcementCommand, "_get_file_path", return_value="invalid/path/model.conf"
-    )
+    @patch.object(EnforcementCommand, "_get_file_path", return_value="invalid/path/model.conf")
     def test_model_file_not_found_raises(self, mock_get_file_path: Mock):
         """Test that command errors when the provided model file does not exist."""
         with self.assertRaises(CommandError) as ctx:
             call_command("enforcement", policy_file_path=self.policy_file_path.name)
 
-        self.assertEqual(
-            f"Model file not found: {mock_get_file_path.return_value}",
-            str(ctx.exception),
-        )
+        self.assertEqual(f"Model file not found: {mock_get_file_path.return_value}", str(ctx.exception))
 
     @patch("openedx_authz.management.commands.enforcement.casbin.Enforcer")
     def test_error_creating_enforcer_raises(self, mock_enforcer_cls: Mock):
@@ -81,16 +69,11 @@ def test_error_creating_enforcer_raises(self, mock_enforcer_cls: Mock):
         with self.assertRaises(CommandError) as ctx:
             call_command("enforcement", policy_file_path=self.policy_file_path.name)
 
-        self.assertEqual(
-            "Error creating Casbin enforcer: Enforcer creation error",
-            str(ctx.exception),
-        )
+        self.assertEqual("Error creating Casbin enforcer: Enforcer creation error", str(ctx.exception))
 
     @patch("openedx_authz.management.commands.enforcement.casbin.Enforcer")
     @patch.object(EnforcementCommand, "_run_interactive_mode")
-    def test_successful_run_prints_summary(
-        self, mock_run_interactive: Mock, mock_enforcer_cls: Mock
-    ):
+    def test_successful_run_prints_summary(self, mock_run_interactive: Mock, mock_enforcer_cls: Mock):
         """
         Test successful command execution with policy file and interactive mode.
         When files exist, command should create enforcer, print counts, and call interactive loop.
@@ -107,11 +90,7 @@ def test_successful_run_prints_summary(
         mock_enforcer.get_named_grouping_policy.return_value = action_grouping
         mock_enforcer_cls.return_value = mock_enforcer
 
-        call_command(
-            "enforcement",
-            policy_file_path=self.policy_file_path.name,
-            stdout=self.buffer,
-        )
+        call_command("enforcement", policy_file_path=self.policy_file_path.name, stdout=self.buffer)
 
         output = self.buffer.getvalue()
         self.assertIn("Casbin Interactive Enforcement", output)
@@ -128,13 +107,8 @@ def test_run_interactive_mode_displays_help(self):
 
         example_text = f"Example: {make_user_key('alice')} {make_action_key('read')} {make_scope_key('org', 'OpenedX')}"
         self.assertIn("Interactive Mode", self.buffer.getvalue())
-        self.assertIn(
-            "Test custom enforcement requests interactively.", self.buffer.getvalue()
-        )
-        self.assertIn(
-            "Enter 'quit', 'exit', or 'q' to exit the interactive mode.",
-            self.buffer.getvalue(),
-        )
+        self.assertIn("Test custom enforcement requests interactively.", self.buffer.getvalue())
+        self.assertIn("Enter 'quit', 'exit', or 'q' to exit the interactive mode.", self.buffer.getvalue())
         self.assertIn("Format: subject action scope", self.buffer.getvalue())
         self.assertIn(example_text, self.buffer.getvalue())
 
@@ -148,17 +122,9 @@ def test_run_interactive_mode_maintains_interactive_loop(self):
         self.assertEqual(mock_input.call_count, len(input_values))
 
     @data(
-        [
-            f"{make_user_key('alice')} {make_action_key('read')} {make_scope_key('org', 'OpenedX')}"
-        ],
-        [
-            f"{make_user_key('bob')} {make_action_key('read')} {make_scope_key('org', 'OpenedX')}"
-        ]
-        * 5,
-        [
-            f"{make_user_key('john')} {make_action_key('read')} {make_scope_key('org', 'OpenedX')}"
-        ]
-        * 10,
+        [f"{make_user_key('alice')} {make_action_key('read')} {make_scope_key('org', 'OpenedX')}"],
+        [f"{make_user_key('bob')} {make_action_key('read')} {make_scope_key('org', 'OpenedX')}"] * 5,
+        [f"{make_user_key('john')} {make_action_key('read')} {make_scope_key('org', 'OpenedX')}"] * 10,
     )
     def test_run_interactive_mode_processes_request(self, user_input: list[str]):
         """Test that the interactive mode processes the request."""
@@ -216,9 +182,7 @@ def test_interactive_request_invalid_format(self):
         invalid_output = self.buffer.getvalue()
         self.assertIn("✗ Invalid format. Expected 3 parts, got 2", invalid_output)
         self.assertIn("Format: subject action scope", invalid_output)
-        self.assertIn(
-            f"Example: {user_input} {make_scope_key('org', 'OpenedX')}", invalid_output
-        )
+        self.assertIn(f"Example: {user_input} {make_scope_key('org', 'OpenedX')}", invalid_output)
 
     @data(ValueError(), IndexError(), TypeError())
     def test_interactive_request_error(self, exception: Exception):

openedx_authz/tests/test_enforcement.py

@@ -139,9 +139,7 @@ class SystemWideRoleTests(CasbinEnforcementTestCase):
         {
             "subject": make_user_key("user-1"),
             "action": make_action_key("manage"),
-            "scope": make_scope_key(
-                "course", "course-v1:any-org+any-course+any-course-run"
-            ),
+            "scope": make_scope_key("course", "course-v1:any-org+any-course+any-course-run"),
             "expected_result": True,
         },
         {
@@ -169,19 +167,8 @@ class ActionGroupingTests(CasbinEnforcementTestCase):
     """
 
     POLICY = [
-        [
-            "p",
-            make_role_key("role-1"),
-            make_action_key("manage"),
-            make_scope_key("org", "*"),
-            "allow",
-        ],
-        [
-            "g",
-            make_user_key("user-1"),
-            make_role_key("role-1"),
-            make_scope_key("org", "any-org"),
-        ],
+        ["p", make_role_key("role-1"), make_action_key("manage"), make_scope_key("org", "*"), "allow"],
+        ["g", make_user_key("user-1"), make_role_key("role-1"), make_scope_key("org", "any-org")],
     ] + COMMON_ACTION_GROUPING
 
     CASES = [
@@ -229,112 +216,29 @@ class RoleAssignmentTests(CasbinEnforcementTestCase):
     POLICY = [
         # Policies
         ["p", make_role_key("platform_admin"), make_action_key("manage"), "*", "allow"],
-        [
-            "p",
-            make_role_key("org_admin"),
-            make_action_key("manage"),
-            make_scope_key("org", "*"),
-            "allow",
-        ],
-        [
-            "p",
-            make_role_key("org_editor"),
-            make_action_key("edit"),
-            make_scope_key("org", "*"),
-            "allow",
-        ],
-        [
-            "p",
-            make_role_key("org_author"),
-            make_action_key("write"),
-            make_scope_key("org", "*"),
-            "allow",
-        ],
-        [
-            "p",
-            make_role_key("course_admin"),
-            make_action_key("manage"),
-            make_scope_key("course", "*"),
-            "allow",
-        ],
-        [
-            "p",
-            make_role_key("library_admin"),
-            make_action_key("manage"),
-            make_scope_key("lib", "*"),
-            "allow",
-        ],
-        [
-            "p",
-            make_role_key("library_editor"),
-            make_action_key("edit"),
-            make_scope_key("lib", "*"),
-            "allow",
-        ],
-        [
-            "p",
-            make_role_key("library_reviewer"),
-            make_action_key("read"),
-            make_scope_key("lib", "*"),
-            "allow",
-        ],
-        [
-            "p",
-            make_role_key("library_author"),
-            make_action_key("write"),
-            make_scope_key("lib", "*"),
-            "allow",
-        ],
+        ["p", make_role_key("org_admin"), make_action_key("manage"), make_scope_key("org", "*"), "allow"],
+        ["p", make_role_key("org_editor"), make_action_key("edit"), make_scope_key("org", "*"), "allow"],
+        ["p", make_role_key("org_author"), make_action_key("write"), make_scope_key("org", "*"), "allow"],
+        ["p", make_role_key("course_admin"), make_action_key("manage"), make_scope_key("course", "*"), "allow"],
+        ["p", make_role_key("library_admin"), make_action_key("manage"), make_scope_key("lib", "*"), "allow"],
+        ["p", make_role_key("library_editor"), make_action_key("edit"), make_scope_key("lib", "*"), "allow"],
+        ["p", make_role_key("library_reviewer"), make_action_key("read"), make_scope_key("lib", "*"), "allow"],
+        ["p", make_role_key("library_author"), make_action_key("write"), make_scope_key("lib", "*"), "allow"],
         # Role assignments
         ["g", make_user_key("user-1"), make_role_key("platform_admin"), "*"],
-        [
-            "g",
-            make_user_key("user-2"),
-            make_role_key("org_admin"),
-            make_scope_key("org", "any-org"),
-        ],
-        [
-            "g",
-            make_user_key("user-3"),
-            make_role_key("org_editor"),
-            make_scope_key("org", "any-org"),
-        ],
-        [
-            "g",
-            make_user_key("user-4"),
-            make_role_key("org_author"),
-            make_scope_key("org", "any-org"),
-        ],
+        ["g", make_user_key("user-2"), make_role_key("org_admin"), make_scope_key("org", "any-org")],
+        ["g", make_user_key("user-3"), make_role_key("org_editor"), make_scope_key("org", "any-org")],
+        ["g", make_user_key("user-4"), make_role_key("org_author"), make_scope_key("org", "any-org")],
         [
             "g",
             make_user_key("user-5"),
             make_role_key("course_admin"),
             make_scope_key("course", "course-v1:any-org+any-course+any-course-run"),
         ],
-        [
-            "g",
-            make_user_key("user-6"),
-            make_role_key("library_admin"),
-            make_library_key("lib@any-org@any-library"),
-        ],
-        [
-            "g",
-            make_user_key("user-7"),
-            make_role_key("library_editor"),
-            make_library_key("lib@any-org@any-library"),
-        ],
-        [
-            "g",
-            make_user_key("user-8"),
-            make_role_key("library_reviewer"),
-            make_library_key("lib@any-org@any-library"),
-        ],
-        [
-            "g",
-            make_user_key("user-9"),
-            make_role_key("library_author"),
-            make_library_key("lib@any-org@any-library"),
-        ],
+        ["g", make_user_key("user-6"), make_role_key("library_admin"), make_library_key("lib@any-org@any-library")],
+        ["g", make_user_key("user-7"), make_role_key("library_editor"), make_library_key("lib@any-org@any-library")],
+        ["g", make_user_key("user-8"), make_role_key("library_reviewer"), make_library_key("lib@any-org@any-library")],
+        ["g", make_user_key("user-9"), make_role_key("library_author"), make_library_key("lib@any-org@any-library")],
     ] + COMMON_ACTION_GROUPING
 
     CASES = [
@@ -365,9 +269,7 @@ class RoleAssignmentTests(CasbinEnforcementTestCase):
         {
             "subject": make_user_key("user-5"),
             "action": make_action_key("manage"),
-            "scope": make_scope_key(
-                "course", "course-v1:any-org+any-course+any-course-run"
-            ),
+            "scope": make_scope_key("course", "course-v1:any-org+any-course+any-course-run"),
             "expected_result": True,
         },
         {
@@ -412,13 +314,7 @@ class DeniedAccessTests(CasbinEnforcementTestCase):
 
     POLICY = [
         ["p", make_role_key("platform_admin"), make_action_key("manage"), "*", "allow"],
-        [
-            "p",
-            make_role_key("platform_admin"),
-            make_action_key("manage"),
-            make_scope_key("org", "restricted-org"),
-            "deny",
-        ],
+        ["p", make_role_key("platform_admin"), make_action_key("manage"), make_scope_key("org", "restricted-org"), "deny"],
         ["g", make_user_key("user-1"), make_role_key("platform_admin"), "*"],
     ] + COMMON_ACTION_GROUPING
 
@@ -479,27 +375,9 @@ class WildcardScopeTests(CasbinEnforcementTestCase):
     POLICY = [
         # Policies
         ["p", make_role_key("platform_admin"), make_action_key("manage"), "*", "allow"],
-        [
-            "p",
-            make_role_key("org_admin"),
-            make_action_key("manage"),
-            make_scope_key("org", "*"),
-            "allow",
-        ],
-        [
-            "p",
-            make_role_key("course_admin"),
-            make_action_key("manage"),
-            make_scope_key("course", "*"),
-            "allow",
-        ],
-        [
-            "p",
-            make_role_key("library_admin"),
-            make_action_key("manage"),
-            make_scope_key("lib", "*"),
-            "allow",
-        ],
+        ["p", make_role_key("org_admin"), make_action_key("manage"), make_scope_key("org", "*"), "allow"],
+        ["p", make_role_key("course_admin"), make_action_key("manage"), make_scope_key("course", "*"), "allow"],
+        ["p", make_role_key("library_admin"), make_action_key("manage"), make_scope_key("lib", "*"), "allow"],
         # Role assignments
         ["g", make_user_key("user-1"), make_role_key("platform_admin"), "*"],
         ["g", make_user_key("user-2"), make_role_key("org_admin"), "*"],

openedx_authz/tests/test_filter.py

@@ -46,7 +46,7 @@ def test_initialization_with_multiple_attributes(self):
             ptype=["p"],
             v0=[make_user_key("alice")],
             v1=[make_action_key("read")],
-            v2=[make_scope_key("org", "MIT")],
+            v2=[make_scope_key("org", "MIT")]
         )
         self.assertEqual(f.ptype, ["p"])
         self.assertEqual(f.v0, [make_user_key("alice")])
@@ -138,7 +138,7 @@ def test_filter_role_assignments(self):
             ptype=["g"],
             v0=[make_user_key("alice")],
             v1=[make_role_key("admin")],
-            v2=[make_scope_key("org", "MIT")],
+            v2=[make_scope_key("org", "MIT")]
         )
         self.assertEqual(f.ptype, ["g"])
         self.assertEqual(f.v0, [make_user_key("alice")])
@@ -171,9 +171,7 @@ def test_filter_deny_policies(self):
 
     def test_filter_wildcard_resources(self):
         """Test filter for wildcard resource patterns."""
-        f = Filter(
-            ptype=["p"], v2=[make_scope_key("lib", "*"), make_scope_key("course", "*")]
-        )
+        f = Filter(ptype=["p"], v2=[make_scope_key("lib", "*"), make_scope_key("course", "*")])
         self.assertEqual(f.ptype, ["p"])
         self.assertIn(make_scope_key("lib", "*"), f.v2)
         self.assertIn(make_scope_key("course", "*"), f.v2)