Skip to content

Commit b4cbc49

Browse files
committed
refactor: rename test methods for clarity
1 parent 4c8fdb3 commit b4cbc49

1 file changed

Lines changed: 8 additions & 24 deletions

File tree

openedx_authz/tests/rest_api/test_views.py

Lines changed: 8 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -275,13 +275,7 @@ def test_get_users_in_role_invalid_params(self, query_params: dict):
275275
)
276276
@unpack
277277
@patch.object(api, "is_user_allowed")
278-
def test_get_users_in_role_permissions(
279-
self,
280-
username: str,
281-
status_code: int,
282-
return_value: bool,
283-
mock_is_allowed,
284-
):
278+
def test_get_users_in_role_permissions(self, username: str, status_code: int, return_value: bool, mock_is_allowed):
285279
"""Test retrieving users in a role with different user permissions.
286280
287281
Expected result:
@@ -318,7 +312,7 @@ def test_get_users_in_role_permissions(
318312
)
319313
@unpack
320314
@patch.object(api, "assign_role_to_user_in_scope")
321-
def test_put_add_users_to_role(
315+
def test_add_users_to_role(
322316
self,
323317
users: list[str],
324318
expected_completed: int,
@@ -353,7 +347,7 @@ def test_put_add_users_to_role(
353347
{"role": "", "scope": "lib:DemoX:CSPROB", "users": ["admin_user"]},
354348
{"role": "library_admin", "scope": "", "users": ["admin_user"]},
355349
)
356-
def test_put_add_users_to_role_invalid_data(self, request_data: dict):
350+
def test_add_users_to_role_invalid_data(self, request_data: dict):
357351
"""Test adding users with invalid request data.
358352
359353
Expected result:
@@ -375,13 +369,7 @@ def test_put_add_users_to_role_invalid_data(self, request_data: dict):
375369
)
376370
@unpack
377371
@patch.object(api, "is_user_allowed")
378-
def test_put_add_users_to_role_permissions(
379-
self,
380-
username: str,
381-
status_code: int,
382-
return_value: bool,
383-
mock_is_allowed,
384-
):
372+
def test_add_users_to_role_permissions(self, username: str, status_code: int, return_value: bool, mock_is_allowed):
385373
"""Test adding users to role with different permission scenarios.
386374
387375
Expected result:
@@ -419,7 +407,7 @@ def test_put_add_users_to_role_permissions(
419407
)
420408
@unpack
421409
@patch.object(api, "unassign_role_from_user")
422-
def test_delete_remove_users_from_role(
410+
def test_remove_users_from_role(
423411
self,
424412
users: list[str],
425413
expected_completed: int,
@@ -458,7 +446,7 @@ def test_delete_remove_users_from_role(
458446
{"role": "", "scope": "lib:DemoX:CSPROB", "users": "admin_user"},
459447
{"role": "library_admin", "scope": "", "users": "admin_user"},
460448
)
461-
def test_delete_remove_users_from_role_invalid_params(self, query_params: dict):
449+
def test_remove_users_from_role_invalid_params(self, query_params: dict):
462450
"""Test removing users with invalid query parameters.
463451
464452
Expected result:
@@ -480,12 +468,8 @@ def test_delete_remove_users_from_role_invalid_params(self, query_params: dict):
480468
)
481469
@unpack
482470
@patch.object(api, "is_user_allowed")
483-
def test_delete_remove_users_from_role_permissions(
484-
self,
485-
username: str,
486-
status_code: int,
487-
return_value: bool,
488-
mock_is_allowed,
471+
def test_remove_users_from_role_permissions(
472+
self, username: str, status_code: int, return_value: bool, mock_is_allowed
489473
):
490474
"""Test removing users from role with different permission scenarios.
491475

0 commit comments

Comments
 (0)