refactor: use the new constants

Author: MaferMazu

openedx_authz/rest_api/v1/views.py

@@ -15,6 +15,7 @@
 from rest_framework.views import APIView
 
 from openedx_authz import api
+from openedx_authz.constants import permissions
 from openedx_authz.rest_api.data import RoleOperationError, RoleOperationStatus
 from openedx_authz.rest_api.decorators import authz_permissions, view_auth_classes
 from openedx_authz.rest_api.utils import (
@@ -182,13 +183,13 @@ class RoleUserAPIView(APIView):
                     "username": "john_doe",
                     "email": "[email protected]",
                     "full_name": "John Doe"
-                    "roles": ["library_admin", "library_user"]
+                    "roles": [roles.LIBRARY_ADMIN, roles.LIBRARY_USER]
                 },
                 {
                     "username": "jane_doe",
                     "email": "[email protected]",
                     "full_name": "Jane Doe"
-                    "roles": ["library_user"]
+                    "roles": [roles.LIBRARY_USER]
                 }
             ]
         }
@@ -223,7 +224,7 @@ class RoleUserAPIView(APIView):
     PUT /api/authz/v1/roles/users/ ::
 
         {
-            "role": "library_admin",
+            "role": roles.LIBRARY_ADMIN,
             "scope": "lib:DemoX:CSPROB",
             "users": ["[email protected]", "username2"]
         }
@@ -250,7 +251,7 @@ class RoleUserAPIView(APIView):
             status.HTTP_401_UNAUTHORIZED: "The user is not authenticated or does not have the required permissions",
         },
     )
-    @authz_permissions(["view_library_team"])
+    @authz_permissions([permissions.VIEW_LIBRARY_TEAM])
     def get(self, request: HttpRequest) -> Response:
         """Retrieve all users with role assignments within a specific scope."""
         serializer = ListUsersInRoleWithScopeSerializer(data=request.query_params)
@@ -277,7 +278,7 @@ def get(self, request: HttpRequest) -> Response:
             status.HTTP_401_UNAUTHORIZED: "The user is not authenticated or does not have the required permissions",
         },
     )
-    @authz_permissions(["manage_library_team"])
+    @authz_permissions([permissions.MANAGE_LIBRARY_TEAM])
     def put(self, request: HttpRequest) -> Response:
         """Assign multiple users to a specific role within a scope."""
         serializer = AddUsersToRoleWithScopeSerializer(data=request.data)
@@ -324,7 +325,7 @@ def put(self, request: HttpRequest) -> Response:
             status.HTTP_401_UNAUTHORIZED: "The user is not authenticated or does not have the required permissions",
         },
     )
-    @authz_permissions(["manage_library_team"])
+    @authz_permissions([permissions.MANAGE_LIBRARY_TEAM])
     def delete(self, request: HttpRequest) -> Response:
         """Remove multiple users from a specific role within a scope."""
         serializer = RemoveUsersFromRoleWithScopeSerializer(data=request.query_params)
@@ -399,13 +400,15 @@ class RoleListView(APIView):
             "previous": null,
             "results": [
                 {
-                    "role": "library_author",
+                    "role": roles.LIBRARY_AUTHOR,
                     "permissions": ["delete_library_content", "edit_library"],
                     "user_count": 5
                 },
                 {
-                    "role": "library_user",
-                    "permissions": ["view_library", "view_library_team", "reuse_library_content"],
+                    "role": roles.LIBRARY_USER,
+                    "permissions": [permissions.VIEW_LIBRARY,
+                    permissions.VIEW_LIBRARY_TEAM,
+                    permissions.REUSE_LIBRARY_CONTENT],
                     "user_count": 12
                 }
             ]
@@ -427,7 +430,7 @@ class RoleListView(APIView):
             status.HTTP_401_UNAUTHORIZED: "The user is not authenticated or does not have the required permissions",
         },
     )
-    @authz_permissions(["view_library_team"])
+    @authz_permissions([permissions.VIEW_LIBRARY_TEAM])
     def get(self, request: HttpRequest) -> Response:
         """Retrieve all roles and their permissions for a specific scope."""
         serializer = ListRolesWithScopeSerializer(data=request.query_params)

openedx_authz/tests/api/test_data.py

@@ -17,6 +17,7 @@
     SubjectData,
     UserData,
 )
+from openedx_authz.constants import permissions, roles
 
 
 @ddt
@@ -372,7 +373,7 @@ def test_user_data_str_and_repr(self, external_key, expected_str, expected_repr)
     @data(
         ("read", "Read", "act^read"),
         ("write", "Write", "act^write"),
-        ("delete_library", "Delete Library", "act^delete_library"),
+        (permissions.DELETE_LIBRARY, "Delete Library", "act^delete_library"),
         ("edit_content", "Edit Content", "act^edit_content"),
     )
     @unpack
@@ -413,7 +414,7 @@ def test_scope_data_str_and_repr(self, external_key, expected_str, expected_repr
 
     @data(
         ("instructor", "Instructor", "role^instructor"),
-        ("library_admin", "Library Admin", "role^library_admin"),
+        (roles.LIBRARY_ADMIN, "Library Admin", "role^library_admin"),
         ("course_staff", "Course Staff", "role^course_staff"),
     )
     @unpack
@@ -454,7 +455,7 @@ def test_role_data_str_with_permissions(self):
         ("read", "allow", "Read - allow", "act^read => allow"),
         ("write", "deny", "Write - deny", "act^write => deny"),
         (
-            "delete_library",
+            permissions.DELETE_LIBRARY,
             "allow",
             "Delete Library - allow",
             "act^delete_library => allow",
@@ -485,7 +486,7 @@ def test_role_assignment_data_str(self):
         """
         user = UserData(external_key="john_doe")
         role1 = RoleData(external_key="instructor")
-        role2 = RoleData(external_key="library_admin")
+        role2 = RoleData(external_key=roles.LIBRARY_ADMIN)
         scope = ContentLibraryData(external_key="lib:DemoX:CSPROB")
         assignment = RoleAssignmentData(subject=user, roles=[role1, role2], scope=scope)
 
@@ -502,7 +503,7 @@ def test_role_assignment_data_repr(self):
         """
         user = UserData(external_key="john_doe")
         role1 = RoleData(external_key="instructor")
-        role2 = RoleData(external_key="library_admin")
+        role2 = RoleData(external_key=roles.LIBRARY_ADMIN)
         scope = ContentLibraryData(external_key="lib:DemoX:CSPROB")
         assignment = RoleAssignmentData(subject=user, roles=[role1, role2], scope=scope)