squash!: cleanup

Author: rodmgwgu

openedx_authz/api/data.py

@@ -252,7 +252,7 @@ def get_subclass_by_external_key(mcs, external_key: str) -> Type["ScopeData"]:
         """
 
         # Special case: handle the global wildcard scope:
-        if external_key == "*":
+        if external_key == GLOBAL_SCOPE_WILDCARD:
             return mcs.glob_registry.get("global")
 
         if EXTERNAL_KEY_SEPARATOR not in external_key:

openedx_authz/tests/api/test_data.py

@@ -366,11 +366,11 @@ def test_scope_validate_external_key(self, external_key, expected_valid, expecte
         self.assertEqual(result, expected_valid)
 
     @data(
-        "undefined:DemoX",
-        "undefined:DemoX:*",
+        "unknown:DemoX",
+        "unknown:DemoX:*",
     )
-    def test_get_subclass_by_external_key_undefined_scope_raises_value_error(self, external_key):
-        """Undefined namespace should raise ValueError, including wildcard keys."""
+    def test_get_subclass_by_external_key_unknown_scope_raises_value_error(self, external_key):
+        """Inknown namespace should raise ValueError, including wildcard keys."""
         with self.assertRaises(ValueError):
             ScopeMeta.get_subclass_by_external_key(external_key)
 

openedx_authz/tests/api/test_roles.py

@@ -922,7 +922,7 @@ class TestRoleAssignmentAPI(RolesTestSetupMixin):
     """
 
     @ddt_data(
-        (["mary", "john"], roles.LIBRARY_USER.external_key, "*", True),
+        (["mary", "john"], roles.LIBRARY_USER.external_key, "global:batch_test", True),
         (
             ["paul", "diana", "lila"],
             roles.LIBRARY_CONTRIBUTOR.external_key,