Skip to content

Commit 707d0b3

Browse files
committed
refactor: simplify validated_scopes list in AddUsersToRoleWithScopeSerializer
1 parent 0a59946 commit 707d0b3

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

openedx_authz/rest_api/v1/serializers.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,6 @@ def validate(self, attrs) -> dict:
131131
"Either 'scope' or 'scopes' must be provided."
132132
)
133133

134-
validated_scopes = []
135134
for scope_value in scopes_list:
136135
try:
137136
scope_obj = api.ScopeData(external_key=scope_value)
@@ -150,10 +149,8 @@ def validate(self, attrs) -> dict:
150149
{"role": f"Role '{role_value}' does not exist in scope '{scope_value}'"}
151150
)
152151

153-
validated_scopes.append(scope_value)
154-
155152
validated_data.pop("scope", None)
156-
validated_data["scopes"] = validated_scopes
153+
validated_data["scopes"] = scopes_list
157154
return validated_data
158155

159156

0 commit comments

Comments
 (0)