refactor: address quality issues

Author: mariajgrimaldi

openedx_authz/api/roles.py

@@ -22,7 +22,6 @@
 from openedx_authz.api.permissions import get_permission_from_policy
 from openedx_authz.engine.enforcer import AuthzEnforcer
 
-
 __all__ = [
     "get_permissions_for_single_role",
     "get_permissions_for_roles",

openedx_authz/apps.py

@@ -3,7 +3,6 @@
 """
 
 from django.apps import AppConfig
-from django.core.exceptions import ImproperlyConfigured
 
 
 class OpenedxAuthzConfig(AppConfig):
@@ -40,10 +39,3 @@ class OpenedxAuthzConfig(AppConfig):
             },
         },
     }
-
-    def ready(self):
-        """Initialization layer for the openedx_authz app."""
-        # DO NOT initialize the enforcer here to avoid issues when
-        # apps are not fully loaded (e.g., while pulling translations).
-        # It's best to lazy load the enforcer when needed it's first used.
-        pass

openedx_authz/engine/apps.py

@@ -1,14 +1,20 @@
+"""Initialization for the casbin_adapter Django application.
+
+This overrides the default AppConfig to avoid making queries to the database
+when the app is not fully loaded (e.g., while pulling translations). Moved
+the initialization of the enforcer to a lazy load when it's first used.
+
+See openedx_authz/engine/enforcer.py for the enforcer implementation.
+"""
+
 from django.apps import AppConfig
-from django.conf import settings
-from django.core.exceptions import ImproperlyConfigured
 
 
 class CasbinAdapterConfig(AppConfig):
     name = "casbin_adapter"
 
     def ready(self):
-        """Initialization layer for the casbin_adapter app."""
+        """Initialize the casbin_adapter app."""
         # DO NOT initialize the enforcer here to avoid issues when
         # apps are not fully loaded (e.g., while pulling translations).
         # It's best to lazy load the enforcer when needed it's first used.
-        pass

openedx_authz/engine/enforcer.py

@@ -19,11 +19,11 @@
 import logging
 
 from casbin import FastEnforcer
+from casbin_adapter.enforcer import initialize_enforcer
 from django.conf import settings
 
 from openedx_authz.engine.adapter import ExtendedAdapter
 from openedx_authz.engine.watcher import Watcher
-from casbin_adapter.enforcer import initialize_enforcer
 
 logger = logging.getLogger(__name__)
 
@@ -86,7 +86,7 @@ def _initialize_enforcer() -> FastEnforcer:
             # Best to lazy load it when it's first used to ensure the database is ready and avoid
             # issues when the app is not fully loaded (e.g., while pulling translations, etc.).
             initialize_enforcer(db_alias)
-        except Exception as e:  # pylint: disable=broad-exception-caught
+        except Exception as e:
             logger.error(f"Failed to initialize Casbin enforcer with DB alias '{db_alias}': {e}")
             raise
 

openedx_authz/management/commands/load_policies.py

@@ -16,7 +16,6 @@
 from openedx_authz.engine.utils import migrate_policy_between_enforcers
 
 
-
 class Command(BaseCommand):
     """Django management command to load policies into the authorization Django model.
 

openedx_authz/tests/api/test_roles.py

@@ -35,7 +35,6 @@
 from openedx_authz.engine.utils import migrate_policy_between_enforcers
 
 
-
 class BaseRolesTestCase(TestCase):
     """Base test case with helper methods for roles testing.