refactor: drop all in tests

Author: mariajgrimaldi

openedx_authz/engine/utils.py

@@ -233,7 +233,6 @@ def migrate_legacy_course_roles_to_authz(course_access_role_model, course_id_lis
         course_access_role_model.objects.filter(**course_access_role_filter)
         .filter(Q(course_id=CourseKeyField.Empty) | Q(course_id__startswith=CourseOverviewData.NAMESPACE))
         .select_related("user")
-        .all()
     )
 
     # List to keep track of any permissions that could not be migrated

openedx_authz/tests/test_migrations.py

@@ -301,15 +301,15 @@ class MockQuerySet:
             def __init__(self, permissions):
                 self.permissions = permissions
 
+            def __iter__(self):
+                return iter(self.permissions)
+
             def filter(self, *args, **kwargs):
                 return self
 
             def select_related(self, *args, **kwargs):
                 return self
 
-            def all(self):
-                return self.permissions
-
             def get_or_create(self):
                 raise Exception("Unexpected error mock")
 
@@ -1191,7 +1191,7 @@ def test_migrate_legacy_course_roles_to_authz_instance_wide_role_is_error(self):
         mock_qs = MagicMock()
         mock_qs.filter.return_value = mock_qs
         mock_qs.select_related.return_value = mock_qs
-        mock_qs.all.return_value = [instance_wide_permission]
+        mock_qs.__iter__ = MagicMock(return_value=iter([instance_wide_permission]))
 
         mock_model = MagicMock()
         mock_model.objects.filter.return_value = mock_qs